From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC710C43387 for ; Wed, 9 Jan 2019 16:37:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA640206BB for ; Wed, 9 Jan 2019 16:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbfAIQhj (ORCPT ); Wed, 9 Jan 2019 11:37:39 -0500 Received: from shell.v3.sk ([90.176.6.54]:53952 "EHLO shell.v3.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbfAIQhi (ORCPT ); Wed, 9 Jan 2019 11:37:38 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 68B7A1000C5; Wed, 9 Jan 2019 17:37:34 +0100 (CET) Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Hh05FATkgNsK; Wed, 9 Jan 2019 17:37:31 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id D7FBF10018A; Wed, 9 Jan 2019 17:37:30 +0100 (CET) X-Virus-Scanned: amavisd-new at zimbra.v3.sk Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id azRuJ2pndiVY; Wed, 9 Jan 2019 17:37:30 +0100 (CET) Received: from belphegor (nat-pool-brq-t.redhat.com [213.175.37.10]) by zimbra.v3.sk (Postfix) with ESMTPSA id D1107100189; Wed, 9 Jan 2019 17:37:29 +0100 (CET) Message-ID: <3b9c5e7e35ae25316bf4551ebf7ae21238d64f03.camel@v3.sk> Subject: Re: [PATCH v4 00/15] Add support for OLPC XO 1.75 Embedded Controller From: Lubomir Rintel To: Andy Shevchenko Cc: Andy Shevchenko , Darren Hart , Platform Driver , Russell King , James Cameron , Mark Rutland , Pavel Machek , Rob Herring , Sebastian Reichel , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , linux-arm Mailing List , devicetree , Linux PM , Linux Kernel Mailing List Date: Wed, 09 Jan 2019 17:37:28 +0100 In-Reply-To: References: <20190108175818.705110-1-lkundrak@v3.sk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.3 (3.30.3-1.fc29) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-01-09 at 13:15 +0200, Andy Shevchenko wrote: > On Tue, Jan 8, 2019 at 7:58 PM Lubomir Rintel wrote: > > Hello! > > > > This is a fourth spin of the patch set that adds support for the > > Embedded Controller on an OLPC XO 1.75 machine. > > > > It hopefully incorporated all feedback received previously and also > > fixes the kbuild test bot failures. The failed builds were > > generally > > caused by configurations where the EC driver was built as module. > > > > It turned out that the patch that turned the OLPC EC common code > > into > > a module was not the brightest idea. I now dropped it and modified > > the > > 04/15 to not require it. > > > > Also, the 01/15 patch has been added to allow the module to provide > > a > > reboot handler. Patch 15/15 depends on it. > > Isn't it a quite big distance between provider and consumer? > Especially taking into consideration concerns about patch 1 which > blocks the series. > Perhaps you may drop it as a patch 1 and do something on top of patch > 15 as feature extension? Yes, that is a good idea. I'll do so when I submit a new version of the set (in few days' time). I think the battery part can be split from the EC part too. Would that be a good idea to send them as separate patch sets next time? It seems to me now that they probably ought to end up going in via different trees (linux-power-supply vs linux-platform-drivers-x86). > > Tested to work on an OLPC XO 1.75 and also tested not to break x86 > > support with an OLPC XO 1 machine. I don't have a XO 1.5, but it's > > unlikely this breaks it when XO 1 works. > > > > [01/15] ARM: export arm_pm_restart() > > [02/15] dt-bindings: olpc,xo1.75-ec: Add OLPC XO-1.75 EC bindings > > [03/15] Platform: OLPC: Remove an unused include > > [04/15] Platform: OLPC: Add XO-1.75 EC driver > > [05/15] Platform: OLPC: Avoid a warning if the EC didn't register > > yet > > [06/15] Platform: OLPC: Move EC-specific functionality out from x86 > > [07/15] Platform: OLPC: Use BIT() and GENMASK() for event masks > > [08/15] Platform: OLPC: add a regulator for the DCON > > [09/15] dt-bindings: olpc_battery: Add XO-1.5 battery > > [10/15] x86, olpc: Use a correct version when making up a battery > > node > > [11/15] power: supply: olpc_battery: Use DT to get battery version > > [12/15] power: supply: olpc_battery: Move priv data to a struct > > [13/15] power: supply: olpc_battery: Use > > devm_power_supply_register() > > [14/15] power: supply: olpc_battery: Avoid using platform_info > > [15/15] power: supply: olpc_battery: Add OLPC XO 1.75 support > > > > Lubo > > > > > >