From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78A463F926B for ; Thu, 9 Jul 2026 08:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783585412; cv=none; b=e+fo+m9GI4UDmjOjki02dwS1aMs2cUr7d3eOwdxMD8fVsWK5JqtnMGJ9McpnpRMO9Jg643Pv84T3FG5ZWUP78cafRwMPYsgr5QArW1UpLxagC5jX3Vh728bHxXr5jjBMsZ3T3ZTkUZ+UllwbxqWM82gXhaHCpGY6/Ql7BjOkuMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783585412; c=relaxed/simple; bh=134ufy4mmxPCaUX9tTVJwnO59LWqPJlkTcKMtmq1QQw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DXnO77JRUJXK88N6gxYgrwf5UmxgEqRB3qyQ2PaBakVYz5guF9Ue3cworq2iVNR+Qw3yLPNGULMUWzl24GCav3Fa8yoA/TSRQtTffc0zhA8x2BM2dmhy6iSxPA7uLncvxB3ksStXhTRANtWQFkvVKQ8rgPYVMvgwPq+ooQJgJ6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b5QQpBeM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P244gWBB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b5QQpBeM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P244gWBB" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66960PFB784605 for ; Thu, 9 Jul 2026 08:23:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= em6hRThTjmpK+umvlO1H6MSd9jDxUbf1zD7dWYPZFpQ=; b=b5QQpBeM9t+6pFMc 74J69gGJ5C6ePwsMhBgzHybMrF6+CZlYJeQCb+LIMdwOW89DvfzyKssSObFeTHZe iz9Pz36OJ2gW/iyD8sMnzXmXQKgZxmr1nDUuUUQIwy2qOqowYOl1dQGATRl8hFCn ECKAh8soYT2mLC6Crcs/ZvscSUVQiDgexHoXvKEjop5ov48ihHpLx0Tu7RLWFJXn kuzLy7Jgz8E3AXwo8HvHsaFDB/qX2tlYv1j+8cFXyUjRkbvHi/8qYJBz/fjITbMN B54rgKNi3NyLvsiKOFRISAcPd1CQbcpivJ/UM2ux/Kt/OPXLceeCH4c+AzN0z9Mq 3ov5nA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9v4u2nys-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Jul 2026 08:23:30 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e538afe65so89180285a.3 for ; Thu, 09 Jul 2026 01:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783585410; x=1784190210; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=em6hRThTjmpK+umvlO1H6MSd9jDxUbf1zD7dWYPZFpQ=; b=P244gWBB764HE47V9w+Gg/OVyxc9vELrTUwxFtB21dfHTE/+INS+7cZWYXGmHQF13e HkW38Efj4wh2bsbaU/Ig2NRCEpXD0RxNTYrkY2LvRMa5X5lyCM4kYCH5u6EqK2Lj153I RN6kQGlL4Rezz2RuuutyTSPlynUXMVR8uAi9QUJSVqY1FEm1LnmQbVF5nev8mOyMUkgB f3h8msYZ0vc+kDRpXvjVXTvi+o0cRuF9tRmfiaRyrNzMBPL6WpLWmTqc3SU54Z3z+Eyj kdArRxhzvnZqMGcd3d/W33AKFwjhSj1Uups75X+DmK30+s9j//ksL+nrj1PHPZjLmEOS kLkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783585410; x=1784190210; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=em6hRThTjmpK+umvlO1H6MSd9jDxUbf1zD7dWYPZFpQ=; b=MbflYjfTm/9t3V8mHj2T0mf9+DaEwzB2A8RrhIL9UcZQJE0RSfkktw04vQcdmqSGmi He6EBPxssbSiLbCmbm2EQYR7jDY3GD8wI9Y1Z18hWpJ+JOqtzGptZdUJ73P15QocsQcz rQqUI04H/dpx3mp6i4M5ZGipmsdnLe6lIdFNc9YhGe09xdQeZDzt24bVDR5z2AvmCRZJ q5IkXSwUGBwtWkgoZSjx4xJYwtW4JkkXnqagg3I1SimOF/Ru8NNeM5bNyrh2T9rlPD3H QmFpD27oKr+USqQnA82nVCdHalM7+Clh31sgNdqSpFVDvnv6jYApVelJ38rL+wCR1BMs MVXA== X-Forwarded-Encrypted: i=1; AHgh+RogtgeUZczdT3ZrvIYs5f+eBnp5CelDLfRZKrcv67coNEgkZwokALkgpBtINs8i44xhKgxe+EBlCcYwagk=@vger.kernel.org X-Gm-Message-State: AOJu0YzkLWNhF2a1ENgoTA/ly9qHmbLmuM1QCPSwDbMZ05HAhDJCkovE iJ33zAK/topOtDBqI/5feAZphsJx/WaJDaCCvFShwknIaYfva6OYuea35oe7/v7dQRhs0xC6qYI EwkeHr/SfpdU7t0aEOv4NUICfwNDSWnwNDMjRKNlpc2DVwkqm69GOcQOsDM/YEFhfuJM= X-Gm-Gg: AfdE7cm86eSMeh6XZERKm8+Zp/cPDcc0FUahTeW/O53dh8BYSmkh+/IVKvWbs/6cmU/ 4ofXfhobOkhKZZ+un2/a59EtwJpNRrtNbUd2r8MBTR0ww03SxC++BCLleEkaeYVB4Ke1J8Zpgqb EKjbkfkLpuSuAK4s/IvfT+8LqYqeERFKLm4hWj+dHbYq2gSrJe6QBP4zz/7qZzAMGnxS3Kk962d +zBVRDx23cPMjVUjZb14d7n56U6ys2IY21wsElYLhxFcs68YkAwEz7ojGjmL4fDHHfccOMv4zp/ o5xV1Bfn+p18gWzXKv+YwtegFlRyPJ15QsiF2UamY0P0jRgFapdJVEnmeysfkbzV6YUTlowyqaH Oy8FYAkH0Xj9DWSG/rrvg1YQ+JO6AyFrRCDZS73FPsnmK X-Received: by 2002:a05:622a:2282:b0:519:e91a:f4bb with SMTP id d75a77b69052e-51c8b2df9a9mr62944281cf.31.1783585409719; Thu, 09 Jul 2026 01:23:29 -0700 (PDT) X-Received: by 2002:a05:622a:2282:b0:519:e91a:f4bb with SMTP id d75a77b69052e-51c8b2df9a9mr62944101cf.31.1783585409169; Thu, 09 Jul 2026 01:23:29 -0700 (PDT) Received: from [10.111.138.111] ([212.136.9.21]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15c1470325sm288040366b.14.2026.07.09.01.23.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 01:23:28 -0700 (PDT) Message-ID: <3b9f1b3d-4c06-4006-82d5-d59ce2101070@oss.qualcomm.com> Date: Thu, 9 Jul 2026 10:23:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/10] dt-bindings: firmware: qcom: tmd: add TMD device type constants To: Dmitry Baryshkov Cc: Gaurav Kohli , Konrad Dybcio , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi References: <10a346d8-fbb1-4142-a650-507c3917b8f6@oss.qualcomm.com> <1aca8d60-8e39-4532-9095-a5260bba76ac@oss.qualcomm.com> <9dc4b29e-e9fb-421a-b789-eb16a68ff915@oss.qualcomm.com> <2tu35aavp7sc2npni33ky5bve57idzy3bzp2pk7eh5lryq3r4v@gmm3dhayu4cf> <6f179f96-fdd1-4fa9-b26c-df7372eb6d20@oss.qualcomm.com> <54250163-678f-41e7-97d0-6596123367f1@oss.qualcomm.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA5MDA3OSBTYWx0ZWRfXyzE1ufSir4N9 sh50HKYpd63meePdVslHaFle6z+g2HALkVeuXZtDohAon9UzRZeGvju+L7DTi8yDkLcwtLg9TC4 cZsFJz132uikI4CXqEoX258Tq6MM/nU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA5MDA3OSBTYWx0ZWRfXxE1c/q/gyVxY jvO7GjxDIbQf9+s21LncQwHHm7LLDESm1E3mhhGkD9XfDPO/inLKkAsgZonEFeYOInvpO6mmN2h Een5gEotuyJEub2L7Sdb+rCQg0GMWwS62cRXwbXv/F3mvrRoVLlqwM16ZrDzFNbLYSMvDz7eB9O qtTmyn33/60hlk7BmfVAuaIve8DpgvvpQycAwMYCvSpVqGjretXjnts4deHuWcb/FryV4zIYxuH mtB+LyavXnBX0XsLxGyjMSPO1yDMAcSJ7R2j2bA7Zi4GXwfQCnMj5Mckcbus7zmZDDsPoUycXnh WBLBlH6VhR+MoCqlktcYV/9k8FC3RJJNrEiCOJjS9AUJOnSub2oju581UYxRgXWnFoOaCqRsA2+ xhDuGBTk7T74bG3C+FXN8UUpyOfT31LQo2w9u+7RUi7bnRjpUw6lirLRxriPauAmGsAE617y68W WwP0mSCHDYuiJ54Nlrg== X-Proofpoint-GUID: O1OwEe5l52nB20dOK-9F0OHU-OYTuf2e X-Proofpoint-ORIG-GUID: O1OwEe5l52nB20dOK-9F0OHU-OYTuf2e X-Authority-Analysis: v=2.4 cv=QoVuG1yd c=1 sm=1 tr=0 ts=6a4f5a82 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=/bviTfK1dmy+WGcHzWQ0gg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=NEAV23lmAAAA:8 a=EUspDBNiAAAA:8 a=ftX-3Su0G3PhC2htbk0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_01,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 adultscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 phishscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607090079 Le 09/07/2026 à 09:58, Dmitry Baryshkov a écrit : > On Thu, Jul 09, 2026 at 09:42:04AM +0200, Daniel Lezcano wrote: >> >> >> Le 09/07/2026 à 09:37, Dmitry Baryshkov a écrit : >>> On Thu, Jul 09, 2026 at 10:54:26AM +0530, Gaurav Kohli wrote: >>>> >>>> >>>> On 7/8/2026 7:55 PM, Dmitry Baryshkov wrote: >>>>> On Tue, Jul 07, 2026 at 03:55:13PM +0530, Gaurav Kohli wrote: >>>>>> >>>>>> >>>>>> On 7/7/2026 1:04 AM, Dmitry Baryshkov wrote: >>>>>>> On Mon, Jul 06, 2026 at 08:11:35PM +0200, Daniel Lezcano wrote: >>>>>>>> On 7/6/26 19:47, Dmitry Baryshkov wrote: >>>>>>>>> On Mon, Jul 06, 2026 at 07:03:18PM +0200, Daniel Lezcano wrote: >>>>>>>>>> On 7/3/26 17:42, Dmitry Baryshkov wrote: >>>>>>>>>>> On Fri, Jul 03, 2026 at 07:43:39PM +0530, Gaurav Kohli wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 7/3/2026 1:23 PM, Konrad Dybcio wrote: >>>>>>>>>>>>> On 7/3/26 7:03 AM, Gaurav Kohli wrote: >>>>>>>>>>>>>> Add Device Tree binding constants for Qualcomm Thermal Mitigation >>>>>>>>>>>>>> Device (TMD) types used by remoteproc-backed thermal cooling devices. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Qualcomm remote processors expose thermal mitigation endpoints >>>>>>>>>>>>>> through QMI. These endpoints can be registered with the thermal >>>>>>>>>>>>>> framework via the `#cooling-cells` property on the remoteproc node. >>>>>>>>>>>>>> >>>>>>>>>>>>>> The QMI TMD protocol identifies devices using string names (for example, >>>>>>>>>>>>>> "pa", "modem", and "cdsp_sw"), while the DT cooling-device binding with >>>>>>>>>>>>>> `#cooling-cells = <3>` requires numeric device id in the form: >>>>>>>>>>>>>> >>>>>>>>>>>>>> <&phandle device_id min_state max_state> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Define common TMD device index constants shared across currently >>>>>>>>>>>>>> supported platforms. If a future target requires a different mapping, >>>>>>>>>>>>>> additional target-specific constants can be introduced while preserving >>>>>>>>>>>>>> existing DT ABI. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Signed-off-by: Gaurav Kohli >>>>>>>> >>>>>>>> [ ... ] >>>>>>>> >>>>>>>>>>> Why are you using only those TMD devices? >>>>>>>>>>> >>>>>>>>>>>> More constants can be added as needed. >>>>>>>>>>> >>>>>>>>>>> Kodiak is one of the supported platforms. >>>>>>>>>> >>>>>>>>>> What would be the benefit of having more than thirteen cooling devices >>>>>>>>>> declared in the thermal framework and having only a couple of them mapped in >>>>>>>>>> a thermal zone ? >>>>>>>>>> >>>>>>>>>> I agree there are more TMDs but if they are unused for the moment, why do we >>>>>>>>>> need to add them ? Can we do that incrementally ? >>>>>>>>> >>>>>>>>> That's what I am trying to understand: why the implementation uses only >>>>>>>>> the selected two devices, if the modem on Kodiak supports others. How >>>>>>>>> can we find out, which TMDs to use on other devices. >>>>>>>> >>>>>>>> My understanding is that is an initial thermal setup. Gaurav will add them >>>>>>>> step by step while setting up all the thermal zones instead of sending a big >>>>>>>> patchset. And TBH, that will be much easier to review. >>>>>>> >>>>>>> In such a case it should be noted in the commit message and/or cover >>>>>>> letter. >>>>>> >>>>>> Thanks for the review/guidance. Not all TMD endpoints are relevant for >>>>>> kernel thermal zone binding — some like BCL and cold temperature are handled >>>>>> from userspace when needed. The constants here cover only >>>>> >>>>> What if there is no userspace? Or the userspace is different from what >>>>> you expect? I doubt we have TMD-speaking userspace yet. >>>> >>>> Thanks for mail, The TMD userspace implementation is available upstream at >>>> https://github.com/qualcomm/qmi-framework. >>> >>> Is it? >>> >>> lumag@rohan:/tmp/qmi-framework$ git grep -i tmd >>> lumag@rohan:/tmp/qmi-framework$ >>> >>> I found no traces of TMD there. Moreover, I don't see why QMI framework >>> implementation would react to thermal events. >>> >>>>>> what is needed for modem and CDSP thermal zones on the currently posted >>>>>> targets. >>>>> >>>>> Again, SLPI, ADSP? >>>> >>>> Sorry, I should have said "generic subsystems" rather than listing specific >>>> ones. SLPI and ADSP do not require active thermal mitigation on these >>>> platforms. >>> >>> Could you please provide details, then. What is cpuv_restriction_cold >>> TMD? >> >> It warms up the zone when the temperature is too cold > > So, if we ever get back to supporting warming up, these TMDs would > become relevant. Am I right? Probably Can we do some progress with these TMDs definition ? Spending 95% of the effort to discuss 1% of the proposed changes, which is always DT discussion, is quite frustrating :/ You want to add all defines for existing TMDs for all platforms ? We are talking about numerical values right ? Why is it a problem to add their define later ?