From: Tom Rix <trix@redhat.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: njavali@marvell.com, jejb@linux.ibm.com,
martin.petersen@oracle.com,
GR-QLogic-Storage-Upstream@marvell.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition
Date: Mon, 30 Nov 2020 08:16:59 -0800 [thread overview]
Message-ID: <3baa674f-ce34-34a9-26ec-1d3e0e2ebdcd@redhat.com> (raw)
In-Reply-To: <20201130091753.4wyrzlbrqszdzy6s@beryllium.lan>
On 11/30/20 1:17 AM, Daniel Wagner wrote:
> Hi Tom,
>
> On Fri, Nov 27, 2020 at 10:27:41AM -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
>
>> ---
>> drivers/scsi/qla2xxx/qla_def.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
>> index ed9b10f8537d..86d249551b2d 100644
>> --- a/drivers/scsi/qla2xxx/qla_def.h
>> +++ b/drivers/scsi/qla2xxx/qla_def.h
>> @@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
>> } while (0)
>>
>> #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
>> - atomic_dec(&__qpair->ref_count); \
>> + atomic_dec(&__qpair->ref_count) \
> Nitpick, please insert an additional tab after the remove so that the
> backlashes align again.
How about removing the last escaped newline and the next empty line ?
Tom
>
> Thanks,
> Daniel
>
next prev parent reply other threads:[~2020-11-30 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 18:27 trix
2020-11-30 9:17 ` Daniel Wagner
[not found] ` <CAHo-Oow4nPR9ODya-cPHZrsMFFPF9aUJJXfrFqLCxRzmJVMrmA@mail.gmail.com>
2020-11-30 9:34 ` Daniel Wagner
2020-11-30 16:16 ` Tom Rix [this message]
2020-11-30 16:30 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3baa674f-ce34-34a9-26ec-1d3e0e2ebdcd@redhat.com \
--to=trix@redhat.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=dwagner@suse.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®