From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BCD813774C for ; Wed, 6 Mar 2024 16:25:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709742337; cv=none; b=P5TxG+uZUpq5ONouTDHYRdexnBWs3QJpdRT0MaqO+qxlzzlw4asy7fH4AChkJUZwtlCoBUDttuX98zQbbc0LfEiuK7xkUEPDF3PjVw+l8AVBIe2AXnPEaBiXkrEVFjiCLKDdjAdzM5e9f1/R9WhpvP+QSaJw29ujw5c/mzpYpoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709742337; c=relaxed/simple; bh=xXWdLc5ycH+yuvPLxfdFChS+CKGdFWAwKl45XDmxjyk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J6I8rfad12WMv8wmCqm/x2Wff1ACrEFOrxJAUz/aeMvc1GAc9zVsC6fBZFOhSdmIPrXeRDYV3qEA4Yh3xU4vumOCC36+aw5/3w3+6YzehxrAWNllOSiRaVWrd4ptdixJrSpUmItKP0h3EerfuPl7uFmH5YkzQkeKpJ9PF35NnO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dvlTffuN; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dvlTffuN" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-51364c3d5abso766277e87.2 for ; Wed, 06 Mar 2024 08:25:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709742333; x=1710347133; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GC4h3Ht3vNoae6gXTCtlzCHjHZn8NZlxWQ90uE72zuU=; b=dvlTffuNikK9knUGo54uMuk9FbiDe7aVE3MgEUsPWE1RzIn1+gCWxxzB57y/vlIbAP oOxdGEWoU8gj7E37fBKu9EIdMpJnfh2Q/9IcpXtcH9rJBAb4K/fe8TkHGXFQcOv7tZ+E i5+zc0WRJuaPK2IMHA3a2BbSPMIsLKmIiKfc6OAcONjQmt5cl3TbL4c6CgdoCYS6/VBB JlEhGZcDh6MeXbX3eAWPQnwqCsWDfGmsCtNgX9Jd5gXPn+aBHIl+ea7FVW5B5nNVEWR3 CZUVl6NVoOHmOT/Q8Df/wXYDxKm+vvBJLr1C1DJhB6i7Cko3wjh3CnbLR53LCYIFqD3x 77vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709742333; x=1710347133; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GC4h3Ht3vNoae6gXTCtlzCHjHZn8NZlxWQ90uE72zuU=; b=gTJSYWghX6/pHNwULgBvon2SDWUk5OIlSKMPDu1OBW1ZoeeaX4DoHJpOyIrmfDaBeR OpbTnVNx12BoJfuVkd23xtPY4ZrDOQCIqRSoo9N0INGrvrupXmmdRLmorKKcqTv37r1M 8fT4i+EzUghObzJYYITneoXqOlkjpIDPm1qcxlIZ102Gh1siSGt7pd4oLbjnS23MBuR9 brDBh0vCt80dycly4KasRPmODDfsJLRtYpmdBQoXDKck8UB50opLo4Av119RyNE7pszE 6KJgKSIsJM2i2yZwjhhedjDCaD5n5SS5RGHltZPk1Mw0mXDVoTRbp82459RNscWwv3BC NNiA== X-Forwarded-Encrypted: i=1; AJvYcCVGwUOaeojslN0zKKgpnHQxqjo38u7lvUyCNz741xoP/ziJ+skFOOwcY70kmv71k1uJmqpmTUbk55UIp8UX8AZeL6pjoC3I1u6mW754 X-Gm-Message-State: AOJu0YzlRq5VK3Qli/6l+s1qQB18SiljKq4g61P5AIiR5tix5ioKY0yP pKBYnThNi2Hfy0xCq2WNjcDHwRHx+A5QLN4P2U9B2rVb5dvOsUxYUYxs+tVjf4I= X-Google-Smtp-Source: AGHT+IFgy9N9FS/+ol1bEmTGLgjs/Aqz0S9idsbDAFmzV83opyYYygqCUkKwwKWJ2gnki+iP9QqwmA== X-Received: by 2002:ac2:430c:0:b0:513:6bbc:e6fc with SMTP id l12-20020ac2430c000000b005136bbce6fcmr803184lfh.8.1709742333240; Wed, 06 Mar 2024 08:25:33 -0800 (PST) Received: from [87.246.221.128] (netpanel-87-246-221-128.pol.akademiki.lublin.pl. [87.246.221.128]) by smtp.gmail.com with ESMTPSA id u14-20020ac258ce000000b00512b7948baesm2674557lfo.41.2024.03.06.08.25.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 08:25:32 -0800 (PST) Message-ID: <3bace619-46fc-4f9f-bfb3-4c55cb4d8408@linaro.org> Date: Wed, 6 Mar 2024 17:25:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] interconnect: qcom: sc7280: enable QoS programming Content-Language: en-US To: Odelu Kukatla , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Kees Cook , cros-qcom-dts-watchers@chromium.org, "Gustavo A . R . Silva" , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, quic_rlaggysh@quicinc.com, quic_mdtipton@quicinc.com References: <20240306073016.2163-1-quic_okukatla@quicinc.com> <20240306073016.2163-3-quic_okukatla@quicinc.com> From: Konrad Dybcio In-Reply-To: <20240306073016.2163-3-quic_okukatla@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/6/24 08:30, Odelu Kukatla wrote: > Enable QoS for the master ports with predefined values > for priority and urgency. > > Signed-off-by: Odelu Kukatla > --- > drivers/interconnect/qcom/sc7280.c | 332 +++++++++++++++++++++++++++++ > 1 file changed, 332 insertions(+) > > diff --git a/drivers/interconnect/qcom/sc7280.c b/drivers/interconnect/qcom/sc7280.c > index 7d33694368e8..1e1002c4d3d8 100644 > --- a/drivers/interconnect/qcom/sc7280.c > +++ b/drivers/interconnect/qcom/sc7280.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > * Copyright (c) 2021, The Linux Foundation. All rights reserved. > + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. > * > */ > > @@ -16,29 +17,53 @@ > #include "icc-rpmh.h" > #include "sc7280.h" > > +static const struct qcom_icc_qosbox qhm_qspi_qos = { > + .num_ports = 1, > + .port_offsets = { 0x7000 }, > + .prio = 2, > + .urg_fwd = 0, > +}; > + > static struct qcom_icc_node qhm_qspi = { > .name = "qhm_qspi", > .id = SC7280_MASTER_QSPI_0, > .channels = 1, > .buswidth = 4, > + .qosbox = &qhm_qspi_qos, .qosbox = &(const struct qcom_icc_qosbox) { .num_ports = 1, ... }, Looks sensible otherwise Konrad