mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Paul Durrant <paul.durrant@citrix.com>,
	xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3] xen/privcmd: add IOCTL_PRIVCMD_MMAP_RESOURCE
Date: Mon, 9 Apr 2018 15:18:38 -0400	[thread overview]
Message-ID: <3baffa60-bcca-cbf3-f056-db30a6c5178c@oracle.com> (raw)
In-Reply-To: <bd84cd4b-1834-b631-303c-3e190ad7676d@oracle.com>

On 04/09/2018 12:36 PM, Boris Ostrovsky wrote:
> On 04/09/2018 05:36 AM, Paul Durrant wrote:
>> My recent Xen patch series introduces a new HYPERVISOR_memory_op to
>> support direct priv-mapping of certain guest resources (such as ioreq
>> pages, used by emulators) by a tools domain, rather than having to access
>> such resources via the guest P2M.
>>
>> This patch adds the necessary infrastructure to the privcmd driver and
>> Xen MMU code to support direct resource mapping.
>>
>> NOTE: The adjustment in the MMU code is partially cosmetic. Xen will now
>>       allow a PV tools domain to map guest pages either by GFN or MFN, thus
>>       the term 'mfn' has been swapped for 'pfn' in the lower layers of the
>>       remap code.
>>
>> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
> I think this will have to wait until 4.18 though, it's somewhat late for
> current merge window right now.


Warns on 32-bit ARM build:

  CC      drivers/xen/privcmd.o
In file included from /data/upstream/linux-xen/include/linux/kernel.h:14:0,
                 from /data/upstream/linux-xen/drivers/xen/privcmd.c:11:
/data/upstream/linux-xen/drivers/xen/privcmd.c: In function
‘privcmd_ioctl_mmap_resource’:
/data/upstream/linux-xen/drivers/xen/privcmd.c:788:33: warning: cast to
pointer from integer of different size [-Wint-to-pointer-cast]
    pr_info("pfn[%u] = %p\n", i, (void *)pfns[i]);
                                 ^
/data/upstream/linux-xen/include/linux/printk.h:308:34: note: in
definition of macro ‘pr_info’
  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
                                  ^~~~~~~~~~~
  AR      drivers/xen/xen-privcmd.o


-boris

  reply	other threads:[~2018-04-09 19:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09  9:36 Paul Durrant
2018-04-09 16:36 ` Boris Ostrovsky
2018-04-09 19:18   ` Boris Ostrovsky [this message]
2018-04-10  7:53     ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3baffa60-bcca-cbf3-f056-db30a6c5178c@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paul.durrant@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®