From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Thompson <danielt@kernel.org>,
Roman Vivchar <rva333@protonmail.com>
Cc: Lee Jones <lee@kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Helge Deller <deller@gmx.de>,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds: backlight: add Kinetic KTD3137
Date: Wed, 11 Nov 2026 13:11:13 +0100 [thread overview]
Message-ID: <3bbc1c1a-0435-4cde-a1a2-a408bd7a794a@kernel.org> (raw)
In-Reply-To: <auoVaaZjcnRTj1S9@aspen.lan>
On 03/11/2026 18:10, Daniel Thompson wrote:
> On Tue, Nov 03, 2026 at 03:21:45PM +0000, Roman Vivchar wrote:
>>
>> In the driver I've used devm_regulator_get_enable(), rather than _optional(),
>> since my understanding is that the non-optional helper is a standard kernel
>> API for required supplies (with regulator core warning and fallback to dummy
>> regulator in case DT omits it).
>
> That dummy fallback essentially makes it optional. On a board with an
> always-on supply then there is no need to include vin-supply in the
> DTB. The driver will work just fine without it.
There is a need, because this device needs a supply. How you describe
that supply in DTS is a different story - can be always-on, can be
missing etc.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-11 12:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 19:58 [PATCH 0/2] backlight: add ktd3137 support Roman Vivchar via B4 Relay
2026-11-02 19:58 ` [PATCH 1/2] dt-bindings: leds: backlight: add Kinetic KTD3137 Roman Vivchar via B4 Relay
2026-11-03 14:05 ` Daniel Thompson
2026-11-03 14:34 ` Roman Vivchar
2026-11-03 14:42 ` Daniel Thompson
2026-11-03 15:21 ` Roman Vivchar
2026-11-03 17:10 ` Daniel Thompson
2026-11-11 12:11 ` Krzysztof Kozlowski [this message]
2026-11-11 12:41 ` Daniel Thompson
2026-11-11 13:21 ` Krzysztof Kozlowski
2026-11-11 12:09 ` Krzysztof Kozlowski
2026-11-02 19:58 ` [PATCH 2/2] backlight: add ktd3137 support Roman Vivchar via B4 Relay
2026-11-03 14:15 ` Daniel Thompson
2026-11-03 14:45 ` Roman Vivchar
2026-11-03 14:58 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bbc1c1a-0435-4cde-a1a2-a408bd7a794a@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=rva333@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®