From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>, <nm@ti.com>,
<t-kristo@ti.com>, <ssantosh@kernel.org>, <lokeshvutla@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode
Date: Wed, 30 Sep 2020 16:58:14 +0300 [thread overview]
Message-ID: <3bbe1568-3ceb-07df-4c40-bcc54c8935c0@ti.com> (raw)
In-Reply-To: <20200928083429.17390-11-peter.ujfalusi@ti.com>
On 28/09/2020 11:34, Peter Ujfalusi wrote:
> In RING mode the ringacc does not access the ring memory. In this access
> mode the ringacc coherency does not have meaning.
>
> If the ring is configured in RING mode, then the ringacc itself will not
> access to the ring memory. Only the requester (user) of the ring is going
> to read/write to the memory.
> Extend the ring configuration parameters with a device pointer to be used
> for DMA API when the ring is configured in RING mode.
>
> Extending the ring configuration struct will allow per ring selection of
> device to be used for allocation, thus allowing per ring coherency.
>
> To avoid regression, fall back to use the ringacc dev in case the alloc_dev
> is not provided.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/soc/ti/k3-ringacc.c | 14 +++++++++++---
> include/linux/soc/ti/k3-ringacc.h | 5 +++++
> 2 files changed, 16 insertions(+), 3 deletions(-)
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
grygorii
next prev parent reply other threads:[~2020-09-30 13:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 8:34 [PATCH 00/11] firmware/soc: ti_sci, ringacc/inta: Preparation for AM64 DMA support Peter Ujfalusi
2020-09-28 8:34 ` [PATCH 01/11] firmware: ti_sci: rm: Add support for tx_tdtype parameter for tx channel Peter Ujfalusi
2020-09-28 8:34 ` [PATCH 02/11] firmware: ti_sci: Use struct ti_sci_resource_desc in get_range ops Peter Ujfalusi
2020-09-28 8:34 ` [PATCH 03/11] firmware: ti_sci: rm: Add support for second resource range Peter Ujfalusi
2020-09-28 8:34 ` [PATCH 04/11] soc: ti: ti_sci_inta_msi: Add support for second range in resource ranges Peter Ujfalusi
2020-09-28 8:34 ` [PATCH 05/11] firmware: ti_sci: rm: Add support for extended_ch_type for tx channel Peter Ujfalusi
2020-09-28 8:34 ` [PATCH 06/11] firmware: ti_sci: rm: Remove ring_get_config support Peter Ujfalusi
2020-09-30 11:14 ` Grygorii Strashko
2020-09-28 8:34 ` [PATCH 07/11] firmware: ti_sci: rm: Add new ops for ring configuration Peter Ujfalusi
2020-09-30 13:54 ` Grygorii Strashko
2020-09-28 8:34 ` [PATCH 08/11] soc: ti: k3-ringacc: Use the ti_sci set_cfg callback " Peter Ujfalusi
2020-09-30 13:55 ` Grygorii Strashko
2020-09-28 8:34 ` [PATCH 09/11] firmware: ti_sci: rm: Remove unused config() from ti_sci_rm_ringacc_ops Peter Ujfalusi
2020-09-30 13:55 ` Grygorii Strashko
2020-09-28 8:34 ` [PATCH 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode Peter Ujfalusi
2020-09-30 13:58 ` Grygorii Strashko [this message]
2020-09-28 8:34 ` [PATCH 11/11] soc: ti: k3-socinfo: Add entry for AM64 SoC family Peter Ujfalusi
2020-09-30 13:56 ` Grygorii Strashko
2020-10-01 6:42 ` Peter Ujfalusi
2020-10-01 7:07 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bbe1568-3ceb-07df-4c40-bcc54c8935c0@ti.com \
--to=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®