From: Julien Grall <julien@xen.org>
To: Dongli Zhang <dongli.zhang@oracle.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, joe.jin@oracle.com
Subject: Re: [PATCH v3 2/2] xenbus: req->err should be updated before req->state
Date: Wed, 4 Mar 2020 13:50:51 +0000 [thread overview]
Message-ID: <3bc030fb-340e-434d-60a2-a54bce097680@xen.org> (raw)
In-Reply-To: <20200303221423.21962-2-dongli.zhang@oracle.com>
Hi,
On 03/03/2020 22:14, Dongli Zhang wrote:
> This patch adds the barrier to guarantee that req->err is always updated
> before req->state.
>
> Otherwise, read_reply() would not return ERR_PTR(req->err) but
> req->body, when process_writes()->xb_write() is failed.
>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Cheers,
---
Julien Grall
next prev parent reply other threads:[~2020-03-04 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 22:14 [PATCH v3 1/2] xenbus: req->body " Dongli Zhang
2020-03-03 22:14 ` [PATCH v3 2/2] xenbus: req->err " Dongli Zhang
2020-03-04 13:50 ` Julien Grall [this message]
2020-03-06 11:13 ` Boris Ostrovsky
2020-03-04 13:50 ` [PATCH v3 1/2] xenbus: req->body " Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bc030fb-340e-434d-60a2-a54bce097680@xen.org \
--to=julien@xen.org \
--cc=boris.ostrovsky@oracle.com \
--cc=dongli.zhang@oracle.com \
--cc=jgross@suse.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®