From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vincent Knecht <vincent.knecht@mailoo.org>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawn.guo@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH] clk: qcom: gcc-msm8939: Fix mclk0 & mclk1 for 24 MHz
Date: Sat, 28 Oct 2023 20:06:54 +0100 [thread overview]
Message-ID: <3bc27995-4905-40b8-9b6c-3fc5d77086a2@linaro.org> (raw)
In-Reply-To: <20231028120756.316574-1-vincent.knecht@mailoo.org>
On 28/10/2023 13:07, Vincent Knecht wrote:
> Fix mclk0 & mclk1 parent map to use correct GPLL6 configuration and
> freq_tbl to use GPLL6 instead of GPLL0 so that they tick at 24 MHz.
>
> Fixes: 1664014e4679 ("clk: qcom: gcc-msm8939: Add MSM8939 Generic Clock Controller")
> Suggested-by: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
> drivers/clk/qcom/gcc-msm8939.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index b45f97c07eeb..e4a44377b75f 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -432,7 +432,7 @@ static const struct parent_map gcc_xo_gpll0_gpll1a_gpll6_sleep_map[] = {
> { P_XO, 0 },
> { P_GPLL0, 1 },
> { P_GPLL1_AUX, 2 },
> - { P_GPLL6, 2 },
> + { P_GPLL6, 3 },
> { P_SLEEP_CLK, 6 },
> };
>
> @@ -1100,7 +1100,7 @@ static struct clk_rcg2 jpeg0_clk_src = {
> };
>
> static const struct freq_tbl ftbl_gcc_camss_mclk0_1_clk[] = {
> - F(24000000, P_GPLL0, 1, 1, 45),
> + F(24000000, P_GPLL6, 1, 1, 45),
> F(66670000, P_GPLL0, 12, 0, 0),
> { }
> };
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
prev parent reply other threads:[~2023-10-28 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231028120756.316574-1-vincent.knecht@mailoo.org>
2023-10-28 13:06 ` Konrad Dybcio
2023-10-29 6:48 ` Vincent Knecht
2023-10-28 19:06 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bc27995-4905-40b8-9b6c-3fc5d77086a2@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stephan@gerhold.net \
--cc=vincent.knecht@mailoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®