From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <mwalle@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, nm@ti.com, vigneshr@ti.com
Subject: Re: [PATCH] phy: ti: gmii-sel: Force RGMII TX delay
Date: Mon, 4 Aug 2025 17:19:19 +0200 [thread overview]
Message-ID: <3bc6476e-7539-40aa-b499-253273357a1d@lunn.ch> (raw)
In-Reply-To: <20250804140652.539589-1-mwalle@kernel.org>
On Mon, Aug 04, 2025 at 04:06:52PM +0200, Michael Walle wrote:
> Some SoCs are just validated with the TX delay enabled. With commit
> ca13b249f291 ("net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed
> RGMII TX delay"), the network driver will patch the delay setting on the
> fly assuming that the TX delay is fixed. In reality, the TX delay is
> configurable and just skipped in the documentation. There are
> bootloaders, which will disable the TX delay and this will lead to a
> transmit path which doesn't add any delays at all. Fix that by always
> forcing the TX delay to be enabled.
Please could you add a paragraph:
This is safe to do, and will not break any existing boards
supported in mainline because...
We have to be careful of regressions, and such a paragraph makes it
clear you have thought it through, and what your assumptions are. If
something does break, listing your assumptions will help finding what
went wrong.
Andrew
prev parent reply other threads:[~2025-08-04 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 14:06 Michael Walle
2025-08-04 14:59 ` Matthias Schiffer
2025-08-04 15:19 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bc6476e-7539-40aa-b499-253273357a1d@lunn.ch \
--to=andrew@lunn.ch \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=mwalle@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®