From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Richard Weinberger <richard@nod.at>, Dmitry Vyukov <dvyukov@google.com>
Cc: Jeff Dike <jdike@addtoit.com>,
user-mode-linux-devel
<user-mode-linux-devel@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>,
Stefan Traby <stefan@hello-penguin.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] UML: don't discard .text.exit section
Date: Fri, 19 Aug 2016 16:06:56 +0300 [thread overview]
Message-ID: <3bc79e3a-9604-3d61-fc68-443d8d8a70b6@virtuozzo.com> (raw)
In-Reply-To: <e9536af2-7e69-8a53-96d0-7a7a92dbea31@nod.at>
On 08/19/2016 02:16 PM, Richard Weinberger wrote:
> On 19.08.2016 12:48, Andrey Ryabinin wrote:
>> On 08/19/2016 03:14 AM, Dmitry Vyukov wrote:
>>> On Thu, Aug 18, 2016 at 3:08 AM, Andrey Ryabinin
>>> <aryabinin@virtuozzo.com> wrote:
>>>>
>>>>>
>>>>> Sorry for delays, I am travelling.
>>>>> Do we need ".fini_array" section? It's also destructors that we don't
>>>>> run. Or does UML use them? Does discarding ".fini_array" help?
>>>>>
>>>>
>>>> libc has desctructors and use them for whatever purpose it needs.
>>>
>>>
>>> Does UML actually gracefully exit running global destructors? That
>>> would also require gracefully shutting down all threads/cpus. Doesn't
>>> it just _exit (or syscall(SYS_exit_group))?
>>>
>>
>> Sigh, I dunno, I didn't look that far. My intention was to fix build and keep old behavior unaffected.
>> If you want to wipe destructors, and think that this is ok, go ahead.
>
> UML exits like any regular C program does.
> The main() function is in arch/um/os-Linux/main.c, when the kernel terminates,
> hence linux_main() returns back to main() it just returns the exit code.
> At this point libc's destructors will run, right?
>
Sounds right to me.
> Thanks,
> //richard
>
next prev parent reply other threads:[~2016-08-19 17:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFLxGvzB=WGNEdNJVvPpQLpwCqT6oNcvEQnyT2xk0Jv2L3FBaA@mail.gmail.com>
2016-08-17 15:10 ` Andrey Ryabinin
2016-08-17 17:11 ` Dmitry Vyukov
2016-08-18 10:08 ` Andrey Ryabinin
2016-08-19 0:14 ` Dmitry Vyukov
2016-08-19 10:48 ` Andrey Ryabinin
2016-08-19 11:16 ` Richard Weinberger
2016-08-19 13:06 ` Andrey Ryabinin [this message]
2016-08-19 15:24 ` Dmitry Vyukov
2016-08-22 20:10 ` Richard Weinberger
2016-08-23 9:59 ` Andrey Ryabinin
2016-08-23 21:40 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bc79e3a-9604-3d61-fc68-443d8d8a70b6@virtuozzo.com \
--to=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=stefan@hello-penguin.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®