From: Sekhar Nori <nsekhar@ti.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Kevin Hilman <khilman@kernel.org>,
Patrick Titiano <ptitiano@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Tejun Heo <tj@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
David Lechner <david@lechnology.com>
Cc: <linux-ide@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 11/14] sata: ahci-da850: un-hardcode the MPY bits
Date: Tue, 31 Jan 2017 20:43:11 +0530 [thread overview]
Message-ID: <3bcc927a-f074-7f18-cdeb-e40655c39118@ti.com> (raw)
In-Reply-To: <1485770531-6772-12-git-send-email-bgolaszewski@baylibre.com>
On Monday 30 January 2017 03:32 PM, Bartosz Golaszewski wrote:
> + /*
> + * The second clock used by ahci-da850 is the external REFCLK. If we
> + * didn't get it from ahci_platform_get_resources(), let's try to
> + * specify the con_id in clk_get().
> + */
> + if (!hpriv->clks[1]) {
> + clk = clk_get(dev, "refclk");
> + if (IS_ERR(clk)) {
> + dev_err(dev, "unable to obtain the reference clock");
> + return -ENODEV;
> + } else {
> + hpriv->clks[1] = clk;
> + }
This results in a checkpatch warning about the unneeded else. I fixed
this locally to look like:
+ */
+ if (!hpriv->clks[1]) {
+ clk = clk_get(dev, "refclk");
+ if (IS_ERR(clk)) {
+ dev_err(dev, "unable to obtain the reference clock");
+ return -ENODEV;
+ }
+
+ hpriv->clks[1] = clk;
+ }
Thanks,
Sekhar
next prev parent reply other threads:[~2017-01-31 15:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 10:01 [PATCH v7 00/14] ARM: da850-lcdk: add SATA support Bartosz Golaszewski
2017-01-30 10:01 ` [PATCH v7 01/14] devicetree: bindings: add bindings for ahci-da850 Bartosz Golaszewski
2017-01-30 10:01 ` [PATCH v7 02/14] ARM: davinci_all_defconfig: enable SATA modules Bartosz Golaszewski
2017-01-30 10:02 ` [PATCH v7 03/14] ARM: davinci: add a clock lookup entry for the SATA clock Bartosz Golaszewski
2017-01-31 15:09 ` Sekhar Nori
2017-01-30 10:02 ` [PATCH v7 04/14] sata: ahci-da850: get the sata clock using a connection id Bartosz Golaszewski
2017-01-30 10:02 ` [PATCH v7 05/14] ARM: davinci: da850: add con_id for the SATA clock Bartosz Golaszewski
2017-01-30 10:02 ` [PATCH v7 06/14] ARM: davinci: da850: model the SATA refclk Bartosz Golaszewski
2017-01-30 10:02 ` [PATCH v7 07/14] sata: ahci-da850: add device tree match table Bartosz Golaszewski
2017-01-30 10:02 ` [PATCH v7 08/14] sata: ahci-da850: implement a workaround for the softreset quirk Bartosz Golaszewski
2017-01-30 10:02 ` [PATCH v7 09/14] sata: ahci: export ahci_do_hardreset() locally Bartosz Golaszewski
2017-01-30 10:02 ` [PATCH v7 10/14] sata: ahci-da850: add a workaround for controller instability Bartosz Golaszewski
2017-01-30 10:02 ` [PATCH v7 11/14] sata: ahci-da850: un-hardcode the MPY bits Bartosz Golaszewski
2017-01-31 15:13 ` Sekhar Nori [this message]
2017-01-30 10:02 ` [PATCH v7 12/14] ARM: davinci: remove BUG_ON() from da850_register_sata() Bartosz Golaszewski
2017-01-30 10:02 ` [PATCH v7 13/14] ARM: dts: da850: add the SATA node Bartosz Golaszewski
2017-01-30 10:02 ` [PATCH v7 14/14] ARM: dts: da850-lcdk: enable " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bcc927a-f074-7f18-cdeb-e40655c39118@ti.com \
--to=nsekhar@ti.com \
--cc=bgolaszewski@baylibre.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=ptitiano@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®