From: Chao Yu <chao@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Cc: Chao Yu <chao@kernel.org>,
Max Kellermann <max.kellermann@ionos.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] erofs: fix PSI memstall accounting
Date: Thu, 12 Dec 2024 22:19:27 +0800 [thread overview]
Message-ID: <3bd0e32f-030c-493b-922b-5c4c4c164cf1@kernel.org> (raw)
In-Reply-To: <20241127085236.3538334-1-hsiangkao@linux.alibaba.com>
On 2024/11/27 16:52, Gao Xiang wrote:
> Max Kellermann recently reported psi_group_cpu.tasks[NR_MEMSTALL] is
> incorrect in 6.11.9 kernel.
>
> I think the root cause of the recent issue is that since the problematic
> commit, bio can be NULL so psi_memstall_leave() could be missed in
> z_erofs_submit_queue().
>
> Reported-by: Max Kellermann <max.kellermann@ionos.com>
> Closes: https://lore.kernel.org/r/CAKPOu+8tvSowiJADW2RuKyofL_CSkm_SuyZA7ME5vMLWmL6pqw@mail.gmail.com
> Fixes: 9e2f9d34dd12 ("erofs: handle overlapped pclusters out of crafted images properly")
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
prev parent reply other threads:[~2024-12-12 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 8:52 Gao Xiang
2024-12-02 21:52 ` Sandeep Dhavale
2024-12-03 1:42 ` Gao Xiang
2024-12-03 8:02 ` Max Kellermann
2024-12-03 8:15 ` Gao Xiang
2024-12-03 8:20 ` Max Kellermann
2024-12-03 13:30 ` Max Kellermann
2024-12-03 14:00 ` Max Kellermann
2024-12-04 2:12 ` Gao Xiang
2024-12-12 14:19 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bd0e32f-030c-493b-922b-5c4c4c164cf1@kernel.org \
--to=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®