From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752336AbcF1EgH (ORCPT ); Tue, 28 Jun 2016 00:36:07 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:13141 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbcF1EgD convert rfc822-to-8bit (ORCPT ); Tue, 28 Jun 2016 00:36:03 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 27 Jun 2016 21:35:01 -0700 From: Venkat Reddy Talla To: Mark Brown CC: "lgirdwood@gmail.com" , "linux-kernel@vger.kernel.org" , "Laxman Dewangan" Subject: RE: [PATCH 1/1] regulator: max77620: check for valid regulator info Thread-Topic: [PATCH 1/1] regulator: max77620: check for valid regulator info Thread-Index: AQHR0GkvrKLHi1KGEkutRTS1aP3zbJ/9fQeAgADGz4A= Date: Tue, 28 Jun 2016 04:35:56 +0000 Message-ID: <3bdeadd747c8475b991183fe9f094e62@bgmail102.nvidia.com> References: <1467027824-29739-1-git-send-email-vreddytalla@nvidia.com> <20160627161405.GA17217@sirena.org.uk> In-Reply-To: <20160627161405.GA17217@sirena.org.uk> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.24.193.35] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > * PGP Signed by an unknown key > > On Mon, Jun 27, 2016 at 05:13:44PM +0530, Venkat Reddy Talla wrote: > > Check for valid regulator information data before configuring FPS > > source and FPS power up/down period to avoid NULL pointer exception if > > entries for PMIC regulators not provided through device tree. > > This sounds like it's papering over a bug in the driver - the driver should be > able to instantiate without anything beyond the registration of the device. > What's the driver relying on from the DT? > Sorry for confusion, there is no dependent on DTS entry, I mean, in probe SD4 regulator for MAX77620 PMIC is not registered with regulator core framework so Regulator info will be null. > > SD4 regulator is not supported by MAX77620 PMIC, removing > > SD4 entry from regulator information list. > > This appears to be a separate change to the above and should be a separate > patch. > Regulator info data will be null since SD4 regulator is not getting registered with core framework, MAX77620 not supporting SD4 regulator, due to this reason I have included this change as part of this patch. I will change the commit message and push another patch on top of this patch. Thanks for review. > * Unknown Key > * 0x5D5487D0