From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17F6922B8AA for ; Thu, 16 Jan 2025 14:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737039237; cv=none; b=u758bsKq2f8FVqwOHaOV7iyBtYRg0Y3vPONQEfKWQGnKj4NkLdtmZlKjA63Dj4Ir5ywzINqaDiDa9kfgzNnyzdfyRQKdUyGGAeIjNfGPQpOPSOxLvmOMcu7Bfz5V7iVYdQKq4x/adAgmj4di7lWfNCRlRACSAWRgmbKbko0n3v8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737039237; c=relaxed/simple; bh=OOpRYGsxWnJcyUejSr4gU7VZl2Fk56EYC1P1Ak348bI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=rFjYAktHfkXwliH9IIi5CKWWJQYjUPif+OaCWxDPIewKSh2o3TqsfUC9xB/uTWBNJoasv29Y+9XhFwaEmWtg5ulqrAZz5B9h89LMI/Sfblxem62aZ867vyEkMP3QjUBcZCFSPnbaXxq6kJpjAOfLhnWHQiJ5WQwxu2uVrAnLwYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CDbo9qCE; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CDbo9qCE" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-388cae9eb9fso581020f8f.3 for ; Thu, 16 Jan 2025 06:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737039233; x=1737644033; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=+40RmltfMANyPY+1QTgar9RnRnjYDGniubr9OVcwfG4=; b=CDbo9qCEJ7f5Ld5KW9dDTNH7Y56N/rIxr90GbHvWnPXKXduaLLwYcbcrYgCvRKrTys TPlRXEOOC/b0OyM3OSsmDjcN9ywWTZkPtZ4En5lIR5Castp98wl4c/M4LXjR3i0qj26h 37kEJcZ2i8OtLFqvkXVcYfXjJp1k11tjAQmP+Veiopmvsls97i+L3kzWzgant1t7Rnzi i33DxX3zC3WZQuQFYUW3q7EuAKBLqzHTeT9lMOFr8VcvpaLbNdI0CZ8atAKfCvgB9kKv s4sIG8wvnSP4dg6317+PU38chlWD4tW8B06QmVijADvZwvf/xx2VSBrjz16hmew5VY4j OxNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737039233; x=1737644033; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+40RmltfMANyPY+1QTgar9RnRnjYDGniubr9OVcwfG4=; b=sdldzrrwtPG2r+SSERx6jLrT3RwcKqkDRJMfnKq8/aJ4aHAGUY8gbswoItEbv9eVbg nPVX7G3SKAQvSVY4RRv0+4BrLNTPndZATSw6u6VSC+CVHpZ2fewNnx2/iypcDtLOfDHy 52pfkZ1ECKwvJyTcVXm5i3yS7T08punOGgyyKBtyfFJ5X1YnxBdEo8tExSzulxAdroHr 8t7s9Sk6ahkICZ+OC77R4c0CCwooXSIGHfq45q2sLkSWSd4GlZM5qaZkHA5pr3Rrn6Ds EbPt+Sk/JKTVedpt2JfG2pImO+38APWVBqJ7bOr8KZDEhz86vUdWNoZhxDMvfzwyKjgi /WIg== X-Forwarded-Encrypted: i=1; AJvYcCVUAwE2+7wZ+oNhYxxJlqmtUsjr9gjmVsUXxC8ktXbOVEdzJV7nkcKfR/k+Oi9d5D5sRRX8KksItC4Bivs=@vger.kernel.org X-Gm-Message-State: AOJu0YxRFWXsZm5Tql0TQNY7D09C4vlzJzq4WVeKkKSSKPG0iX/52aka 3GQ13F8Yu5alz2MH9QhX6YiFF4MI8faq5KjvPFSbv9/cDp/acGtftc7pn6hnoPo= X-Gm-Gg: ASbGncul3HCq0nk+r4AEmDfYM6kDu8G1Q3xO/O0Mg99BMtsmCxKZ8ImNfYdnezOk/1k es+TE8UB3ZdSjGgDh8ecUc5jPpWK+oxwa1PokYmrbWeKEbySVSmBPfFNLE6enp7VYUDCbtMvPzJ m4Ls4yWfcuxKNN3sYf+WQjkIijH519NwPBdKY3jq1at+u+NcZD3glipHiHu8HyYasDxyeE6xgDf B0riN3oh5a9KJQ9Tzuv8pHFw0Y1GpwRWEKjF8XcN3GyqWedGraZs4CzOvk= X-Google-Smtp-Source: AGHT+IE3zET7LUBf5Xl5nUv66mL3sWpnOxRP3nAF8WgDEzvt7rB31XYs3LBWYqwaS9CKz65z3GQHAw== X-Received: by 2002:a05:6000:4612:b0:38a:39ad:3e2f with SMTP id ffacd0b85a97d-38a872cb1e1mr29373964f8f.2.1737039233420; Thu, 16 Jan 2025 06:53:53 -0800 (PST) Received: from salami.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3221b5asm74199f8f.21.2025.01.16.06.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 06:53:53 -0800 (PST) Message-ID: <3be2a6e263f127bbc3331b6aeb533fc0ba636772.camel@linaro.org> Subject: Re: [PATCH v3 0/4] Google Pixel 6 (simple) framebuffer support From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: "Rob Herring (Arm)" Cc: Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin , Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org, Alim Akhtar Date: Thu, 16 Jan 2025 14:53:46 +0000 In-Reply-To: <173703609099.1976411.4033971019635742956.robh@kernel.org> References: <20250115-gs101-simplefb-v3-0-52eca3a582b7@linaro.org> <173703609099.1976411.4033971019635742956.robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3-1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2025-01-16 at 08:02 -0600, Rob Herring (Arm) wrote: >=20 > On Wed, 15 Jan 2025 16:11:08 +0000, Andr=C3=A9 Draszik wrote: > > Hi, > >=20 > > This series enables simple framebuffer support on Google Pixel 6 and > > Pixel 6 Pro. > >=20 > > Even if simple-framebuffer is deprecated and DRM should be used > > instead, having it available in DT is beneficial for several reasons at > > this point in time (the phone uses an OLED display): > > * energy consumption goes down significantly, as it changes from white > > =C2=A0 (as left by bootloader) to black (linux console), and we general= ly > > =C2=A0 don't run out of battery anymore when plugged into a USB port > > * less of a burn-in effect I assume > > * phone stays cooler due to reduced energy consumption by display > >=20 > > Since Pixel 6 and Pixel 6 Pro use a different resolution display, this > > is the time to separate them into their respective DTs, and provide one > > for each of them. There are other differences between the two, like > > battery design capacity, but they don't matter at this stage due to > > incomplete upstream support. > >=20 > > * dependency note * > >=20 > > None (anymore) - earlier versions of this series had dependencies, but > > those are all part of linux-next already, so none remain. > >=20 > > * dependency note end * > >=20 > > For those who want to try this out: > > The stock bootloader disables the decon hardware trigger before jumping > > to Linux, preventing framebuffer updates from reaching the display. We > > have added a work-around in our Yocto BSP layer for the time being > > (until a proper display exists upstream). An alternative might be to > > port and use uniLoader from https://github.com/ivoszbg/uniLoader, as > > seems to be done for some other Exynos platforms. > >=20 > > Signed-off-by: Andr=C3=A9 Draszik > > --- > > Changes in v3: > > - back to using separate DTBs for Pixel 6 and Pixel 6 Pro (Krzysztof) > > - update name of common dtsi file (Krzysztof) > > - use 'memory-region' property from the start in patch 2, don't > > =C2=A0 introduce it as change in patch 3 (Krzysztof) > > - Link to v2: https://lore.kernel.org/r/20241220-gs101-simplefb-v2-0-c1= 0a8f9e490b@linaro.org > > =C2=A0 and https://lore.kernel.org/r/20241220-gs101-simplefb-oriole-v2-= 1-df60e566932a@linaro.org > >=20 > > Changes in v2: > > - We now have a generic gs101-based Pixel board DT, which can work on > > =C2=A0 any Pixel 6 / 6 Pro / 6a > > - Pixel 6 (Pro) are overlays onto that one. > > =C2=A0 This has the advantage that all boards can be supported without > > =C2=A0 having to have a full copy of the DT for each of them. We still > > =C2=A0 instruct kbuild to create merged DTBs (in addition to the DTBOs)= so > > =C2=A0 that existing scripts can keep working while giving the option t= o > > =C2=A0 just apply the overlay before boot (e.g. by the bootloader). > > - The binding has been updated according to the above points > > - I've changed the simple-framebuffer node to specify the memory via > > =C2=A0 memory-region instead of reg, as that avoids unnecessary duplica= tion > > =C2=A0 (of the size), and it avoids having to specify #address-cells > > =C2=A0 and #size-cells in the chosen node (and duplicating this in the > > =C2=A0 DTSO), which is otherwise necessary to keep dt_binding_check hap= py > > =C2=A0 and DT validation working in general. > > - sort overriding/extending nodes ordered by label name (Krzysztof) > > - format patches with diff.renames=3Dcopies (Krzysztof) > > - dependencies have been updated, see below > > - Link to v1: https://lore.kernel.org/r/20241216-gs101-simplefb-v1-0-8c= cad1830281@linaro.org > >=20 > > --- > > Andr=C3=A9 Draszik (4): > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dt-bindings: arm: google: add gs101-rave= n > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 arm64: dts: exynos: gs101-oriole: config= ure simple-framebuffer > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 arm64: dts: exynos: gs101-oriole: move c= ommon Pixel6 & 6Pro parts into a .dtsi > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 arm64: dts: exynos: gs101-raven: add new= board file > >=20 > > =C2=A0Documentation/devicetree/bindings/arm/google.yaml=C2=A0 |=C2=A0= =C2=A0 3 +- > > =C2=A0arch/arm64/boot/dts/exynos/google/Makefile=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 + > > =C2=A0arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 267 +-------= ------------- > > =C2=A0.../{gs101-oriole.dts =3D> gs101-pixel-common.dtsi}=C2=A0 |=C2=A0= 22 +- > > =C2=A0arch/arm64/boot/dts/exynos/google/gs101-raven.dts=C2=A0 |=C2=A0 2= 9 +++ > > =C2=A05 files changed, 58 insertions(+), 264 deletions(-) > > --- > > base-commit: 4e16367cfe0ce395f29d0482b78970cce8e1db73 > > change-id: 20241216-gs101-simplefb-8aae80278ed7 > >=20 > > Best regards, > > -- > > Andr=C3=A9 Draszik > >=20 > >=20 >=20 >=20 > My bot found new DTB warnings on the .dts files added or changed in this > series. >=20 > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. >=20 > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: >=20 > =C2=A0 pip3 install dtschema --upgrade >=20 >=20 > New warnings running 'make CHECK_DTBS=3Dy for arch/arm64/boot/dts/exynos/= ' for 20250115-gs101-simplefb-v3-0-52eca3a582b7@linaro.org: >=20 > arch/arm64/boot/dts/exynos/google/gs101-raven.dtb: phy@11100000: 'orienta= tion-switch' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/phy/samsung,usb3-drd-phy.= yaml# These are emitted because https://lore.kernel.org/all/20241206-gs101-phy-lanes-orientation-phy-v4-0-f= 5961268b149@linaro.org/ hasn't been merged yet. Cheers, Andre'