From: Bart Van Assche <bvanassche@acm.org>
To: Stanley Jhu <stanleyjhu@google.com>,
"Martin K . Petersen" <mkp@kernel.org>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Bean Huo <beanhuo@micron.com>
Cc: Peter Wang <peter.wang@mediatek.com>,
Can Guo <can.guo@oss.qualcomm.com>,
John Garry <john.garry@linux.dev>,
"Bao D . Nguyen" <quic_nguyenb@quicinc.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: core: Skip completion of SCSI commands owned by the SCSI EH
Date: Thu, 29 Oct 2026 08:36:56 -0700 [thread overview]
Message-ID: <3be5c9ac-44f3-46c0-bb81-6bde6edcba28@acm.org> (raw)
In-Reply-To: <20261029040004.2100004-1-stanleyjhu@google.com>
On 10/29/26 12:09 AM, Stanley Jhu wrote:
> +static inline bool ufshcd_cmd_owned_by_scsi_eh(struct scsi_cmnd *cmd)
> +{
> + return cmd->submitter == SUBMITTED_BY_BLOCK_LAYER &&
> + test_bit(SCMD_STATE_COMPLETE, &cmd->state);
> +}
This is a layering violation. The UFS driver has no business checking
these fields. cmd->submitter checks and cmd->state checks should happen
by the SCSI core and not by any SCSI LLD.
> @@ -6009,6 +6025,10 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
> lrbp->compl_time_stamp_local_clock = local_clock();
> }
> if (ufshcd_is_scsi_cmd(cmd)) {
> + if (unlikely(ufshcd_cmd_owned_by_scsi_eh(cmd))) {
> + ufshcd_release_scsi_cmd(hba, cmd);
> + return;
> + }
> if (unlikely(ufshcd_should_inform_monitor(hba, cmd)))
> ufshcd_update_monitor(hba, cmd);
> ufshcd_add_command_trace(hba, cmd, UFS_CMD_COMP);
The problem described in the patch description applies to all SCSI LLDs
and hence should be solved in a generic way instead of in the UFS driver
only.
Bart.
prev parent reply other threads:[~2026-10-29 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 7:09 Stanley Jhu
2026-10-29 15:36 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3be5c9ac-44f3-46c0-bb81-6bde6edcba28@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=beanhuo@micron.com \
--cc=can.guo@oss.qualcomm.com \
--cc=john.garry@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=peter.wang@mediatek.com \
--cc=quic_nguyenb@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=stanleyjhu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®