From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
Lance Yang <lance.yang@linux.dev>,
Pedro Falcato <pfalcato@suse.de>
Cc: akpm@linux-foundation.org, ziy@nvidia.com, liam@infradead.org,
nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, usama.arif@linux.dev, kas@kernel.org,
jack@suse.cz, djwong@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, hch@lst.de,
syzbot+16bf7cd0ebeb1de93aa5@syzkaller.appspotmail.com,
ngocthang2710.1999@gmail.com, willy@infradead.org,
rppt@kernel.org, ljs@kernel.org
Subject: Re: [PATCH v3 1/1] khugepaged: fix readahead lock inversion in collapse_file()
Date: Mon, 26 Oct 2026 12:26:39 +0100 [thread overview]
Message-ID: <3be96a1c-7cfb-4cd0-a4fb-16209494d041@kernel.org> (raw)
In-Reply-To: <b1b3d8d7-7201-4b75-a0f0-af383d854279@linux.alibaba.com>
On 10/18/26 04:47, Baolin Wang wrote:
>
>
> On 10/17/26 3:41 PM, Lance Yang wrote:
>>
>>
>> On 2026/10/17 13:43, Baolin Wang wrote:
>>>
>>>
>>>
>>> OK.
>>>
>>>
>>> Sounds good.
>>>
>>>
>>> But why not add RA logic in collapse_pmd(), as we do for
>>> SCAN_PAGE_DIRTY_OR_WRITEBACK? There's already retry logic there, and this
>>> would also simplify the long collapse_file().
>>
>> That would be cleaner, yeah. Some older stable trees don't have that
>> outer retry loop, though ... I'd prefer to get the fix backported first,
>> then move the RA/retry logic out in a follow-up, wdyt?
>
> IIRC, the approach to bug fixes is to fix bugs properly and cleanly for
> upstream, without being constrained by backporting requirements.
>
> Anyway, I don't have a strong opinion on this. Let's also see what David prefers.
Let's get this fixed in a acceptable way in a reasonable timeframe; it's been
broken for too long. ... and follow up with bigger cleanups later.
@Lance is this version good to review for that purpose or are you planning a resend?
--
Cheers,
David
next prev parent reply other threads:[~2026-10-26 12:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 6:59 Lance Yang
2026-10-16 9:57 ` Baolin Wang
2026-10-16 11:00 ` Pedro Falcato
2026-10-16 13:18 ` Pedro Falcato
2026-10-17 4:50 ` Lance Yang
2026-10-17 5:43 ` Baolin Wang
2026-10-17 7:41 ` Lance Yang
2026-10-18 2:47 ` Baolin Wang
2026-10-26 11:26 ` David Hildenbrand (Arm) [this message]
2026-10-26 12:35 ` Lance Yang
2026-10-16 15:43 ` Lance Yang
2026-10-17 5:26 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3be96a1c-7cfb-4cd0-a4fb-16209494d041@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kas@kernel.org \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=ngocthang2710.1999@gmail.com \
--cc=nico.pache@linux.dev \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=syzbot+16bf7cd0ebeb1de93aa5@syzkaller.appspotmail.com \
--cc=usama.arif@linux.dev \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®