From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Alexey Brodkin" <Alexey.Brodkin@synopsys.com>,
Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] ARC: HSDK: DTS: Temporary fix of sdio ciu frequency
Date: Fri, 8 Sep 2017 11:56:37 -0700 [thread overview]
Message-ID: <3bed30b7-6efe-e3d4-a65a-b6816e87c45e@synopsys.com> (raw)
In-Reply-To: <20170908184233.1779-1-Eugeniy.Paltsev@synopsys.com>
On 09/08/2017 11:42 AM, Eugeniy Paltsev wrote:
> DW sdio controller has external ciu clock devider controlled via
> register in SDIO IP. Due to its unexpected default value
> (it should devide by 1 but it devides by 8)
> SDIO IP uses wrong ciu clock and works unstable (see STAR 9001204800)
>
> So add temporary fix and change clock frequency from 100000000
> to 12500000 Hz until we fix dw sdio driver itself.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Added.
Consider it bike shedding, but for next time, please bracket the platform patches as
ARC: [plat-xxx] abra ka dabra ....
-Vineet
> ---
> arch/arc/boot/dts/hsdk.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> index 8412669..b922f3f 100644
> --- a/arch/arc/boot/dts/hsdk.dts
> +++ b/arch/arc/boot/dts/hsdk.dts
> @@ -127,7 +127,17 @@
>
> mmcclk_ciu: mmcclk-ciu {
> compatible = "fixed-clock";
> - clock-frequency = <100000000>;
> + /*
> + * DW sdio controller has external ciu clock divider
> + * controlled via register in SDIO IP. Due to its
> + * unexpected default value (it should devide by 1
> + * but it devides by 8) SDIO IP uses wrong clock and
> + * works unstable (see STAR 9001204800)
> + * So add temporary fix and change clock frequency
> + * from 100000000 to 12500000 Hz until we fix dw sdio
> + * driver itself.
> + */
> + clock-frequency = <12500000>;
> #clock-cells = <0>;
> };
>
prev parent reply other threads:[~2017-09-08 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 18:42 Eugeniy Paltsev
2017-09-08 18:56 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bed30b7-6efe-e3d4-a65a-b6816e87c45e@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®