From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757544AbYIPTaj (ORCPT ); Tue, 16 Sep 2008 15:30:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756388AbYIPTaW (ORCPT ); Tue, 16 Sep 2008 15:30:22 -0400 Received: from nf-out-0910.google.com ([64.233.182.189]:48238 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757261AbYIPTaV (ORCPT ); Tue, 16 Sep 2008 15:30:21 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=JYuBWqahE2+e9Pv+qO1X2gwoMsomXjD/0CTbyJjX3ItVMu65RG2ccnUSILWfiIkkWs h5w6mmaq8ExJUgDxjHTFkltnr5TEYNRjq9785ds24MApVTUetz85GyROIExSLipWwSpl sd+8F/buPJkC17ER6MsX1k7L6yKPZ+aWOKPI8= Message-ID: <3bedf6ab0809161230u1cc346f5xb05957309426505f@mail.gmail.com> Date: Wed, 17 Sep 2008 01:00:19 +0530 From: "karthikeyan S" To: "Willy Tarreau" Subject: Re: A bug (probably) in stop_all_threads Cc: "Grant Coady" , linux-kernel@vger.kernel.org In-Reply-To: <20080916092830.GB30026@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <3bedf6ab0809130127j7ed9d372pcb15e1b001178600@mail.gmail.com> <20080916051751.GA28475@1wt.eu> <3bedf6ab0809152249r524cce0v1c14bfdff46aa12d@mail.gmail.com> <20080916062226.GA29225@1wt.eu> <3bedf6ab0809160128l101d44feh671dbeb4a8401360@mail.gmail.com> <20080916092830.GB30026@1wt.eu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 16, 2008 at 2:58 PM, Willy Tarreau wrote: > On Tue, Sep 16, 2008 at 01:58:21PM +0530, karthikeyan S wrote: >> On Tue, Sep 16, 2008 at 11:52 AM, Willy Tarreau wrote: >> > On Tue, Sep 16, 2008 at 11:19:58AM +0530, karthikeyan S wrote: >> >> Hi Willy, >> >> >> >> Thanks for getting back. Yes, I tried to set the state to >> >> TASK_INTERRUPTIBLE. It solves the issue. The other processes now get a >> >> chance to handle the SIGSTOP sent to them. >> > >> > OK, that will help me review the current code and compare it with 2.6. >> > If you could send me your patch, it will even save me more time. Based >> > on your report, it's very likely that it will get merged. >> >> Sure, I can definitely send the patch. I haven't sent a patch before, >> and I am not fully aware of the process to follow. It might take a >> little bit if time, but I will try to send it very soon. > > in order not to waste your time, here is how to proceed : > > go to the directory where both your new kernel and old kernel are. > Here is how you do then : > > $ diff -urN linux-2.4.36-bad linux-2.4.36-goot > my-patch.diff > > (ensure that you don't have lots of old or temporary files in it). > You might have to run a "make distclean" in each dir first. > > Then integrate the result as inline text into your mail, and as an added > bonus, other people will be able to comment on your work. Willy, Thank you for the info. I downloaded a 2.4.36 version from kernel.org, there is no stop_all_threads() at all in that version. do_coredump() mechanism seems to have been changed. It does not call stop_all_threads(). I am not sure which 2.4 version we are using for our device that have stop_all_threads(). And also I am not sure from where our guys had picked up the "dump core for all threads" patch which includes the stop_all_threads function. Had this function been there ever in official 2.4? Thanks a lot. So, looks like the need to send the patch is not there anymore? :-( -karthik > > Regards, > Willy > >