From: Sagi Grimberg <sagi@grimberg.me>
To: Al Viro <viro@ZenIV.linux.org.uk>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [rfc] weirdness in bio_map_user_iov()
Date: Fri, 23 Sep 2016 14:47:55 -0700 [thread overview]
Message-ID: <3bef44d1-1968-804e-87d9-458b32d83a7e@grimberg.me> (raw)
In-Reply-To: <20160921215226.GU2356@ZenIV.linux.org.uk>
Hey Al,
> What happens if we feed it a 3-element iovec array, one page in each?
> AFAICS, bio_add_pc_page() is called for each of those pages, even if
> the previous calls have failed - break is only out of the inner loop.
>
> Sure, failure due to exceeded request size means that everything after
> that one will fail, but what of e.g.
> /*
> * If the queue doesn't support SG gaps and adding this
> * offset would create a gap, disallow it.
> */
> if (bvec_gap_to_prev(q, prev, offset))
> return 0;
> in there? Won't we risk having the first and the third pages added, with
> the second one quietly skipped? Jens, looks like it had come from you
> (by way of jejb). Am I missing something subtle here?
So AFAICT, 'gappy' iovecs will never reach bio_map_user_iov() because it
is checked before in blk_rq_map_user_iov():
if (map_data)
copy = true;
else if (iov_iter_alignment(iter) & align)
copy = true;
else if (queue_virt_boundary(q))
copy = queue_virt_boundary(q) &
iov_iter_gap_alignment(iter);
if iov_iter_gap_alignment(iter) detects gaps it will use
a nice aligned bounce via bio_copy_user_iov().
prev parent reply other threads:[~2016-09-23 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 21:52 Al Viro
2016-09-23 21:47 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bef44d1-1968-804e-87d9-458b32d83a7e@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®