From: Sean Anderson <sean.anderson@seco.com>
To: Rob Herring <robh@kernel.org>
Cc: Li Yang <leoyang.li@nxp.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] soc: fsl: qbman: Remove RESERVEDMEM_OF_DECLARE usage
Date: Tue, 5 Mar 2024 13:07:07 -0500 [thread overview]
Message-ID: <3beff31a-78a4-471f-a0cd-22379414a298@seco.com> (raw)
In-Reply-To: <170966167830.3808046.18290518120456288771.robh@kernel.org>
On 3/5/24 13:02, Rob Herring wrote:
>
> On Thu, 01 Feb 2024 13:29:30 -0600, Rob Herring wrote:
>> There is no reason to use RESERVEDMEM_OF_DECLARE() as the initialization
>> hook just saves off the base address and size. Use of
>> RESERVEDMEM_OF_DECLARE() is reserved for non-driver code and
>> initialization which must be done early. For qbman, retrieving the
>> address and size can be done in probe just as easily.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> drivers/soc/fsl/qbman/bman_ccsr.c | 27 +++---------
>> drivers/soc/fsl/qbman/dpaa_sys.c | 12 +++--
>> drivers/soc/fsl/qbman/dpaa_sys.h | 4 +-
>> drivers/soc/fsl/qbman/qman_ccsr.c | 73 ++++++++++---------------------
>> 4 files changed, 38 insertions(+), 78 deletions(-)
>>
>
> No one is going to pick this up? I applied to the DT tree.
As discussed in [1], this driver is currently orphaned.
--Sean
[1] https://lore.kernel.org/all/20240219153016.ntltc76bphwrv6hn@skbuf/
[Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embeddedworld2024/Register/ew24517689>
prev parent reply other threads:[~2024-03-05 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 19:29 Rob Herring
2024-03-05 18:02 ` Rob Herring
2024-03-05 18:07 ` Sean Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3beff31a-78a4-471f-a0cd-22379414a298@seco.com \
--to=sean.anderson@seco.com \
--cc=arnd@arndb.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®