From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E2E4225760 for ; Tue, 20 Jan 2026 08:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768897632; cv=none; b=ka4JnUcShIRTmTsynlkfG3zgiOwjqhExHsai59MBhJ3cJk6LM6ic3S1WJRIAmOjGslYrbLyrB3ukl2Qmy/cKdFeEn8+pMbw69QFxUbzTQC9dfL0lAz1UH08Cn8gfGMvTAF8WsOH10NgEMi0INzW/fxD2Nb46qmHLq6oks8Ecne4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768897632; c=relaxed/simple; bh=b3F9T8wKon4w49RwF+HKEQBLY8ObyScOEG6oxY6rFMc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=SSCzA4+zPPEPs/f0aPZt+y6C/DtHnvo+Fa0tzbjc6fR2nJvgF2m99O+JsihzGtzDJVth2OIn/dT6TeE9NMWwHVAQxUlWqSuzMdJU8+CKGWzlThAbHfFZ8z1rMX/f0JBCR13cFQxoIxrHYnWOE3r/GK5IkCnmdJTqRkXqKYlxMBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KkLjRuKV; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KkLjRuKV" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47edd9024b1so31192155e9.3 for ; Tue, 20 Jan 2026 00:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768897629; x=1769502429; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=jhpKp4EOdc/uAxidXP5+DjIvtbDmc1Iqu+qiPd4ztK8=; b=KkLjRuKVLDj/ZOvuKaN8MRaLxkMgNZ/fmye5o4chiugyQ79/cY8bQJf1kjBuLtcEXW mYBhu01pqnVvde+Bc45tqW3d1OGOAJPfdqHmxVw89c3+Um2o3hilyzB4OVq8h7x7oaRt 2+ppQsczrtDlh6ab5jGghPx4BpTQfrY7KRwN3N6aHf2gzEALYyiyOr4ZG6NL7eOCHy27 +SQi/Re/O3nLP7xXAbax/lSRbC8OkEmRMK5uXgVyopb3misXjGj4kH10olswCrdeJLKl F3L8QNVIZEzXbfJN2AiVmRuORsilwUsyeokD77IAoqSsx68rtgfgRQ0h+3/53tlyrjiz Rb5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768897629; x=1769502429; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jhpKp4EOdc/uAxidXP5+DjIvtbDmc1Iqu+qiPd4ztK8=; b=DLDTrbLCaUSJSONG0jtJvZk9uAnl/12ESWWorSuGew6xBT3/4DhUFywu6gZ2DWDBp4 8MdE+iGs0z1iZ7NE5rZXdlKXZ0hZPrVVfjzZVWAdxsoz9wTUreX6Y9QaYJXGigFE0ykl 0YRh73e2dQ5kgp+5G027Ys0+V6wVMjepIUo6+Wa6Wdjqgt98HfEcu+b9vta+4YThDIQu 3ggs8wEZrztCw+0q6DSW/pWfqJlu997AL6goYDmJDvCLfgy6zylpvlsTEeUMLAXjQjIv 8i2+BvuLBMV1amJD7H2Dstkq6giWdZdaK9/U36L+SJ69a6KWooIfxzzKpmQHDvRLjdkp XJpQ== X-Forwarded-Encrypted: i=1; AJvYcCUB0uuljvFCZDHALAav+0ZfLYu6yPz6uzUiahApBFU3EQlga/pmHTnTYEX2RN1iOdauwfHD5V5IguVhUu4=@vger.kernel.org X-Gm-Message-State: AOJu0YwQBEwLwey5A+yKqMALC6aAOj0SUKfBkk4FKfryRnwofyc2LuQ/ 4jYmEVSmnKFlQ/9PCUdPUxVAy+4bJupR69o3tCsU+l7Dq9OX8xFO1tljyJE0WfcmqQQ= X-Gm-Gg: AY/fxX683ey6MmorjRHfBXWDfd3kwlfm4OaR626bY1sChoF/AkaxBvVc340FPKS03Q4 yDbz41gWYUC4q0um/YwoPdy3rXoNUuDgjQYVZz+7fdHYclzyyNQUVTktNhYDXpPqMBQnHmqi9X1 jGoHGl7LySwkX28GCyYI/LI5xhnT1ON7bOlpAm5xvsuXMmCb4Zup+k/34wUT6VajdCm0ZhhItqJ c8paokLGn2wXMf4jJFhyIYRa3CHhFT/YjzQ0tRU/GFL5JEcjIM9yl6YKqazoTw7mBhY6dm8Orjn OkqY+kVN9TzkC6EDBKYYqWCH9SITfSQS286E+yJIMzaRedaWTZctj4/Xa+06ZAG1GU4IG58zfTm qkIx7nOyHSlctidN0govfPpYRJioUeQj+g61RbPuwQAysNBb9OkNVYCngtmFknHI42MfFV2jn/1 VUJHrTQWaYF1N1wReOQOqYW+YA7LI5baAP5jfWbikozblq7aFU9rxQyH/O4cm7r2I= X-Received: by 2002:a05:600c:4748:b0:480:1c85:88bf with SMTP id 5b1f17b1804b1-4801eb10a4amr178650505e9.27.1768897628697; Tue, 20 Jan 2026 00:27:08 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:f0d5:3a84:e303:190e? ([2a01:e0a:3d9:2080:f0d5:3a84:e303:190e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801e80c477sm274167845e9.0.2026.01.20.00.27.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 00:27:08 -0800 (PST) Message-ID: <3bf9ab54-6d9d-4d17-bd43-9f6ad10c48bb@linaro.org> Date: Tue, 20 Jan 2026 09:27:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: "neil.armstrong@linaro.org" Reply-To: Neil Armstrong Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW1BBVENIIHYxXSBhcm02NDogZHRzOiBhbWxvZ2lj?= =?UTF-8?Q?=3A_meson-s4-s905y4-khadas-vim1s=3A_enable_SDIO_interface?= To: Nick Xie , Martin Blumenstingl Cc: "khilman@baylibre.com" , "jbrunet@baylibre.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-amlogic@lists.infradead.org" , "krzk+dt@kernel.org" , "robh@kernel.org" , "conor+dt@kernel.org" , "xieqinick@gmail.com" References: <20260116023900.2036657-1-nick@khadas.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/20/26 02:34, Nick Xie wrote: > [...] >>> +&sdio { >>> +       status = "okay"; >>> +       pinctrl-0 = <&sdio_pins>; >>> +       pinctrl-1 = <&sdio_clk_gate_pins>; >>> +       pinctrl-names = "default", "clk-gate"; >>> +       #address-cells = <1>; >>> +       #size-cells = <0>; >>> +       bus-width = <4>; >>> +       cap-sd-highspeed; >>> +       sd-uhs-sdr50; >>> +       sd-uhs-sdr104; >>> +       max-frequency = <50000000>; >>> +       non-removable; >>> +       disable-wp; >>> + >>> +       amlogic,dram-access-quirk; >> Have you tried without this property? To my knowledge only early G12A >> and G12B SoCs required this. >> The mode enabled by this property limits the SDIO throughput. So it >> should only be used if the silicon requires this. > > Without this property it will get an warning: > > meson-gx-mmc fe088000.mmc: unaligned sg len 96 blksize 512, disabling descriptor DMA for transfer > >>> +       no-sd; >>> +       no-mmc; >>> +       mmc-pwrseq = <&sdio_pwrseq> >>> +       vmmc-supply = <&vddao_3v3>; >>> +       vqmmc-supply = <&vddio_ao1v8>; >> I'm missing: >>   clocks = <&sdio_32k>; >>   clock-names = "lpo"; > > Maybe it is not needed? This clock property looks for the bluetooth not for the Wi-Fi ? > >>> +       brcmf: wifi@1 { >>> +               reg = <1>; >>> +               compatible = "brcm,bcm4329-fmac"; >> Is AP6256 using a bcm43456 chip? If so then this should be (according >> to Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml): >>    compatible = "brcm,bcm43456-fmac", "brcm,bcm4329-fmac"; > > OK, I will fix it in next version. > > With this SDIO patch, the SDIO card detected well, but when try to connect the wifi, it still failed. > So maybe extra patches are needed to make Wi-Fi working. > > [ 5.909858] meson-gx-mmc fe088000.mmc: allocated mmc-pwrseq > [ 6.113160] mmc2: new UHS-I speed SDR104 SDIO card at address 0001 > [ 19.206019] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac43456-sdio for chip BCM4345/9 > [ 19.208638] brcmfmac mmc2:0001:1: Direct firmware load for brcm/brcmfmac43456-sdio.khadas,vim1s.bin failed with error -2 > [ 19.218170] brcmfmac mmc2:0001:1: Direct firmware load for brcm/brcmfmac43456-sdio.clm_blob failed with error -2 > [ 19.332091] brcmfmac: brcmf_c_process_clm_blob: no clm_blob available (err=-2), device may have limited channels available > [ 19.332113] brcmfmac: brcmf_c_process_txcap_blob: no txcap_blob available (err=-2) > [ 19.332327] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4345/9 wl0: Jun 25 2021 17:13:38 version 7.45.96.94 (7bb6b14@SYNA) (r745790) FWID 01-2bdfb64c es7.c5.n4.a3 > [ 19.332731] brcmfmac: brcmf_sdio_read_control: read 232 control bytes failed: -84 > [ 19.332988] brcmfmac: brcmf_sdio_rxfail: abort command, terminate frame, send NAK > [ 21.939090] brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout > [ 35.587422] meson-gx-mmc fe088000.mmc: unaligned sg len 96 blksize 512, disabling descriptor DMA for transfer This is an issue with the driver, it's unrelated with the amlogic,dram-access-quirk, which fixes this because we use a bounce buffer. > [ 44.412677] ieee80211 phy0: brcmf_cfg80211_connect: BRCMF_C_SET_SSID failed (-52) > [ 45.696901] ieee80211 phy0: brcmf_cfg80211_connect: BRCMF_C_SET_SSID failed (-52) > [ 47.491768] ieee80211 phy0: brcmf_cfg80211_connect: BRCMF_C_SET_SSID failed (-52) > [ 53.292090] ieee80211 phy0: brcmf_cfg80211_connect: BRCMF_C_SET_SSID failed (-52) > [ 59.866328] ieee80211 phy0: brcmf_cfg80211_connect: BRCMF_C_SET_SSID failed (-52) > > > Best regards, > Nick >