mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Zheyu Ma <zheyuma97@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: fbdev: sm712fb: Fix crash in smtcfb_write()
Date: Thu, 3 Mar 2022 11:16:27 +0100	[thread overview]
Message-ID: <3c08fd49-75e6-7016-a686-06a761cc679a@gmx.de> (raw)
In-Reply-To: <CAMhUBj=P82_f6LdhWqEbe06SRPrMU2jxquNzgWkrttGDy6C4Kg@mail.gmail.com>

On 3/3/22 02:34, Zheyu Ma wrote:
> Hi,
>
> On Thu, Mar 3, 2022 at 12:49 AM Helge Deller <deller@gmx.de> wrote:
>>
>> On 3/2/22 15:33, Zheyu Ma wrote:
>>> When the sm712fb driver writes three bytes to the framebuffer, the
>>> driver will crash:
>>>
>>>     BUG: unable to handle page fault for address: ffffc90001ffffff
>>>     RIP: 0010:smtcfb_write+0x454/0x5b0
>>>     Call Trace:
>>>      vfs_write+0x291/0xd60
>>>      ? do_sys_openat2+0x27d/0x350
>>>      ? __fget_light+0x54/0x340
>>>      ksys_write+0xce/0x190
>>>      do_syscall_64+0x43/0x90
>>>      entry_SYSCALL_64_after_hwframe+0x44/0xae
>>>
>>> Fix it by removing the open-coded endianness fixup-code.
>>>
>>> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
>>
>> Thanks... it's already in the fbdev git tree and queued up for v5.18...
>> https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/commit/?h=for-next&id=bd771cf5c4254511cc4abb88f3dab3bd58bdf8e8
>
> This patch fixes the crash in smtcfb_read(), but there is a similar
> bug in smtcfb_write(), and I mocked up your patch a wrote a new patch
> for it.
> So we should fix two bugs with two patches.

Right, I missed the read() code.

I applied your patch now to the fbdev for-next git tree.

Thanks!
Helge


>
> Regards,
> Zheyu Ma


      reply	other threads:[~2022-03-03 10:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02 14:33 Zheyu Ma
2022-03-02 16:48 ` Helge Deller
2022-03-03  1:34   ` Zheyu Ma
2022-03-03 10:16     ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c08fd49-75e6-7016-a686-06a761cc679a@gmx.de \
    --to=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    --cc=zheyuma97@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®