From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD26B172BD5 for ; Thu, 8 May 2025 22:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746745071; cv=none; b=a7okgDGfbmiGxM1jA0X0GAigusLVZUp4PGEAARQRVTl+ewxvxsXoJzDeVh7QYYK4Lus9OB5+XU2nlsMekTIw9lgtNuQFsFeEokLPWEORzwMRYxNiIbaXqfdF4JLmv4tGpBljF8SZ0r7RAhOOYQRFfNvIP43Ap0pQQxubLitkJ/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746745071; c=relaxed/simple; bh=B2SbnoaVXsgvl3TP0ClbBFtCJLQ4Op6iWjB4E3/WFYY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HxJYoa37qOs/5DZKYa6j+tr+a8IiKBvg/e8hSNoA11xBhec/C7OHGZCRJBwt/Iq40Q8ks0gE+auePfg8XTAJHxFn6iqFIlng8UDyjxzzRgV77x4vwDaOapdu3QvhxCLs4riKBuGlOb+8NaCZx+6Baj3JvU5ls7w5Ye+qZ3eiL/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hoEElJK4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hoEElJK4" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 548DKc1G016419 for ; Thu, 8 May 2025 22:57:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Cg/tISJIMaT0Gm0WnDpcV1xCOuL4/CvFo6caXG5lllY=; b=hoEElJK4411CYouu nmvVX5tBkg1ik//LkkXsWpVxWVi7bZ2h8hLTX6Ak15I+iMfdng2MPI7hbrTKihIM omtWC8PNaGF+EyBcwlEOy+hvj+UQwZr5f+AnQcyivP77m4BpqcjlLDQ0H0cULzrC 308WxUxpI0cIKJgOJKVHHrpkCwos0J9KvHsnbccm+7i+iccOGV6+bCB/B+ckp6Hp tSGCrp6HuxZP0fDIUZsi63wASoKilR7Sxk7H/6X7K0ZxFpqJfQoq/4EeZEGK08CA ZaaHjkraZcjwvPxFNbiHy/ZFLS+1NINScjNg3Sjzrjd+FjSoMuQMeSGIKF/OXDR8 5be5Vw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46gnp8trnh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 08 May 2025 22:57:48 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6f5466289bdso2159556d6.1 for ; Thu, 08 May 2025 15:57:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746745068; x=1747349868; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cg/tISJIMaT0Gm0WnDpcV1xCOuL4/CvFo6caXG5lllY=; b=DeVruCG5rmjHCV3aie2njCr3JyE81QMQ2aS5ZABlu3OKk4KmJ4Mf8S/Cadz3ENcFYk Gi6tgKVgLQgnf8tcX/9Pj6JOrBuZBkbEK7CYvgym2QIdBpNdaL6Bb7MvbETpTsWOG0zT 5/Ni9KcWRESUtjfBQaqi3Vo5iEbHcYimJAOwdlh3RCPyxUGfqz77HC2GNC9MvieTQNX6 /SnOd2JkEuSNO/ML9L6VgMLcOz4fln0LxXaDMielHtliTYHkaU7KZuhEOmzCPluR4kSl y1/QW1mKiV81vkYsVU3MoFJukuHd6AmuXo6jNJV8wesh/SC4ZdRvKMo0FA1jQtyhqhI3 5YTQ== X-Forwarded-Encrypted: i=1; AJvYcCVgh7WA8rDvXuAeAgxDS+0+hN4NDCEBokrum9vyz6U8T5dpsbLDXUr0NBts4VU5LxQV2zwPXqOCwhZXVh8=@vger.kernel.org X-Gm-Message-State: AOJu0YwzZ268RgpFuak1xIf9RD/cGi8HAE/f5RsVZap+ipy0JP3sDeH1 v1no60CbIlU0IkE5SvUowRYwSNHKZhrUuRJmfoE9XO/it0sJuAcurj2VKLjROz0U37T1ljiw48v R7yrQO6ifsc9t9z8OxV5cPOFQQ+d7S7zpoOUhke4RMN1MJvJpgRz6KIcYJVRVssQ= X-Gm-Gg: ASbGncvao4TrHW+jdXCKJggMyiNkPnLwZIp4X7AAXFh9xF2EV2LbEcUldqCzC/G9Rbq v9uourqaRDMPy7wfp6YFO6OcJBpTk7W6WaT/z1d5ez32YV2ozrSfWHQ/4MQTtAdyP9FvS15mGhJ 7gvV6EN3cIp8foJ3plrf2DZrmQ4hbF46gdOusJgOm/saQhGKwqO4uo+mblHhgKpszDVmOG4ar07 folXOwxybI74NB3txTQXcgvg5jOpvcEM6SeR3CYF9jbRqzZ8VOl5towW8iSF3RK7WZnk79Hfw9Y M74ZxBZ82e4qCoYMPFa3TrkbQiSio4QQz5vPeCRGs31mtDa9H8aKtggImfXg+QGdeS8= X-Received: by 2002:a05:620a:2452:b0:7c5:9ab7:3012 with SMTP id af79cd13be357-7cd0114145fmr84450885a.11.1746745067685; Thu, 08 May 2025 15:57:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2s+oB6HkxxT4d0lM7bmLSmPrIM683EN2m3B/pSVjMRkJKV/JUPOChZeDLpjtb0iG/hd4+vQ== X-Received: by 2002:a05:620a:2452:b0:7c5:9ab7:3012 with SMTP id af79cd13be357-7cd0114145fmr84449185a.11.1746745067288; Thu, 08 May 2025 15:57:47 -0700 (PDT) Received: from [192.168.65.105] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad219746072sm52582966b.112.2025.05.08.15.57.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 15:57:46 -0700 (PDT) Message-ID: <3c0fea8d-0715-40e6-bed9-e0961bf034e0@oss.qualcomm.com> Date: Fri, 9 May 2025 00:57:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sm8750: Add adsp fastrpc support To: Alexey Klimov , andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, quic_ekangupt@quicinc.com, krzysztof.kozlowski@linaro.org References: <20250502011539.739937-1-alexey.klimov@linaro.org> <10f69da3-6f94-4249-a8f3-459dc48fa5e1@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: rJqSaeQafhEYDTFst298rImuBKu40ydN X-Proofpoint-ORIG-GUID: rJqSaeQafhEYDTFst298rImuBKu40ydN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA4MDIwOSBTYWx0ZWRfX6EWLnl15wSxO 8dUKtJSqTQvN7Z/6TcWzH8ylKSzfFsTQRvKXa5sD/96dITGBr4JbDMQMfmsX6oB2UYLvDFNAQ8E cNz/DCw4XwIdvHO3toLWsqSGvirh+A4UW2bE0MJzOR3MAVQQDRZr2wxjqxGxus2fl2beRtM55Lc fd7+jP2VumUSmyMt8iqx44tbdOrg94cwZIegTm+YojaNLoFnXB5NueGXhghGh3e54hQ4S3/UAAL J1feNoO/yoKW17LnmMJKAzeGA4YEKzxrls4gi7ZsN2DNF0dxHq21zoXJ/3i6i5P386SiUnVwxjx L5govZoVx2saRSZc2FIv47nFWuNmSZyDc5wB8J+0u0iZtXyww0jr68MP/NISeNUME77nvwMnGq4 jExuQ4bsi34TaawqLiYeqJuVhu6ytx0SQIsyhbiJe2jOMuaI21+a4I3iWzSyXUc/g8XD3bcI X-Authority-Analysis: v=2.4 cv=e/4GSbp/ c=1 sm=1 tr=0 ts=681d36ec cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=zwkf0SmHCyEPBq45FFAA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=TjNXssC_j7lpFel5tvFf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-08_07,2025-05-08_04,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 clxscore=1015 mlxlogscore=981 spamscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505080209 On 5/9/25 12:20 AM, Alexey Klimov wrote: > On Fri May 2, 2025 at 10:38 AM BST, Konrad Dybcio wrote: >> On 5/2/25 3:15 AM, Alexey Klimov wrote: >>> While at this, also add required memory region for fastrpc. >>> >>> Tested on sm8750-mtp device with adsprpdcd. >>> >>> Cc: Ekansh Gupta >>> Cc: Srinivas Kandagatla >>> Cc: Krzysztof Kozlowski >>> Signed-off-by: Alexey Klimov >>> --- >>> arch/arm64/boot/dts/qcom/sm8750.dtsi | 70 ++++++++++++++++++++++++++++ >>> 1 file changed, 70 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi >>> index 149d2ed17641..48ee66125a89 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi >>> @@ -7,6 +7,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -523,6 +524,14 @@ llcc_lpi_mem: llcc-lpi@ff800000 { >>> reg = <0x0 0xff800000 0x0 0x800000>; >>> no-map; >>> }; >>> + >>> + adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap { >>> + compatible = "shared-dma-pool"; >>> + alloc-ranges = <0x0 0x00000000 0x0 0xffffffff>; >>> + alignment = <0x0 0x400000>; >>> + size = <0x0 0xc00000>; >>> + reusable; >>> + }; >>> }; >>> >>> smp2p-adsp { >>> @@ -2237,6 +2246,67 @@ q6prmcc: clock-controller { >>> }; >>> }; >>> }; >>> + >>> + fastrpc { >>> + compatible = "qcom,fastrpc"; >>> + qcom,glink-channels = "fastrpcglink-apps-dsp"; >>> + label = "adsp"; >>> + memory-region = <&adsp_rpc_remote_heap_mem>; >> >> IIUC the driver only considers this on the sensor DSP > > Memory region is required for audio protection domain + adsprpdcd as far as I know. next-20250508 rmem_node = of_parse_phandle(rdev->of_node, "memory-region", 0); if (domain_id == SDSP_DOMAIN_ID && rmem_node) { // ... } maybe some driver changes are still pending? Konrad