From: Neil Armstrong <neil.armstrong@linaro.org>
To: Yangtao Li <frank.li@vivo.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/18] drm/bridge: analogix_dp: Convert to devm_platform_ioremap_resource()
Date: Fri, 7 Jul 2023 09:27:47 +0200 [thread overview]
Message-ID: <3c0ff63e-a35d-60b6-38aa-178219e65cbd@linaro.org> (raw)
In-Reply-To: <20230707072034.48977-7-frank.li@vivo.com>
On 07/07/2023 09:20, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index df9370e0ff23..c6b228f1ed4c 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1686,7 +1686,6 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
> {
> struct platform_device *pdev = to_platform_device(dev);
> struct analogix_dp_device *dp;
> - struct resource *res;
> unsigned int irq_flags;
> int ret;
>
> @@ -1740,9 +1739,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
>
> clk_prepare_enable(dp->clock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> - dp->reg_base = devm_ioremap_resource(&pdev->dev, res);
> + dp->reg_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(dp->reg_base)) {
> ret = PTR_ERR(dp->reg_base);
> goto err_disable_clk;
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-07-07 7:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 7:20 [PATCH 01/18] drm/renesas: " Yangtao Li
2023-07-07 7:20 ` [PATCH 02/18] gpu: ipu-v3: pre: " Yangtao Li
2023-07-07 8:20 ` Philipp Zabel
2023-07-07 7:20 ` [PATCH 03/18] drm/rockchip: dsi: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-07 7:20 ` [PATCH 04/18] drm: kirin: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-07 7:20 ` [PATCH 05/18] drm/tegra: hdmi: " Yangtao Li
2023-07-07 7:20 ` [PATCH 06/18] drm: bridge: dw_hdmi: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-07 7:27 ` Neil Armstrong
2023-07-07 7:20 ` [PATCH 07/18] drm/bridge: analogix_dp: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-07 7:27 ` Neil Armstrong [this message]
2023-07-07 7:20 ` [PATCH 08/18] gpu: ipu-v3: prg: " Yangtao Li
2023-07-07 8:20 ` Philipp Zabel
2023-07-07 7:20 ` [PATCH 09/18] drm/hisilicon: " Yangtao Li
2023-07-07 7:20 ` [PATCH 10/18] drm: lcdif: " Yangtao Li
2023-07-07 7:20 ` [PATCH 11/18] drm/mxsfb: " Yangtao Li
2023-07-07 7:20 ` [PATCH 12/18] drm/tegra: dpaux: " Yangtao Li
2023-07-07 12:28 ` Thierry Reding
2023-07-07 7:20 ` [PATCH 13/18] drm/stm: ltdc: " Yangtao Li
2023-07-07 13:37 ` Raphael Gallais-Pou
2023-07-07 7:20 ` [PATCH 14/18] drm/aspeed: " Yangtao Li
2023-07-07 7:20 ` [PATCH 15/18] drm/tegra: sor: " Yangtao Li
2023-07-07 7:20 ` [PATCH 16/18] drm/rockchip: vop: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-07 7:20 ` [PATCH 17/18] drm/arcpgu: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-07 13:24 ` Alexey Brodkin
2023-07-07 7:20 ` [PATCH 18/18] drm/fsl-dcu: " Yangtao Li
2023-07-07 8:33 ` [PATCH 01/18] drm/renesas: " Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c0ff63e-a35d-60b6-38aa-178219e65cbd@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.li@vivo.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®