From: Jon Hunter <jonathanh@nvidia.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: kernel@collabora.com, kernel-janitors@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc/tegra: cbb: remove linux/version.h
Date: Mon, 6 Mar 2023 15:58:38 +0000 [thread overview]
Message-ID: <3c1354b2-831e-d523-a539-904135fe34f4@nvidia.com> (raw)
In-Reply-To: <20230303130346.2062989-1-usama.anjum@collabora.com>
On 03/03/2023 13:03, Muhammad Usama Anjum wrote:
> make versioncheck reports the following:
> ./drivers/soc/tegra/cbb/tegra-cbb.c: 19 linux/version.h not needed.
> ./drivers/soc/tegra/cbb/tegra194-cbb.c: 26 linux/version.h not needed.
> ./drivers/soc/tegra/cbb/tegra234-cbb.c: 27 linux/version.h not needed.
>
> So remove linux/version.h from these files.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> drivers/soc/tegra/cbb/tegra-cbb.c | 1 -
> drivers/soc/tegra/cbb/tegra194-cbb.c | 1 -
> drivers/soc/tegra/cbb/tegra234-cbb.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/soc/tegra/cbb/tegra-cbb.c b/drivers/soc/tegra/cbb/tegra-cbb.c
> index a8566b9dd8de..bd96204a68ee 100644
> --- a/drivers/soc/tegra/cbb/tegra-cbb.c
> +++ b/drivers/soc/tegra/cbb/tegra-cbb.c
> @@ -16,7 +16,6 @@
> #include <linux/of_address.h>
> #include <linux/interrupt.h>
> #include <linux/ioport.h>
> -#include <linux/version.h>
> #include <soc/tegra/fuse.h>
> #include <soc/tegra/tegra-cbb.h>
>
> diff --git a/drivers/soc/tegra/cbb/tegra194-cbb.c b/drivers/soc/tegra/cbb/tegra194-cbb.c
> index d4112b683f00..a05fc2caff3b 100644
> --- a/drivers/soc/tegra/cbb/tegra194-cbb.c
> +++ b/drivers/soc/tegra/cbb/tegra194-cbb.c
> @@ -23,7 +23,6 @@
> #include <linux/of_address.h>
> #include <linux/interrupt.h>
> #include <linux/ioport.h>
> -#include <linux/version.h>
> #include <soc/tegra/fuse.h>
> #include <soc/tegra/tegra-cbb.h>
>
> diff --git a/drivers/soc/tegra/cbb/tegra234-cbb.c b/drivers/soc/tegra/cbb/tegra234-cbb.c
> index f33d094e5ea6..e23e8acfd7c7 100644
> --- a/drivers/soc/tegra/cbb/tegra234-cbb.c
> +++ b/drivers/soc/tegra/cbb/tegra234-cbb.c
> @@ -24,7 +24,6 @@
> #include <linux/of_address.h>
> #include <linux/interrupt.h>
> #include <linux/ioport.h>
> -#include <linux/version.h>
> #include <soc/tegra/fuse.h>
> #include <soc/tegra/tegra-cbb.h>
>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Thanks
Jon
--
nvpublic
next prev parent reply other threads:[~2023-03-06 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 13:03 Muhammad Usama Anjum
2023-03-06 15:58 ` Jon Hunter [this message]
2023-03-23 14:45 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c1354b2-831e-d523-a539-904135fe34f4@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®