From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C2EA217660 for ; Wed, 28 May 2025 10:49:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748429350; cv=none; b=EgabqvGJ+d59EF3sEQ6CVx4U0ch6U5eQtBaTDmWSwdhZwAAgiWzCWHdW+r8138v+6zM6CIPEffeCut2B0R6xNlMb7uUEx+m4AxbDd/J5XOWGaEo2AMICLqG79UVHRP3egIx6DN3DV+icgG3CXgzdZgzEZ3TkR8Lq/C/4VAbblVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748429350; c=relaxed/simple; bh=ohq0aKy46MqiNiDa5pDJ2hhxanBLxI6940+C/u71zSw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=VVkHGVEzBcCHzEo8O7U44HKren/S7lJ4+zTAlCYDVp8LFeVl3vAp4KHbb49H38U7k87mZSzgPCe2Mw8KZrJTTyOrepBUBafcK77Sj7lR+Tb3HoBeV1fv54gVQwH6UBOxehiFc68Lxz02096SWEvMG72xU47eNYdhZF5R+b9x358= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cTQU68mr; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cTQU68mr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748429347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L9zdNnDwAfNYHub/SLO4R5U1ZnoXRuT66VkqLwVbfTw=; b=cTQU68mr71JqwbsUgc/jghUV5tysNIiFdVM5UOmBfZvhbyAFcbATAFYgiQ4loJLIUfg1UX ubAsQR8r9/7RwSoKMza/C8wCM5aU0vy52RC4DXG2CVZElTFe/yf+bHvzMb+AaWAU24g2fl kBZtt7ep6BkAHOmrW/wtNScd9GhRHnw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-Omx3Ovs4PwaW2L-H4yehaQ-1; Wed, 28 May 2025 06:49:04 -0400 X-MC-Unique: Omx3Ovs4PwaW2L-H4yehaQ-1 X-Mimecast-MFC-AGG-ID: Omx3Ovs4PwaW2L-H4yehaQ_1748429341 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d4d15058dso32469035e9.0 for ; Wed, 28 May 2025 03:49:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748429341; x=1749034141; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L9zdNnDwAfNYHub/SLO4R5U1ZnoXRuT66VkqLwVbfTw=; b=GbZHBYmtzq2MyTWi1RXDbon0UPSURvWsig+P0JaUEUGdnpaQbClYj7sGP2rFk9CYNb +xg0usNkdaTB4dCh2NocVpsBXaXGy12GbE25ziTpGzn1p+nrHCT4jFkI3+bEFbSedIUz DfRVC/ZvAmW9aVfUXUnWVBV9p02D1FxKgVW80ntWdUfeVwht5ZHZ37s2+peSj+0x0zau b27GcaamvpjjMFqPM4lr0UmGsy5X4Fq8ZIKZhDX78tgoPCcv33zb3MOEqa6CvnIAS3f0 CxxZAvQRL47JMZYObgQmSvbSQ6kZHyZVR+cEjqzplpnMU7SVumGDE42WIYleovzzxvLc jDTQ== X-Forwarded-Encrypted: i=1; AJvYcCWW4eqaRJk1Nqo8+BFamEWy3vidsY/ShaeOKVNzmeIEnSqt5Sbh4PYZ4MWwcLxWQ4b6hVaitcAViIfd+NU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa34ou5E+jhVIl9xRz+IZ+sS+g3F4J3ylnUHviT3tbvrbbA9CW 6vJKTSYnYvAM9BWSTU1zjUTPW5OWoeqBPNy7IFoszNtExQclYgSbS1qxT5Wa+XIHPfu3T9drFr9 yDAtwpX/t+kST4yscIma/sF5QPd9LbbGDp0oJikAqRvlkcJyPEFAGpCUrSK47zXnazA== X-Gm-Gg: ASbGnctT7Ad8z6Icv1Wv+IehJbmxwjy1qmSw3NrNuq9d/PUV4nJtse45QNMnucBMYZf /KPuExIqbRmyimIqTrhYxdWzG3lwJALJXsKW1QIsapEyz7VAuX0xfeKlzKiUN5CY6QDWI145R7C px8ly7/v+Wsru6ppcfxr0dXlAuCIpsN91v+wUyM/RIZu1Mq2BSuLskKogIHXLsfwsscflMQ9xnS 3wkWaM2qFodpNOpHDoUCwzZeP/WJX7UtktgnDz9I+NTl7Ky/f4cMtfxax0Ulk6Y2zvMUwfznZdT qxZVMpFFfEjuI6RMB0b6dWmbeyGezVUcXc3RMUNmWrL95S01qFYXe7hbwASor3sZqdy/oVAtWBA uFOQQRa6ytDRA7xCSc07qNZ3im2v0mpRdRC86VOI= X-Received: by 2002:a05:600c:648a:b0:43e:a7c9:8d2b with SMTP id 5b1f17b1804b1-44c92f21e1fmr127213105e9.24.1748429340969; Wed, 28 May 2025 03:49:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhLT5tb7zUh11ADM14vMwzRiC9TD0IByrsLMVhGQOhNMyEK6r+6gLgjV47NeCbATlZyERZlA== X-Received: by 2002:a05:600c:648a:b0:43e:a7c9:8d2b with SMTP id 5b1f17b1804b1-44c92f21e1fmr127212825e9.24.1748429340531; Wed, 28 May 2025 03:49:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36? (p200300d82f30ec008f7e58a4ebf06a36.dip0.t-ipconnect.de. [2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450725403c6sm14119995e9.3.2025.05.28.03.48.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 03:49:00 -0700 (PDT) Message-ID: <3c15a093-7c19-4c2a-a571-56a5ed4b445f@redhat.com> Date: Wed, 28 May 2025 12:48:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem From: David Hildenbrand To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Andrew Morton , Shuah Khan , Lorenzo Stoakes , Ingo Molnar , Peter Xu , Dev Jain , Aishwarya TCV References: <20250509153033.952746-1-david@redhat.com> <232960c2-81db-47ca-a337-38c4bce5f997@arm.com> <7cb7f23a-ce9e-4664-8083-deb73ed23da3@redhat.com> Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <7cb7f23a-ce9e-4664-8083-deb73ed23da3@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28.05.25 12:44, David Hildenbrand wrote: > On 28.05.25 12:34, Ryan Roberts wrote: >> Hi David, >> >> >> On 09/05/2025 16:30, David Hildenbrand wrote: >>> Let's test some basic functionality using /dev/mem. These tests will >>> implicitly cover some PAT (Page Attribute Handling) handling on x86. >>> >>> These tests will only run when /dev/mem access to the first two pages >>> in physical address space is possible and allowed; otherwise, the tests >>> are skipped. >> >> We are seeing really horrible RAS errors with this test when run on arm64 tx2 >> machine. Based solely on reviewing the code, I think the problem is that tx2 >> doesn't have anything at phys address 0, so test_read_access() is trying to put >> trasactions out to a bad address on the bus. >> >> tx2 /proc/iomem: >> >> $ sudo cat /proc/iomem >> 30000000-37ffffff : PCI ECAM >> 38000000-3fffffff : PCI ECAM >> 40000000-5fffffff : PCI Bus 0000:00 >> ... >> >> Whereas my x86 box has some reserved memory: >> >> $ sudo cat /proc/iomem >> 00000000-00000fff : Reserved >> 00001000-0003dfff : System RAM >> ... >> > > A quick fix would be to make this test specific to x86 (the only one I > tested on). We should always have the lower two pages IIRC (BIOS stuff etc). > >> I think perhaps the only safe way to handle this is to parse /proc/iomem for a >> region of "System RAM" that is at least 2 pages then use that for your read >> tests. This would also solve the hypothetical issue of reading something that >> has read size effects. > > That sounds also plausible yes. I somehow remembered that mmap() would > fail if "there is nothing". Ah, my memory comes back, we perform checks only with CONFIG_STRICT_DEVMEM. -- Cheers, David / dhildenb