From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755786AbcETNKH (ORCPT ); Fri, 20 May 2016 09:10:07 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:42629 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753553AbcETNKE (ORCPT ); Fri, 20 May 2016 09:10:04 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 220.200.59.71 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <2d927a3d32443e617607e7be9ea81b72> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 To: Heiko Stuebner References: <1463702182-5188-1-git-send-email-wxt@rock-chips.com> <1463702182-5188-3-git-send-email-wxt@rock-chips.com> <8f662b3b-e359-efdf-72e5-c4f862dd1cf6@kernel-upstream.org> <28155403.nCsUkeXQB1@phil> Cc: shawn.lin@rock-chips.com, Caesar Wang , Mark Brown , Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Russell King , linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , linux-arm-kernel@lists.infradead.org From: Shawn Lin Message-ID: <3c1e174e-035b-78ae-b045-fe89990826da@rock-chips.com> Date: Fri, 20 May 2016 21:09:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <28155403.nCsUkeXQB1@phil> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/5/20 20:58, Heiko Stuebner wrote: > Am Freitag, 20. Mai 2016, 20:35:53 schrieb Shawn Lin: >> 在 2016/5/20 7:56, Caesar Wang 写道: >>> That's seem the incorrect string to match the spi driver. >> >> Will it break the backward compatibility for some dtb if not >> falling back to "rockchip,rockchip-spi" ? > > in what dtb did you see "rockchip,rockchip-spi"? I'm not 100% sure, but I remember we toke this name on local branch for rk3036 when we were developing this Soc. > I.e. it isn't part of any current _mainline_ devicetree files. > Caesar, Could you check our develop-3.10 branch to see if it does exist? Anyway, "rockchip,rockchip-spi" isn't a part of mainline dt property. > > Heiko > >> >>> Fixes commit f629fcfab2cd >>> ("ARM: dts: rockchip: support the spi for rk3036") >>> >>> Signed-off-by: Caesar Wang >>> Cc: Heiko Stuebner >>> Cc: linux-rockchip@lists.infradead.org >>> >>> --- >>> >>> Changes in v2: None >>> >>> arch/arm/boot/dts/rk3036.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/rk3036.dtsi >>> b/arch/arm/boot/dts/rk3036.dtsi index d0f4bb7..a30700a 100644 >>> --- a/arch/arm/boot/dts/rk3036.dtsi >>> +++ b/arch/arm/boot/dts/rk3036.dtsi >>> @@ -431,7 +431,7 @@ >>> >>> }; >>> >>> spi: spi@20074000 { >>> >>> - compatible = "rockchip,rockchip-spi"; >>> + compatible = "rockchip,rk3036-spi"; >>> >>> reg = <0x20074000 0x1000>; >>> interrupts = ; >>> clocks =<&cru PCLK_SPI>, <&cru SCLK_SPI>; > > -- Best Regards Shawn Lin