From: David Heidelberg <david@ixit.cz>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Alexey Minnekhanov <alexeymin@minlexx.ru>,
Robin Snyders <robin@snyders.xyz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Casey Connolly <casey.connolly@linaro.org>,
Sebastian Reichel <sre@kernel.org>
Cc: Richard Acayan <mailingradian@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Sebastian Reichel <sebastian.reichel@collabora.com>,
linux-pm@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH 03/11] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660
Date: Mon, 2 Nov 2026 11:04:41 +0100 [thread overview]
Message-ID: <3c21a85e-4aa4-4c95-808e-a73a6e4f43ab@ixit.cz> (raw)
In-Reply-To: <8433ec2e-0f0e-4816-b3a5-6cdd7a6d1040@oss.qualcomm.com>
On 02/11/2026 10:58, Konrad Dybcio wrote:
> On 10/31/26 4:05 PM, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> The VBUS register block on the PMI8998 and PM660 PMIC shares the design
>> with the PM8150B one. Define corresponding compatible string, having the
>> qcom,pm8150b-vbus-reg as a fallback.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>
> This is absolutely not true. They both have a similar CMD_OTG
> register at +0x40 which makes the driver seem like it's working
> for you, but otherwise the register layout diverges a lot.
In that case, since current skeleton and implemented features are common, I
would add separate pmi8998/pm660 compatible to the driver, without functional
changes AND without the compatible fallback to 8150b?
Looking into docs, do you consider it good enough?
David
>
> Konrad
next prev parent reply other threads:[~2026-11-02 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 15:04 [PATCH 00/11] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg via B4 Relay
2026-10-31 15:04 ` [PATCH 01/11] regulator: qcom_usb_vbus: Fix the MODULE_LICENSE() string David Heidelberg via B4 Relay
2026-10-31 15:04 ` [PATCH 02/11] power: supply: qcom_smbx: Do not interfere with vbus driver David Heidelberg via B4 Relay
2026-10-31 15:05 ` [PATCH 03/11] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660 David Heidelberg via B4 Relay
2026-11-02 9:58 ` Konrad Dybcio
2026-11-02 10:04 ` David Heidelberg [this message]
2026-10-31 15:05 ` [PATCH 04/11] arm64: dts: qcom: pmi8998: Add node for PMIC VBUS booster David Heidelberg via B4 Relay
2026-10-31 15:05 ` [PATCH 05/11] arm64: dts: qcom: pm660: " David Heidelberg via B4 Relay
2026-10-31 15:05 ` [PATCH 06/11] arm64: dts: qcom: sdm845-google: Enable vbus support David Heidelberg via B4 Relay
2026-10-31 15:05 ` [PATCH 07/11] arm64: dts: qcom: sdm845-oneplus: " David Heidelberg via B4 Relay
2026-10-31 15:05 ` [PATCH 08/11] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg via B4 Relay
2026-10-31 15:05 ` [PATCH 09/11] arm64: dts: qcom: sdm845-lg: " David Heidelberg via B4 Relay
2026-10-31 15:05 ` [PATCH 10/11] arm64: dts: qcom: sdm845-xiaomi-beryllium: " David Heidelberg via B4 Relay
2026-10-31 15:05 ` [PATCH 11/11] arm64: dts: qcom: sdm670-google: " David Heidelberg via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c21a85e-4aa4-4c95-808e-a73a6e4f43ab@ixit.cz \
--to=david@ixit.cz \
--cc=abelvesa@kernel.org \
--cc=alexeymin@minlexx.ru \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=robin@snyders.xyz \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®