From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 541FF2DF701 for ; Mon, 6 Apr 2026 13:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775483979; cv=none; b=C2zX1xZ+ysYOHfOaGUtpaA5s2ukl4uYawTDNH0u2a6jH07TAL8RVR7SLtl1HCVnATGNBSnSzAxyS6yszt4xtwqcExvCKUmkkI8rttWnBKgNzwt8+qsclFMja6qzOoO9XE4J2EMEB+omWTnjN2yKGrO6TNUD502eFyJM45/uTzjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775483979; c=relaxed/simple; bh=aNDOiPoUYaogDOyPJjzo1tvadFAmDnc56pANEy4qgcg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C2K1fHSvXFXdYE078S8GVtwLulwREqPmJ5rNnQ6jSsQxW/76aqMo5vB4FYdhmz4kQ6HNeN5X58pXSv/5G7rXTL/5YyJ9M7PrcddU70vR60QsY+8yuYhlEXqMYvynl2a4mhUcv33cfq7afHEzMDlonorRStvpoyCs/sHY8XCHYuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=moFd7wTj; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="moFd7wTj" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-464bc03efd8so1871587b6e.2 for ; Mon, 06 Apr 2026 06:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775483976; x=1776088776; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kCi/ffQ5hb85YnIhfegeAyP7smgQQkcrABLKqEm7GPQ=; b=moFd7wTjaob3hSIRSJlD1MmZZqIYqxj8CgqkvYEBKdpr7x9GLO1vcIgXIzykZkcRFD qhe8vI51t+mmXnhwZLJ81uO4bx5NV3i6iZv4Nr1gYpt7yAMxuV4KFc/3JnUNe5G5l/A8 51gYbzQ/DdtMU21YbcTrFE+NJ9ic50zKWktY+Aau4dQwtURobrEYkc9PYICNyKaO/F5X ccd3kMTIFVlI1jbhtuzDToeFEwnfaOUVqwU60tcmuyGsLIKy+gDw3WwgNS3og7f3mUmq Hzw1dzbiz6KKMb4ZKxKXmut4r5it07ZqCBM9rUdPJ8759t2g0edwTa9oG4NXnTesqKdm tUYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775483976; x=1776088776; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kCi/ffQ5hb85YnIhfegeAyP7smgQQkcrABLKqEm7GPQ=; b=IEytyh1PFLL3OE2sGhJTQqRSpe/gAu50U+2CNbk9bvWxQ2YC9fmoKv5zVoDGvg/w5p 2HpNxv8VN3e3zZIMpX1guLM4BhAPEl3NHSMenxaXjdxIdTlHOsMMblAt+KcpFa7Y36Dr 6/eTBF8c9Nf5jIgIr3oBSXg+nvEUe1GxMuUTTrSj4nPiozIy2siB/9HXPwE3lagmo8I7 pbphgfkmWcH3damXCR98Xy8abAAmQ59pRO3NAGsC7TqnJk+nmz+46OoLLSKpfA1y22+x YhsLhpizO0DQPRBqlJp0f0++i5x8CyRxrOnjX4Ny0Jrjgdrlwt+MdY/el9aUsSJgnbjJ wI0A== X-Forwarded-Encrypted: i=1; AJvYcCVAkl91r6tzvDzoS7Q/cLCtjD4aLUmAZG/UDq4TY1ShfZT1EfQMiqWeiLxMusv38QgDwUYtmXLKlU/CCjM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxzky9orOrex+ZeXM1D0BuhoswxpzJw65zgt8PPieDWRjC+6SnE 0BzlYw1bfYhBJKx9/xUxuVqcG7UaV/aN5yNQ8Kml8RZpzmrVKEBvx+URcQXDBDNCIm8= X-Gm-Gg: AeBDievQs0xUNyL+F6N21viESKgoJSMCi6+Mh+ZlgzzOVh7CNxAa5v/M/4mhqwSeTex jJ9OWzrauNh94yNG8EGC3PkHhtWIVfS3SRxozH9f3vaUHHX2Po2QMYk6yF+CGJTabD4SCexYdre hc/4stWUokI0Q+CtGRJ7Gy+HVDoNSQAeiu44CppKZadfyPOu/+p5C2jUd4IdGFbp9WgKrhrZ9lj llfBvJkAbagOzqS7Zs5tut9e1XjGNlyObDmznxenQ9VHz9aKlTlB2YjqN1jE/pu30KMvgLd8lR5 4sH72HIQxFVwORXzYHA0aeuQDkZJOTVzXSNAazE0DvmtxDTKfAJ19tKDRj5L9W+I9IASUAF0bAb +RDPpntC31KzIvwV88oQJp9wPnxZjbataKa5UgpTVsS7oF4RDMZ4a2TtzNpJ36PAqQusneGcqRE IGYRNZdaAFukd5NA7f4sraZykZyLBjMApVJJL1oMuRY9P13Fa85JPzrvFuaWqTj6is3ez/b6Y= X-Received: by 2002:a05:6808:c16e:b0:467:5571:1b0a with SMTP id 5614622812f47-46efb1cf759mr6443287b6e.26.1775483976306; Mon, 06 Apr 2026 06:59:36 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:90d7:b13f:c53:8ca3? ([2600:8803:e7e4:500:90d7:b13f:c53:8ca3]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-422eaf2c7c3sm11358441fac.5.2026.04.06.06.59.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 06:59:35 -0700 (PDT) Message-ID: <3c24723f-801c-46a5-9257-910f3c181235@baylibre.com> Date: Mon, 6 Apr 2026 08:59:34 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: adc: nxp-sar-adc: zero-initialize dma_slave_config To: Shuvam Pandey , Jonathan Cameron Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260406095324.99671-1-shuvampandey1@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260406095324.99671-1-shuvampandey1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/6/26 4:53 AM, Shuvam Pandey wrote: > nxp_sar_adc_start_cyclic_dma() only fills the RX-side members of > dma_slave_config before passing it to dmaengine_slave_config(). > > Zero-initialize the structure so unused members do not contain stack > garbage. Some DMA engines consult optional dma_slave_config fields, so > leaving them uninitialized can cause DMA setup failures. > > Fixes: 4434072a893e ("iio: adc: Add the NXP SAR ADC support for the s32g2/3 platforms") > Signed-off-by: Shuvam Pandey > --- > drivers/iio/adc/nxp-sar-adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/nxp-sar-adc.c b/drivers/iio/adc/nxp-sar-adc.c > index 9efa883c277d..7d7b5a580167 100644 > --- a/drivers/iio/adc/nxp-sar-adc.c > +++ b/drivers/iio/adc/nxp-sar-adc.c > @@ -659,7 +659,7 @@ static void nxp_sar_adc_dma_cb(void *data) > static int nxp_sar_adc_start_cyclic_dma(struct iio_dev *indio_dev) > { > struct nxp_sar_adc *info = iio_priv(indio_dev); > - struct dma_slave_config config; > + struct dma_slave_config config = {}; IIO style is to have space between braces. Wait and see if Jonathan asks for a new version first though before sending one for trivial changes like that. > struct dma_async_tx_descriptor *desc; > int ret; > Reviewed-by: David Lechner