From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: Jarkko Sakkinen <jarkko@kernel.org>, Tadeusz Struk <tstruk@gmail.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] tpm: Fix error handling in async work
Date: Wed, 12 Jan 2022 10:47:29 -0800 [thread overview]
Message-ID: <3c2eeee7-0d3e-8000-67ad-3054f229cbe0@linaro.org> (raw)
In-Reply-To: <Yd8fY/wixkXhXEFH@iki.fi>
On 1/12/22 10:35, Jarkko Sakkinen wrote:
> These look good to me! Thank you. I'm in process of compiling a test
> kernel.
Thanks Jarkko,
You can run the new test before and after applying the change and see
how it behaves. Also just noticed a mistake in the comment, sorry but
it was quite late when I sent it.
+ /*
+ * If ret is > 0 then tpm_dev_transmit returned the size of the
+ * response. If ret is < 0 then tpm_dev_transmit failed and
+ * returned a return code.
+ */
In the above could you please replace:
s/returned a return code/returned an error code/
before applying the patch. I would appreciate that.
--
Thanks,
Tadeusz
next prev parent reply other threads:[~2022-01-12 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 5:52 Tadeusz Struk
2022-01-11 5:52 ` [PATCH v2 2/2] selftests: tpm: add async space test with noneexisting handle Tadeusz Struk
2022-01-12 18:35 ` [PATCH v3 1/2] tpm: Fix error handling in async work Jarkko Sakkinen
2022-01-12 18:47 ` Tadeusz Struk [this message]
2022-01-14 21:07 ` Jarkko Sakkinen
2022-01-14 21:12 ` Jarkko Sakkinen
2022-01-16 1:22 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c2eeee7-0d3e-8000-67ad-3054f229cbe0@linaro.org \
--to=tadeusz.struk@linaro.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tstruk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®