From: Andrew Lunn <andrew@lunn.ch>
To: "Ng, Boon Khai" <boon.khai.ng@intel.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Ang, Tien Sung" <tien.sung.ang@intel.com>,
"G Thomas, Rohan" <rohan.g.thomas@intel.com>,
"Looi, Hong Aun" <hong.aun.looi@intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Tham, Mun Yew" <mun.yew.tham@intel.com>
Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
Date: Mon, 10 Jun 2024 14:30:38 +0200 [thread overview]
Message-ID: <3c32c9b9-be77-41c8-97f7-371bd6f8fa16@lunn.ch> (raw)
In-Reply-To: <DM8PR11MB5751CD3D8EF4DF0B138DEB7FC1FB2@DM8PR11MB5751.namprd11.prod.outlook.com>
On Fri, Jun 07, 2024 at 04:09:37AM +0000, Ng, Boon Khai wrote:
> >
> > Do you have access to all the reference documentation for the IP driven in
> > dwmac4_core.c, dwxgmac2_core.c and stmmac_main.c? Is it just VLAN which
> > is the same, and everything else is different? Or are other blocks of the
> > hardware also identical and the code should be shared?
> > If VLAN is all that is identical, then stammc_vlan.c would make sense.
>
> Hi Andrew, I only have access to the document for
> dwmac4_core.c and dwxgmac2_core.c
O.K. So please do look at the VLAN code in other places and see if any
can be shared.
, I notice that in the linux mainline
> https://github.com/torvalds/linux/tree/master/drivers/net/ethernet/stmicro/
> stmmac
>
> it does have stmmac_est.c and stmmac_ptp.c to that support for both
> dwmac4 and dwxgmac2, with that I think it is suitable for introducing
> another file called stmmac_vlan?
Yes, stmmac_vlan.c is O.K.
Andrew
next prev parent reply other threads:[~2024-06-10 12:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 9:33 [Enable Designware XGMAC VLAN Stripping Feature v2 0/1] Boon Khai Ng
2024-05-27 9:33 ` [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping Boon Khai Ng
2024-05-27 10:40 ` [EXTERNAL] " Sunil Kovvuri Goutham
2024-05-27 13:28 ` Ng, Boon Khai
2024-05-27 15:36 ` Sunil Kovvuri Goutham
2024-05-28 2:06 ` Ng, Boon Khai
2024-05-28 7:18 ` Sunil Kovvuri Goutham
2024-05-28 7:21 ` Ng, Boon Khai
2024-05-28 12:21 ` Andrew Lunn
2024-05-30 2:16 ` Ng, Boon Khai
2024-05-27 19:00 ` Andrew Lunn
2024-05-28 2:29 ` Ng, Boon Khai
2024-05-28 13:02 ` Andrew Lunn
2024-05-30 5:48 ` Ng, Boon Khai
2024-05-30 8:25 ` Ilpo Järvinen
2024-06-04 6:05 ` Ng, Boon Khai
2024-06-04 19:26 ` Andrew Lunn
2024-06-07 4:09 ` Ng, Boon Khai
2024-06-10 12:30 ` Andrew Lunn [this message]
2024-06-11 7:01 ` Ng, Boon Khai
2024-06-11 7:06 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c32c9b9-be77-41c8-97f7-371bd6f8fa16@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boon.khai.ng@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hong.aun.looi@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mun.yew.tham@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rohan.g.thomas@intel.com \
--cc=tien.sung.ang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®