From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91184C433ED for ; Fri, 7 May 2021 07:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B8F96141B for ; Fri, 7 May 2021 07:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235489AbhEGHkH (ORCPT ); Fri, 7 May 2021 03:40:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21591 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235441AbhEGHjg (ORCPT ); Fri, 7 May 2021 03:39:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620373117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kBTtRECuFmb5m6BraCZy4PnJHFx6r0vEiT/8u2tqtfA=; b=SOYM0f/PIHFsGBhy/bL8/mmUDaFPz6itaZ2p5msGjChiW0e9o9pGDNleT7hx0MShANLoHb +rZYXO2inKRDAYYGn4XfuPjDuxI5rqsMJTtXfAsVE5KRM+2ZHXvxfX0D2VVkGF4xZ9NaWl 4p4QHeCSZXSg2V2Q/+d2R5c2ypWfp80= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-e3uRNAmpOAO2lTO7idJ0Fg-1; Fri, 07 May 2021 03:38:35 -0400 X-MC-Unique: e3uRNAmpOAO2lTO7idJ0Fg-1 Received: by mail-ed1-f70.google.com with SMTP id y15-20020aa7d50f0000b02903885ee98723so3983855edq.16 for ; Fri, 07 May 2021 00:38:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kBTtRECuFmb5m6BraCZy4PnJHFx6r0vEiT/8u2tqtfA=; b=sXs1vguPRaP29mIVcOktWeykM4Wh7AXOOoSXfN3YAiLVdnHzSJNn/oq/dTjtv6YC87 bsr/cf2ZT9Snm2UOiny2qMIimg4LByFusbTreZjxRX9OMXLuLLboLdNoCQdSnn8gSoYT pqAbGIUuthod8rj09c/Vtym5qLSILFNKAPFFI6sQzG/VqVVZgqb6aBTe2fpa1HgQASHd Pty/Z/XzsQVFoL785vu2MjCViHzK2AKGVfM3vboAcX6oVTiVucOze5VASCGUZRw722B4 WxhhvK4ZwADTZXT91/yRXth9r6hY1ts/lQ1n3D3z54GyuFIZPebj+F97lb+IdGIhlA/G rAAQ== X-Gm-Message-State: AOAM5315JW2bLKctYNL0/NLHbBp4hdq41rZL5fOHT5OLA37EkB9fzIf+ r8QkYfA+c44/vPyuneml0TwNr2oENyxnVn/Ui47zn+CCOsAk4yrOZtrrwibNRLfDsV7BVZpFKDh kOc50cCiovzBkkyDxJHNXkdRx X-Received: by 2002:a50:f113:: with SMTP id w19mr9452785edl.46.1620373114228; Fri, 07 May 2021 00:38:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZ/7NeEWb2qccaD0eVmBCiON3TssIhzQVJAFOZqHaDOCDkzBZRc3Wwakszx3Ihk+lqfismtw== X-Received: by 2002:a50:f113:: with SMTP id w19mr9452775edl.46.1620373114038; Fri, 07 May 2021 00:38:34 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id p14sm3448567eds.28.2021.05.07.00.38.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 May 2021 00:38:33 -0700 (PDT) Subject: Re: [PATCH 21/24] KVM: x86/mmu: Tweak auditing WARN for A/D bits to !PRESENT (was MMIO) To: Matteo Croce , Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon References: <20210225204749.1512652-1-seanjc@google.com> <20210225204749.1512652-22-seanjc@google.com> <20210507010518.26aa74f0@linux.microsoft.com> From: Paolo Bonzini Message-ID: <3c33b99f-7a8c-a897-9c3e-d5e71d1e2e25@redhat.com> Date: Fri, 7 May 2021 09:38:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210507010518.26aa74f0@linux.microsoft.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/05/21 01:05, Matteo Croce wrote: > On Thu, 25 Feb 2021 12:47:46 -0800 > Sean Christopherson wrote: > >> Tweak the MMU_WARN that guards against weirdness when querying A/D >> status to fire on a !MMU_PRESENT SPTE, as opposed to a MMIO SPTE. >> Attempting to query A/D status on any kind of !MMU_PRESENT SPTE, MMIO >> or otherwise, indicates a KVM bug. Case in point, several now-fixed >> bugs were identified by enabling this new WARN. >> >> Signed-off-by: Sean Christopherson > > You made the 1.000.000th commit, congrats! > > $ git log --oneline --reverse |sed '1000000!d' > 8f366ae6d8c5 KVM: x86/mmu: Tweak auditing WARN for A/D bits to !PRESENT (was MMIO) 🦀🦀🦀 Paolo