From: Christian Loehle <christian.loehle@arm.com>
To: Sudeep Holla <sudeep.holla@kernel.org>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] mailbox: pcc: Synchronize channel IRQ before unmapping shared memory
Date: Thu, 3 Sep 2026 10:51:28 +0100 [thread overview]
Message-ID: <3c369451-be95-4c64-9e52-b456f4aa8c42@arm.com> (raw)
In-Reply-To: <20260903-subtle-cornflower-guppy-b64a03@sudeepholla>
On 9/3/26 10:10, Sudeep Holla wrote:
> On Thu, Sep 03, 2026 at 10:03:38AM +0100, Sudeep Holla wrote:
>> On Fri, Aug 28, 2026 at 05:10:33PM +0100, Christian Loehle wrote:
>>> pcc_mbox_free_channel() unmaps the PCC shared-memory region before
>>> mbox_free_channel() invokes the controller shutdown callback. For
>>> interrupt-capable extended subspaces, an in-flight handler may
>>> consequently access the mapping after it has been invalidated.
>>>
>>> Release the mailbox channel first so its IRQ is disabled and synchronized
>>> before unmapping the shared-memory region. Serialize PCC channel
>>> acquisition and release across this sequence: once mbox_free_channel()
>>> makes the channel available, another client must not replace the
>>> shared-memory mapping until the old one has been unmapped.
>>>
>>
>> Breno Leitao has already posted the fix for the unmapping before freeing
>> the channel. You just need the mutex guards.
>>
>
> Failed to add the reference to it [1] earlier.
>
Thanks, I didn't see that.
I guess I'll wait until Breno's patch hits linux-next
or linus' tree and rebase?
next prev parent reply other threads:[~2026-09-03 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 16:10 Christian Loehle
2026-09-03 9:03 ` Sudeep Holla
2026-09-03 9:10 ` Sudeep Holla
2026-09-03 9:51 ` Christian Loehle [this message]
2026-09-03 10:23 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c369451-be95-4c64-9e52-b456f4aa8c42@arm.com \
--to=christian.loehle@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®