From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB3E9C76194 for ; Fri, 26 Jul 2019 02:47:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF9EE2238C for ; Fri, 26 Jul 2019 02:47:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726320AbfGZCrQ (ORCPT ); Thu, 25 Jul 2019 22:47:16 -0400 Received: from anchovy1.45ru.net.au ([203.30.46.145]:53621 "EHLO anchovy1.45ru.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbfGZCrQ (ORCPT ); Thu, 25 Jul 2019 22:47:16 -0400 Received: (qmail 20528 invoked by uid 5089); 26 Jul 2019 02:40:33 -0000 Received: by simscan 1.2.0 ppid: 20427, pid: 20428, t: 0.2285s scanners: regex: 1.2.0 attach: 1.2.0 clamav: 0.88.3/m:40/d:1950 spam: 3.1.4 Received: from unknown (HELO ?192.168.0.34?) (rtresidd@electromag.com.au@203.59.235.95) by anchovy1.45ru.net.au with ESMTPA; 26 Jul 2019 02:40:32 -0000 Subject: Re: [PATCH 1/1] power/supply/powersupply_sysfs: Add of_node name to uevent message if available To: David Lechner , sre@kernel.org, enric.balletbo@collabora.com, ncrews@chromium.org, andrew.smirnov@gmail.com, groeck@chromium.org, tglx@linutronix.de, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1564040858-24202-1-git-send-email-rtresidd@electromag.com.au> <9a10b934-e7f3-c95f-6250-8a857bdfa912@lechnology.com> From: Richard Tresidder Message-ID: <3c372ca4-373d-9c03-8636-a9f065eed577@electromag.com.au> Date: Fri, 26 Jul 2019 10:40:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <9a10b934-e7f3-c95f-6250-8a857bdfa912@lechnology.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-AU Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David   That it would be. I wasn't aware of that call. I'll give it a crack and send in a new version of the patch. Cheers   Richard Tresidder Richard Tresidder On 25/07/2019 10:08 pm, David Lechner wrote: > On 7/25/19 2:47 AM, Richard Tresidder wrote: >> If the of_node name of the supply is available from the devicetree >> binding >> then include it under the var POWER_SUPPLY_OF_NODE_NAME. >> This helps where a consistent name is known via the device tree binding >> but it is hard to identify based on the usual enumeration process. >> > > Would it be possible to use of_device_uevent() instead of introducing > a new > property? > > >