From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3A243BCD0A for ; Thu, 30 Jul 2026 07:01:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785394879; cv=none; b=QwspQXoMr+Z09qX0AgAwD3qHcCpmYG3HoFROvSJaYHdOYs9PoatAIsp0krXxQyrwriiSrBfV8yDYZ43vEG0xTr55a/HjtCYjdvhc2xrAJnDXjvYgwM4RULaoWXpaDB1fNOxCxLU7YhvSjfsnTJUrpOxOT/yKdtjmQJT71bYDw64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785394879; c=relaxed/simple; bh=39gxaTUicd4kbopGVNoNHyQS0A2gVUxiPyVGYWrTv4Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fxWB/tDEd1NCr5OdUC7J3YeImitX8/wbqs+XAafQhDOpVW8X8UafPWUGmA8in35hTMEQQi4FgGIco/xXx/MVhfBa1jLYAlKzssPKJ1TcsC0rgcWtV3ALji74egzoVblmfdKL0DtrHIwUorhm3PABsNn80NXFpd8DOHkW3VAVijE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AfV7cRIl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AfV7cRIl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3A181F000E9; Thu, 30 Jul 2026 07:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785394875; bh=lJzDcSa/Jz3k1AoOMXf/kp3xH6eQcq1mA+xDjqL2CuI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=AfV7cRIlGBEzJOmEgm5UqvFvgiVUFLFybVODk4nk6sqhhlGt903bj/OLsr9htBV4a kZRVSgp8wGvqvTh+a7dmmJ4KORfBwRf3qSN/LvbXENe6BE843E1EtmInMOKqoy+66Y 6EP9KDc1TLGUZnCXNw5bJI9+NAD6bzqDXPLKmy3uPhDx0FVFRh9rcsZU70fektfRX1 JoUdMf9iq2DiHhJw0ABaA/6mJcAHuo8Apml2s+9P6nHtraRMT4nkvVda+KuY+MxALk UpM2KNLOjxzmOX0uJLtzgT4R79qQk4HRXDsq7F7cv8dZUQU7cBwFBE27wjv432Ui1X 3WfDT2OdCa6Bw== Message-ID: <3c39b0e5-8265-4d39-ab39-196ccf560a05@kernel.org> Date: Thu, 30 Jul 2026 09:01:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] powerpc/sstep: Fix compilation on 32-bit PowerPC To: Link Mauve Cc: Madhavan Srinivasan , techflashYT , Ash Logan , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Michael Ellerman , Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20260730065007.964703-1-linkmauve@linkmauve.fr> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260730065007.964703-1-linkmauve@linkmauve.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 30/07/2026 à 08:50, Link Mauve a écrit : > Two local variables were only set but never read on 32-bit PowerPC, > which causes an error during compilation with W=1. > > This series first makes the 64-bit guards consistent by converting all > uses of __powerpc64__ to use CONFIG_PPC64 instead, and then guard the > two variables rc and suffix behind CONFIG_PPC64 checks. > For the two patches, Reviewed-by: Christophe Leroy (CS GROUP) > Link Mauve (2): > powerpc/sstep: Consistently use one define to check arch bit width > powerpc/sstep: Don’t define variables we won’t be using > > arch/powerpc/lib/sstep.c | 111 ++++++++++++++++++++------------------- > 1 file changed, 58 insertions(+), 53 deletions(-) > > Changes since v1: > - Link to v1: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinuxppc-dev%2Famrpdv0g__ELifId%40desktop%2FT%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C69210bfbc364426c4ce108deee06d0f2%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C639209910199709261%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=%2B%2BdoT%2FTkFxUUy63ED%2B5Kb5dfCSI8hQpjWGfpndI%2Fn0c%3D&reserved=0 > - Switch from __powerpc64__ to CONFIG_PPC64, as it is the preferred > check. > - Document that the build error was only occurring with W=1. > - Declare both variables on the same line. > > base-commit: 78bc8af4affb9a732504eb22eeac7d1e50883853