From: Kamel Bouhara <kamel.bouhara@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-arm-kernel@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: at91: Document Kizbox2 boards binding
Date: Wed, 30 Oct 2019 11:05:37 +0100 [thread overview]
Message-ID: <3c3b1763-5185-34b6-8f68-bbc153eb916f@bootlin.com> (raw)
In-Reply-To: <20191029014949.GA22009@bogus>
On 29/10/2019 02:49, Rob Herring wrote:
> On Thu, Oct 17, 2019 at 10:54:04AM +0200, Kamel Bouhara wrote:
>> Document devicetree's bindings for the SAMA5D31 Kizbox2 boards of
>> Overkiz SAS.
>>
>> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
>> ---
>> .../devicetree/bindings/arm/atmel-at91.yaml | 35 +++++++++++++++++++
>> 1 file changed, 35 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> index c0869cb860f3..7636bf7c2382 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> @@ -80,6 +80,41 @@ properties:
>> - const: atmel,sama5d3
>> - const: atmel,sama5
>>
>> + - description: Overkiz kizbox2 board without antenna
>> + items:
>> + - const: overkiz,kizbox2-0
>> + - const: atmel,sama5d31
>> + - const: atmel,sama5d3
>> + - const: atmel,sama5
>> +
>> + - description: Overkiz kizbox2 board with one head
>> + items:
>> + - const: overkiz,kizbox2-1
>> + - const: atmel,sama5d31
>> + - const: atmel,sama5d3
>> + - const: atmel,sama5
>> +
>> + - description: Overkiz kizbox2 board with two heads
>> + items:
>> + - const: overkiz,kizbox2-2
>> + - const: atmel,sama5d31
>> + - const: atmel,sama5d3
>> + - const: atmel,sama5
>> +
>> + - description: Overkiz kizbox2 board with three heads
>> + items:
>> + - const: overkiz,kizbox2-3
>> + - const: atmel,sama5d31
>> + - const: atmel,sama5d3
>> + - const: atmel,sama5
>> +
>> + - description: Overkiz kizbox2 board Rev2 with two heads
>> + items:
>> + - const: overkiz,kizbox2-rev2
>> + - const: atmel,sama5d31
>> + - const: atmel,sama5d3
>> + - const: atmel,sama5
>
> These can all be made a single items list with the 1st entry being an
> enum of all the boards. The board description can be a comment.
>
> Rob
>
Yes agree, actually it's already done in v2, by the way thanks for the
review.
--
Kamel Bouhara, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-30 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 8:54 [PATCH 0/2] Add a Kizbox2 dtsi and documentation Kamel Bouhara
2019-10-17 8:54 ` [PATCH 1/2] dt-bindings: arm: at91: Document Kizbox2 boards binding Kamel Bouhara
2019-10-29 1:49 ` Rob Herring
2019-10-30 10:05 ` Kamel Bouhara [this message]
2019-10-17 8:54 ` [PATCH 2/2] ARM: dts: at91: add a common kizbox2 dtsi file Kamel Bouhara
2019-10-17 9:04 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c3b1763-5185-34b6-8f68-bbc153eb916f@bootlin.com \
--to=kamel.bouhara@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®