From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933123AbdEVUYq (ORCPT ); Mon, 22 May 2017 16:24:46 -0400 Received: from mout.web.de ([212.227.15.3]:61354 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbdEVUYl (ORCPT ); Mon, 22 May 2017 16:24:41 -0400 To: linux-nfs@vger.kernel.org, netdev@vger.kernel.org, Anna Schumaker , Chuck Lever , "David S. Miller" , "J. Bruce Fields" , Jeff Layton , Trond Myklebust Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] xprtrdma: Delete an error message for a failed memory allocation in xprt_rdma_bc_setup() Message-ID: <3c3f0067-1438-129c-d921-e2c056d5776b@users.sourceforge.net> Date: Mon, 22 May 2017 22:24:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:rXvgTr1WBUj8uzjd7bJDJEAyIpQi4DxRAn7NHZXV/i1QWt/Fv0r 3rrUG9bdSooDAGu81t0XLClXvOfAHl3DJFZGA+VZW2++7nLyvhs/KSlmFoz0nvs35tAt1rL mfuL3lq1tmJiaf2lC/UjTNWyQum+Fo2TR4AMrXDvTmVANoTrKH7JLztK6G4JAVsmE/mowGn mb6Hti4awFHYGKrNkYE/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:o1n2RThsSVI=:5Sl944rnXgxF/lNXOiX8SM UK0mTKB8FNrOoihn24TzhI6yfAMrLziWrK1CyYkLP4ubpSn5jIblJcB4oJJ/3DTJZQCbgsTJh fCF3BPEXgd+w+0Yxb5UU6TjEeGwg4t/iGdC9tnh0fDy35APL/s6EKW4YfqkEIiMKBgNPZeQoM W2BoqCN4MeXvq1+VSyKCYh7In3XhMaIgHcZH0WzfnsRRYDbrU2UDmwoknNTbVovFQ/Kj07ZvR zAW1j5kxJZuulQTE05S/v36tmfvpEc6ciZMfeQBKa4BCEa+9YmRq4JqR387D7eQj8ThPx2aIo 19ZoXcbrJioxrDlR9OF/D6e7MmVxQ2rpQfMnOXTdxPh3mp9J1w1jag615UPgB/ng07YlDn7K9 XdMGowsWjw1N4rzk0EwrtIU3m4DxW92AG2f6P2Rds1gEJVqmFypGPr01gJis2gKAtwvoIk4Pt PDB6/3SK4lCjq+04JAQQFR+2ktcpnviWwXjOAERCt5dT3ICQt2hz7i2rl7Xx5jA8c+hS1jPXq GqPDwwGxO5CwqojdQQdzAy7Zljqo+7ocigx/+wcx6sgV8ZapgNKjfY7unamlUE2ztbHMWiYDG EE0ZXE8PHMpSRwTDWXRvt189EGJtrsRkR8AyQF/1OWONXsD6k/pZguRUC2YkZM0MqgtYDsTeR 3NgdvAqAN3YaLwU3csCktmDafZ4/SRdXTdnse50ubHSq0UvplnVlNaIjywhrcn9YOGW3E2mWn 29Tul+XSWF9Vvzi9aJfgWZnG3vCpxQ8P6rQ2ZoT/r+DMkpQTQw1mLOTU/MMwRtQW+H36ahVHW 5y0Mk20 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 22 May 2017 22:18:28 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- net/sunrpc/xprtrdma/backchannel.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/sunrpc/xprtrdma/backchannel.c b/net/sunrpc/xprtrdma/backchannel.c index 24fedd4b117e..03f6b5840764 100644 --- a/net/sunrpc/xprtrdma/backchannel.c +++ b/net/sunrpc/xprtrdma/backchannel.c @@ -119,11 +119,9 @@ int xprt_rdma_bc_setup(struct rpc_xprt *xprt, unsigned int reqs) for (i = 0; i < (reqs << 1); i++) { rqst = kzalloc(sizeof(*rqst), GFP_KERNEL); - if (!rqst) { - pr_err("RPC: %s: Failed to create bc rpc_rqst\n", - __func__); + if (!rqst) goto out_free; - } + dprintk("RPC: %s: new rqst %p\n", __func__, rqst); rqst->rq_xprt = &r_xprt->rx_xprt; -- 2.13.0