From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 388A3C433EF for ; Mon, 6 Jun 2022 02:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352257AbiFFCsO (ORCPT ); Sun, 5 Jun 2022 22:48:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345740AbiFFCsJ (ORCPT ); Sun, 5 Jun 2022 22:48:09 -0400 Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58E14165A4 for ; Sun, 5 Jun 2022 19:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1654483688; x=1686019688; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=D/wS6F2qtObb/FfuG5OxzP+ia1M5T+oSNe0EBUl49xg=; b=ZHTpxQL7ZPyUobx32bcBWnw83ZTK8cM3WpzJkquzm4UwXygPcyWqlMvM Y3k+1e3dKe0a3O6xhm8mHaZgbTmWc7GtY26PNOvXjKTYRuXEK6v2Rl1dG ltg2YjnZqJf+zloDZWjdNCGN8ca9rPjFInwO1gJTEXdG6AjkXLOZOhZ9l 8uZiqIMSgEc/HKqZ/w4iLQlfzGlfKkq7As8UXwEKP1wX1ie31YxW1Ob/u QKGKHQEjp7j5A91D6vPkSmpGXSd6P+r/rtEopU7BayOcrmbW1vPJnRVt0 55WOJDbO8AycG7Zf3VFl65UHjJFT+x8BJsuwNhEMIV+EIcyWp21rI478W g==; X-IronPort-AV: E=Sophos;i="5.91,280,1647273600"; d="scan'208";a="203119277" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 06 Jun 2022 10:48:07 +0800 IronPort-SDR: p8X5P6/vrzD/wkZt7OE4gVwxVGk7bJbvfyasImzscs/sGmHCFsmOhZd6ea7OlRpuF0KC6trBJG 0UAhcHr05Xh2PS7w89Mb/MzqmGcKQwt+7fObt/Tnfsyj+dcaIEJuj+VnBhcT7XPEK786Hszofc o9SwhRx3EEvTE34PRgJUdhQ+7nWUx76zbLszMIahLcyYO5QKxeY2+qolgmTwYLdQrHtzrV3PGg WNcdusjT+XO+S1pB3FtgfqF2l+GAZoy/poETnvrrl8Den4mSvf2/g+gFFa0YtUTKV25S8oMnuO vHHCgq9tSK5LKk4xgS9JtOOh Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jun 2022 19:11:27 -0700 IronPort-SDR: ICLbCZkJcU60jBB7e8B4qWOhc3cxlgVU6kxS1ZQRVTnO28UJg9rEIUQLD9nRthghjjwzVvAvA2 MI1bAghF4NiJn2w7WjP0rAtxDSP4RXFqEeCeVf02vKzxyaq4v2nB27dMk7Y1z0O9snGm4zL6Xu BUBO4uoLHZfuZXf/AopveY1mcRJJ4OxTrv6j6e4iZZIVXqxCZY+gQvKapmoqyirEMfZRyKcNTD 00j5udsTAxCvZcGoxtnpKL78kF3QOOQ/TlOciGSh46fsu2bDJ5+lSPfndChoHAIcj2djtOyFg3 +qs= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jun 2022 19:48:07 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4LGdFy2qvSz1Rwrw for ; Sun, 5 Jun 2022 19:48:06 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1654483685; x=1657075686; bh=D/wS6F2qtObb/FfuG5OxzP+ia1M5T+oSNe0 EBUl49xg=; b=d3dlbZMa6gaY3hULhIWoEKv6PVGRqRPMuhOz0C2c2KhqPDJM6yr 7LZI1PPTTX/14vzTEcmERaWpNWrjm/dclvcOVvQo98bYDCeEIH5fVWRAwS8HIjzD AT2uy8O9hWtwGGNzTd5GPvps3u2Q9VCbVKQAjizuCbGfdObJChsS5siq+/1hAbzU 65yTiuBF0gVI1nXbmFB3KVOsto+2WXaodQlAZpVMdS+bBZ2scyPWZswunlT3Nw01 ly94Vvpkf7LLdV9UURUrqdKsHT4AkgnPQZ2oBjQrmeX2Qj30sYcktr+9HYzt+Xft m2j031FcpSh5iHLlzEPPmeLUQ1eLoDqElHQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id nmd3wcyeblr0 for ; Sun, 5 Jun 2022 19:48:05 -0700 (PDT) Received: from [10.225.163.72] (unknown [10.225.163.72]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4LGdFt50L7z1Rvlc; Sun, 5 Jun 2022 19:48:02 -0700 (PDT) Message-ID: <3c400db6-d251-c4bd-b019-b9dc1d807212@opensource.wdc.com> Date: Mon, 6 Jun 2022 11:48:01 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RESEND PATCH] scsi: ufs: sysfs: support writing boot_lun attr Content-Language: en-US To: Bart Van Assche , Avri Altman , Caleb Connolly , "a5b6@riseup.net" , Alim Akhtar , "James E . J . Bottomley" , "Martin K . Petersen" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "~postmarketos/upstreaming@lists.sr.ht" <~postmarketos/upstreaming@lists.sr.ht>, "phone-devel@vger.kernel.org" References: <20220525164013.93748-1-a5b6@riseup.net> <8d25171a-5d86-9acc-0f94-1a3c6efdb360@riseup.net> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/5/22 12:55, Bart Van Assche wrote: > On 6/1/22 10:05, Avri Altman wrote: >> As a design rule, sysfs attribute files should not be used to make >> persistent modifications to a device configuration. This rule applies >> to all subsystems and ufs is no different. > > Hmm ... where does that rule come from? I can't find it in > Documentation/admin-guide/sysfs-rules.rst. Did I perhaps overlook something? I am not aware of any writable sysfs attribute file that can be used to make persistent device configuration changes, at least in storage area. I know of plenty that do change a device setting, but without saving this setting to maintain it across power cycles. Do you know of any such attribute ? I was under the impression that sysfs should not be used to persistently reconfigure a device... -- Damien Le Moal Western Digital Research