Re: [PATCH net-next v4 7/7] net: axienet: Split into MAC and MDIO drivers

[Sean Anderson <sean.anderson@linux.dev>]

On 8/5/25 17:40, Andrew Lunn wrote:
>> Fixes: 1a02556086fc ("net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode")
> 
> If this is for net-next, please don't have a Fixes: tag.

This is a fix. But as explained in the cover letter this is quite an
involved fix for an uncommon bug. I can target net if you like.

>>  struct axienet_common {
>>  	struct platform_device *pdev;
>> +	struct auxiliary_device mac;
>>  
>>  	struct clk *axi_clk;
>>  
>>  	struct mutex reset_lock;
>> -	struct mii_bus *mii_bus;
>> +	struct auxiliary_device mii_bus;
> 
> Keeping the name mii_bus for something which is not an struct mii_bus
> is going to cause confusion. Please give it a different name.

Like mdio?

> This is another patch which needs splitting up.

I don't think it can be split up in any major way. The whole conversion
of the MAC/MDIO portions of the driver has to be done at the same time
as the parent driver is converted to use them.

--Sean