From: Aniket Limaye <a-limaye@ti.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Keerthy <j-keerthy@ti.com>, Linus Walleij <linusw@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <vigneshr@ti.com>,
<u-kumar1@ti.com>, <nm@ti.com>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: gpio: gpio-davinci: Add the tda54 support
Date: Fri, 16 Oct 2026 10:14:55 +0530 [thread overview]
Message-ID: <3c443e92-f552-4e04-b408-bd3a6cfbf4c6@ti.com> (raw)
In-Reply-To: <CAMRc=MezO+9L9mepev-ALuk4qjqTOPTGj+odn-8=MbN_9osVzQ@mail.gmail.com>
Hi Bartosz,
On 28/09/26 17:58, Bartosz Golaszewski wrote:
> On Wed, 23 Sep 2026 14:56:44 +0200, Aniket Limaye <a-limaye@ti.com> said:
>> New version of GPIO IP used in TDA54 SoCs adds support for level-triggered
>> interrupts via extended registers.
>> Add the device binding for ti,tda54-gpio.
>>
>
> Nit: Does the new feature really matter for the binding if it doesn't warrant
> any changes in properties?
>
> Bart
>
I have sent v2 with no changes, sorry I missed this comment.
https://lore.kernel.org/all/20261016-upstream-tda54-gpio-v2-0-5c4f8b10cdbc@ti.com/
How would you like me to add the extended registers/level-triggered
interrupts in dt-bindings? The compatible doesn't really need any new
properties, but does tell the driver that extended register sets for
level-triggered interrupts are supported by the IP.
Thanks,
Aniket
>> Signed-off-by: Aniket Limaye <a-limaye@ti.com>
>> ---
>> Documentation/devicetree/bindings/gpio/gpio-davinci.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
>> index 1434d08f8b74..02b6b9a436a6 100644
>> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
>> @@ -18,6 +18,7 @@ properties:
>> - ti,am654-gpio
>> - ti,j721e-gpio
>> - ti,am64-gpio
>> + - ti,tda54-gpio
>> - const: ti,keystone-gpio
>>
>> - items:
>>
>> --
>> 2.53.0
>>
>>
next prev parent reply other threads:[~2026-10-16 4:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 12:56 [PATCH 0/2] gpio: davinci: Add support for level-triggered interrupts Aniket Limaye
2026-09-23 12:56 ` [PATCH 1/2] dt-bindings: gpio: gpio-davinci: Add the tda54 support Aniket Limaye
2026-09-23 13:57 ` Krzysztof Kozlowski
2026-09-28 12:28 ` Bartosz Golaszewski
2026-10-16 4:44 ` Aniket Limaye [this message]
2026-09-23 12:56 ` [PATCH 2/2] gpio: davinci: Add level support via extended registers Aniket Limaye
2026-09-28 12:47 ` Bartosz Golaszewski
2026-10-16 4:50 ` Aniket Limaye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c443e92-f552-4e04-b408-bd3a6cfbf4c6@ti.com \
--to=a-limaye@ti.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®