From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 750B513E037 for ; Mon, 10 Jun 2024 15:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718032899; cv=none; b=ojyD+gBQQOdmYPhyAIGyzavBGKqFj8t6S7Z/KdauCx9s8b6QlmSknuv5Kr/0kR+uRLGxyxc0TDvG6SZV5w9ce8u2ZVdwhOTFWja80USdT14bcUCL/nuNeUhJWhNAvwei0F1fGrqKe9ReJuqU7Obi0hjdCAal/nh//TzNLpXxTKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718032899; c=relaxed/simple; bh=v3NbPhRj3TrXw1e5IiVzAtGnWpQEWYFv4aBS9pR5LRw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pHkAvJoUUX7eH2W93iHifDQx3j2npyvsbXDgkQGCIwDAPj5HHJfl/UUfVXggJdrln+LhRTFXFnIhgdgYjcNrsPH44zoenDntdsplnlnFF4A9h3dwqFi079SlHa9LSbEsbsPsliCf/8Gtmot5jtm/lb50oAazqXmG2UrZ/AjL2vc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jgn6xPU7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jgn6xPU7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0679BC2BBFC; Mon, 10 Jun 2024 15:21:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718032899; bh=v3NbPhRj3TrXw1e5IiVzAtGnWpQEWYFv4aBS9pR5LRw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=jgn6xPU7DI3mrZxO+uSPvNfAO3sUt+SXtFUPPcNAhGpbkZPmuNp0dU0nHjf9Tn52f n8/BtRRtQSEEwGn6WgCOfo+99pyUeoEoAlpw8Ao9dzK2vsICNc0EOMTlCO7XG6Eq3S xzFrCJl+0OuVSuLUaQTkIeqaV5w7kpoZxQR1xeEc4AkH8eZONroWq3cU7WIlpBpNME gwv0Mn6TH7EcjZgtkGa7TbO2Gp/Vsz40uOtbqke5F41eVM16Pv7DIw0nGFIBhCzUxg F0kw6BpNOrScb8gBylzLoppwkqQqG7tinzv5gXH2E58epsfypCZo8Pxhm1XcGpp9yZ CdEu1eXiJkp2A== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id AE4FCCE2373; Mon, 10 Jun 2024 08:21:38 -0700 (PDT) Date: Mon, 10 Jun 2024 08:21:38 -0700 From: "Paul E. McKenney" To: Jonas Oberhauser Cc: Alan Stern , parri.andrea@gmail.com, will@kernel.org, peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr, akiyks@gmail.com, dlustig@nvidia.com, joel@joelfernandes.org, urezki@gmail.com, quic_neeraju@quicinc.com, frederic@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 0/4] tools/memory-model: Define more of LKMM in tools/memory-model Message-ID: <3c46dba3-575a-4b4d-9ec8-bc06e96a9e40@paulmck-laptop> Reply-To: paulmck@kernel.org References: <20240604152922.495908-1-jonas.oberhauser@huaweicloud.com> <88c1ebc8-4805-4d1d-868a-889043899979@rowland.harvard.edu> <1aed7106-cb94-451e-93d1-53062e6f3639@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1aed7106-cb94-451e-93d1-53062e6f3639@huaweicloud.com> On Mon, Jun 10, 2024 at 10:04:26AM +0200, Jonas Oberhauser wrote: > > > Am 6/6/2024 um 6:37 PM schrieb Paul E. McKenney: > > On Wed, Jun 05, 2024 at 09:58:42PM +0200, Jonas Oberhauser wrote: > > > > > > > > > Am 6/4/2024 um 7:56 PM schrieb Alan Stern: > > > > On Tue, Jun 04, 2024 at 05:29:18PM +0200, Jonas Oberhauser wrote: > > > > > Currently, the effect of several tag on operations is defined only in > > > > > the herd7 tool's OCaml code as syntax transformations, while the effect > > > > > of all other tags is defined in tools/memory-model. > > > > > This asymmetry means that two seemingly analogous definitions in > > > > > tools/memory-model behave quite differently because the generated > > > > > representation is sometimes modified by hardcoded behavior in herd7. > > > > > > > > > > It also makes it hard to see that the behavior of the formalization > > > > > matches the intuition described in explanation.txt without delving into > > > > > the implementation of herd7. > > > > > > > > > > Furthermore, this hardcoded behavior is hard to maintain inside herd7 and > > > > > other tools implementing WMM, and has caused several bugs and confusions > > > > > with the tool maintainers, e.g.: > > > > > > > > > > https://github.com/MPI-SWS/genmc/issues/22 > > > > > https://github.com/herd/herdtools7/issues/384#issuecomment-1132859904 > > > > > https://github.com/hernanponcedeleon/Dat3M/issues/254 > > > > > > > > > > It also means that potential future extensions of LKMM with new tags may > > > > > not work without changing internals of the herd7 tool. > > > > > > > > > > In this patch series, we first emulate the effect of herd7 transformations > > > > > in tools/memory-model through explicit rules in .cat and .bell files that > > > > > reference the transformed tags. > > > > > These transformations do not have any immediate effect with the current > > > > > herd7 implementation, because they apply after the syntax transformations > > > > > have already modified those tags. > > > > > > > > > > In a second step, we then distinguish between syntactic tags (that are > > > > > placed by the programmer on operations, e.g., an 'ACQUIRE tag on both the > > > > > read and write of an xchg_acquire() operation) and sets of events (that > > > > > would be defined after the (emulated) transformations, e.g., an Acquire > > > > > set that includes only on the read of the xchg_acquire(), but "has been > > > > > removed" from the write). > > > > > > > > > > This second step is incompatible with the current herd7 implementation, > > > > > since herd7 uses hardcoded tag names to decide what to do with LKMM; > > > > > therefore, the newly introduced syntactic tags will be ignored or > > > > > processed incorrectly by herd7. > > > > > > > > The patches look good to me. > > > > > > > > Just to clarify: Your first step encompasses patches 1 - 3, and the > > > > second step is patch 4. The first three patches can be applied now, but > > > > the last one needs to wait until herd7 has been updated. Is this all > > > > correct? > > > > > > Exactly. > > > > Just to make sure that I am following along properly... My belief is > > that there will be a new version of this series. Please let me know if > > I am missing something. > > At least one :)) ;-) ;-) ;-) I will await a later version, then. Thanx, Paul