From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 376703B5F59 for ; Mon, 8 Jun 2026 08:40:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780908019; cv=none; b=tcUk6AUrV4jXSaPKsoZUx9FHwPN9uPF+J7A1eXJFMEXp/9aHbpuLpL6itwqWBdIh27tvw3uSQQufzKlwu7pY+EiVXqfkvLGN8Wub0CkXeTFsptORM7/ve3it7TX7rA3RR3tozXwPB3OT9oPxInLjoBPlj+WpXZjNT0OTJaFpHnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780908019; c=relaxed/simple; bh=CCqjoUNUurzYE4twri0CPtkeKv57rqlJVdiWTN8T65w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fQwe7gYBh85W9wBiwVRDYQetSZSSh/033Of+0Xh4O8gBp8q8HQWhxAdO6fKBT2fqNcfABQR2AE/Hy0FTVu9xzm9L05jMdh71m6OzCxdyj0jt032V5y7n0KLlqNMzuclMuQy3QWi+7Wu85whyRJsojArE/Rfvxym4nv+9SO8n3Ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dENg5k3K; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DJTQVPsP; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dENg5k3K"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DJTQVPsP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780908017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vnDpUYDWGGzhd8LJgVzrd2lW64WfRqjlcwd6dZFOBgQ=; b=dENg5k3Kco/IxvFzlgNQNrruHfCEIKy4CByPCP1tE+7TeHklVbBp3Eduhxva04lNDHy5xF 5QiHuw4hwPM1jrEgAxnALL9uTvMkf9P3wXMOMzlpRKayPfERJ6hWEwXWKmLzsVstKhoMRO V2FoVAoGQIUMqVl8ILs08dihZiJ6igQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-x3H7OVYXO8-OikezdVHZag-1; Mon, 08 Jun 2026 04:40:16 -0400 X-MC-Unique: x3H7OVYXO8-OikezdVHZag-1 X-Mimecast-MFC-AGG-ID: x3H7OVYXO8-OikezdVHZag_1780908015 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-45efa2f7009so2519844f8f.3 for ; Mon, 08 Jun 2026 01:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780908015; x=1781512815; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vnDpUYDWGGzhd8LJgVzrd2lW64WfRqjlcwd6dZFOBgQ=; b=DJTQVPsPZV4zkS8PNl6PrJnNGxDxgLy3IoOgjxY2c93Ph17QqGqAHnzf0cL0wPKlar /9FNut8Wf9a50FW7q3dbIArMFux2vYfs/VD7YvlA1yaUz7Hm+Ei9LZ7BCYY3kYWGx706 ARFqqAdejh3W7sXDS2zJTzAcnieHWqFDgYHZllrV8ImSnKp+BTX6IThvWlplW7aqEChy o+lTyagl1YgOgS1H1Wh7YtUhiRdUF2iMHPWgc1P5CMqUHp+cdz3v46uspJraLoCW/WFo VExpBU5RLQLG15xQaX1WZ4zy76UPOwia9VnFsADB0IDG87nIPQ94pN0BYXL+nzNaWdbE cLOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780908015; x=1781512815; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vnDpUYDWGGzhd8LJgVzrd2lW64WfRqjlcwd6dZFOBgQ=; b=k6CkGOYYed/ZvloOEg4KP8K+l8LZtZX9TgefeQnbw+oH0gDSXnR41Yoi3dp0oxnI5+ UrVV8lSpMM1Mccm1Krau3aAIPYL0bfYj6FheB1b7PfiEnTam3nM8nlD5oAFQJDKPzhZb OWkVMF6jUvhyU8dfM2ORLqH6eVXVSohfwT0+MfgsQj1iPmdPcU0Dw6PDi7moxqNKWAc0 EraSIGYxVLJc6OogTHnKblG/ZI/itJLR3Q8GrVtgQ3XegjqS1C1w2eWndDwEVPVD5iT5 3bl8ZgjqFnIL+yfaNk0tgd0mnE/aupb4DQOw846VMfA2JP7l8Hw7zFo4CJBMjljeCaGD YNqA== X-Gm-Message-State: AOJu0YyouWUgHZTuC3XtVXqWLLk8csL92H+UPu4vuRt0ugjU0pck8VIM xIc8xnsglcrw6UwJ/lI1fv7WvN0ABa+zscH+PecFzI1MFWUewpvPV9fp6e3nh3oZpTceSZNrIlZ bJppJopQv34RDjsX0LLom08P6RHPnJq5oJGm5Upaj6Upcqi3NKHA2cyP6/iiQ7kEOwvb2kM0lws Omdhg3vYQhC6WMq+cdyng2/33Y8mKyrs1wNf8hUQApWYk= X-Gm-Gg: Acq92OGPUgSzPv51B3vtQwPOr+0gW7HQGA6Hgp8x6rCaK2Ug4BtPYms1s54cy9OZgAs 8G2T310BjMSMdtyO1M0ZI8iUmb5GsLX4jL1r6ZN1fY+TWhIGCxTxUORh01gENr71zrsZ2HEJCWe Sxwl+77IoBYlYN3jraNVyfFtldlwBfFY1cCJKTsZUZjgM6ykivTiM3h5Y8QZ+G6j3WI1cywFIDf xznnMDqjB0NC16Mc5u39pY/FtovO6lfLBBL59AQYwqeG1qgkAIJoBgnrPOC9oOguT2vWV5RwgcC zyL+udpdACk1zUzlpLSeejQ0JsvrA5WYQkvQ0v9pFRM1/mM6b/2F92UmMl/Uul7USVgCazcT0Sh oJmqr8Hc6Fvuzc7A05mX2Cbg= X-Received: by 2002:adf:f2cf:0:b0:460:e00:1213 with SMTP id ffacd0b85a97d-46030502efamr17987095f8f.23.1780908014416; Mon, 08 Jun 2026 01:40:14 -0700 (PDT) X-Received: by 2002:adf:f2cf:0:b0:460:e00:1213 with SMTP id ffacd0b85a97d-46030502efamr17987021f8f.23.1780908013858; Mon, 08 Jun 2026 01:40:13 -0700 (PDT) Received: from redhat.com ([31.152.37.159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f34413csm49706045f8f.21.2026.06.08.01.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 01:40:13 -0700 (PDT) Date: Mon, 8 Jun 2026 04:40:05 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v10 32/37] virtio_balloon: disable indirect descriptors Message-ID: <3c48b12a88c03c9cf9ac2c7abaffbb8aedd470d9.1780906288.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.51.2.2891.g4157995a80.dirty X-Mutt-Fcc: =sent A follow-up patch (DEVICE_INIT_ON_INFLATE) adds an inbuf (bitmap) alongside the outbuf (pfns), making total_sg=2. With INDIRECT_DESC negotiated, virtqueue_use_indirect() triggers for total_sg > 1. Balloon never needs more than 2 entries and virtqueue sizes are 128+, so indirect descriptors are unnecessary. Disabling them avoids a GFP_KERNEL allocation inside virtqueue_add_sgs when VIRTIO_RING_F_INDIRECT_DESC is negotiated. This allocation could trigger OOM reclaim while balloon_lock is held, leading to a deadlock: OOM notifier -> leak_balloon -> balloon_lock. With single-buffer submissions (previous patch) and no indirect descriptors, virtqueue_add never allocates memory. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 --- drivers/virtio/virtio_balloon.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 53b4a3984e7d..1fa1c7fa285f 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -7,6 +7,7 @@ */ #include +#include #include #include #include @@ -1175,6 +1176,13 @@ static int virtballoon_validate(struct virtio_device *vdev) else if (!virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_REPORTING); + /* + * Balloon submits 1-2 sg entries max per buffer, virtqueue + * sizes are 128+. Disable indirect descriptors to avoid + * GFP_KERNEL allocation in virtqueue_add under balloon_lock, + * which could deadlock via OOM -> oom_notify -> leak_balloon. + */ + __virtio_clear_bit(vdev, VIRTIO_RING_F_INDIRECT_DESC); __virtio_clear_bit(vdev, VIRTIO_F_ACCESS_PLATFORM); return 0; } -- MST