From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 758DB44CF55 for ; Fri, 27 Feb 2026 16:01:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772208092; cv=none; b=FpyTB6DxNfG1JFq0B5lzpoEJD4x5K035vs2mCxZeAY3VFmuCEqtagQzzNvc7laJwA8BZFbpiKhV+1hajJEFV7fiA1l+X0ZSzlfbVVFmd+I/5/hj7SQsUCPnfTbHOtbC3AUwUoj4EWmZpIAW/aH4hWX1tu+R9Bm0nE1Oe825C2lo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772208092; c=relaxed/simple; bh=mqX00e9QqpKUg+RRh3jJF+qJ43RITeuZ7hqJgrXs+QM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QigekGTZE3J3O+MXWpY5XDk1R0nS43VUOVcJMldUjmYcp4KFPQDuhzlI5f0Q0j+hnW7X7YWnjidcB/MKxd+alJpHXL+QelAPMbG87IvIUSYjHQBGsnnUH638A1eT7uu7YKUSFM+fXD99+GcyDQByLzhskDUfMEquAiebXkfCBvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=HLuzmuI2; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="HLuzmuI2" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7d4c3896e32so1164470a34.0 for ; Fri, 27 Feb 2026 08:01:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772208088; x=1772812888; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ELIM1XoC6sP2e7/ym7kBeZvkexkVxufY/yi6CFO2Qxk=; b=HLuzmuI2HcGU+s266n+87i0T+0IZsffCHOodKrBHuiDs+mZNFQcv+qOhyv9GERLCQ1 3PE0SGDHO+RrFMTvgrrNZzXo4MYDgJyayb870mUIctYQV3ll537C3chUBIJwKkrpKKoT o52ihGqNLGxFb3AWdPgOG1Va977TGeldCE6pQfP8qx2sUzlakjaNuDf0+e6lda+GtWAR 4uHGmxsJBiFhEnfpA3PLiP4lvB32KzkPrE3eX2ltSj1d36SIt50uYyNmFKE40401uXis 4Q2m3h+FBN/CI3Jh7SYoEa+7Eluh9VAg279om0rV4xM/o7KJxFPtdQjZcbKhuOttliCe mbsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772208088; x=1772812888; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ELIM1XoC6sP2e7/ym7kBeZvkexkVxufY/yi6CFO2Qxk=; b=r/k/vuRrMo9HmloUgOGduc+geBp85n/rpP+ALHloj8tuYQHclcCsfSkVUGbCM/4Gde eDDXVfFpcD6Eg0r4k0qgU0iA+wsiCqpTC7xLwxnfBIYXhwHAqusHuDCy9EzioMA/ywwG 5AxumE+q2aYbNhRsiKrICNg9C5hIQIUlRd6GP2TduPYWdrt6KgT+28ZHqQHRPDz1gkPZ Q7rYE7rJyboehcskYirziweqxNV2wS4Kdt3Qznen9OwYQLieWZKMBSN1Z9qV90K3W42/ zKd9H/VtjWdwihcDhYHdyz5sKM1u1uoqMFC/HoSDBIbcWFgLVNigO0nX750jOn6/+V12 Zh0A== X-Forwarded-Encrypted: i=1; AJvYcCUv3DzfQ2EuXR2p0eR05eMcPeQsDV+bTzn7f3WAd6Bv2mt8DtqrQL8C4Hm2XQJfkGlPizC4zx+fisrEKBc=@vger.kernel.org X-Gm-Message-State: AOJu0YziCfDpTuqMcwWDO7CSnGHsNJxzEOCAg+8KlQ2XXbD3jXQ32tkD UJiTXy1gsaaa1ofGTWZ9oGwmm+uIQy7qtH4CdhAqmIKIjlcDoZI3/RbQ0GiVTmYwBak= X-Gm-Gg: ATEYQzxuyZiPQT9IpG5OsWeOjX45PBegdBrkx1X/6vehsO/PFbfoHC2HMKEAprlqICq pPnwiB5zm+rZ18oSRsruY3lJ/IQcnizZpcMRwMHqalP7g7zHGZoI3+RACj3HbO4tYHKNdla7xUN ScYsfE/Wal70T81/GsCmnDom9podGtu3nEpzrmBygHwrLHTn8tYrg7wF8GYgv+o20ePD29P5SaE qrnON6ahPFayO3JXmOQxkvE9eInte0CPyRMTcmOD3BwA3vxRppsEnrlpGA6sBx5/NiUxW9bZf+D LR8Iv+l4aQuD6QEk4mv+Ef4kZsXk0DsCp2m5iA9AD5uft4Wz51sf9dIyO8UnnXa3OQB/fmz1JF2 CTh+fqnrHwGPFcSjcb2w0xYrjeAeOXeOC059JcNAt2TZeP2DLKuEpHHGB70GX1DgsiRwMgboRzg M6V6DIZ+1xVgBERWkTFRNvpdTaDyz/5ort29nf3y/J0SAP5IhyQG5uUI5QkqnP1WVxX206U8gUp w== X-Received: by 2002:a05:6870:3412:b0:3ea:ff22:3dde with SMTP id 586e51a60fabf-41626ec9ae4mr1759503fac.24.1772208087776; Fri, 27 Feb 2026 08:01:27 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:876a:e36c:76c7:e6d4? ([2600:8803:e7e4:500:876a:e36c:76c7:e6d4]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4160d2c9fc2sm4979058fac.18.2026.02.27.08.01.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 08:01:27 -0800 (PST) Message-ID: <3c4964b1-9592-401b-a44b-22dace6cf81c@baylibre.com> Date: Fri, 27 Feb 2026 10:01:25 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] iio: filter: admv8818: Add missing error code To: Andy Shevchenko , Ethan Tidmore Cc: Antoniu Miclaus , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260227061424.1135505-1-ethantidmore06@gmail.com> <20260227061424.1135505-2-ethantidmore06@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/27/26 1:06 AM, Andy Shevchenko wrote: > On Fri, Feb 27, 2026 at 12:42:11AM -0600, Ethan Tidmore wrote: >> On Fri Feb 27, 2026 at 12:14 AM CST, Ethan Tidmore wrote: > > ... > >> Just realized I should have used -EIO for the error code. Will wait >> however on reviews before v2. > > Why -EIO? Is it used in the same situation in other cases in this driver? > I think EIO makes sense here. We are reading from a chip. And if the values we read aren't one of the expected values, the mostly likely reason is the chip is malfunctioning or noise on the wires.