From: Hugues FRUCHET <hugues.fruchet@st.com>
To: Loic PALLARDY <loic.pallardy@st.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"ohad@wizery.com" <ohad@wizery.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Cc: "linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@stlinux.com" <kernel@stlinux.com>,
Patrice CHOTARD <patrice.chotard@st.com>,
"peter.griffin@linaro.org" <peter.griffin@linaro.org>
Subject: Re: [PATCH v2 0/6] virtio_rpmsg: make rpmsg channel configurable
Date: Wed, 8 Feb 2017 10:21:24 +0000 [thread overview]
Message-ID: <3c4a43c2-92ac-88e2-6e50-395b51c33c54@st.com> (raw)
In-Reply-To: <1485867097-6960-1-git-send-email-loic.pallardy@st.com>
Acked-and-tested-by: Hugues Fruchet <hugues.fruchet@st.com>
Tested on B2260 ST Platform with st-delta video decoder V4L2 kernel
driver
(http://www.mail-archive.com/linux-media@vger.kernel.org/msg107644.html).
On 01/31/2017 01:51 PM, Loic Pallardy wrote:
> This goal of this series is to offer more flexibility for virtio_rpmsg
> communication link configuration.
>
> It should be possible to tune rpmsg buffer size per Rpmsg link, to provide
> selected configuration to coprocessor, to take into account coprocessor
> specificities like memory region.
>
> This series introduces an optional virtio rpmsg configuration structure, which
> will be managed as an extension of struct fw_rsc_vdev present in coprocessor firmware
> resource table.
> Structure access is possible thanks to virtio get and set API.
> This structure contains the different information to tune the link between the
> host and the coprocessor.
>
> Patch "rpmsg: virtio_rpmsg_bus: fix sg_set_buf() when addr is not a valid
> kernel address" has the same goal as Wendy's RFC [1]. I don't have tested
> Wendy's series with level driver buffer allocation.
>
> Last patch "rpmsg: virtio_rpmsg: set buffer configuration to virtio" has a
> dependency with remoteproc subdevice boot sequence as coprocessor resource
> table must be updated before coprocessor start. See [2]
>
> [1] http://www.spinics.net/lists/linux-remoteproc/msg00852.html
> [2] http://www.spinics.net/lists/linux-remoteproc/msg00826.html
>
> ---
> Changes from v1:
> - No more dependency with [2]. Coprocessor firmware should wait for first kick
> indicating virtio rpmsg link ready before accessing resource table information.
> - Correct issues reported by Suman
> - Fix warnings found by checkpatch with --strict option
>
>
> Loic Pallardy (6):
> rpmsg: virtio_rpmsg: set rpmsg_buf_size customizable
> rpmsg: virtio_rpmsg_bus: fix sg_set_buf() when addr is not a valid
> kernel address
> include: virtio_rpmsg: add virtio rpmsg configuration structure
> rpmsg: virtio_rpmsg: get buffer configuration from virtio
> rpmsg: virtio_rpmsg: don't allocate buffer if provided by low level
> driver
> rpmsg: virtio_rpmsg: set buffer configuration to virtio
>
> drivers/rpmsg/virtio_rpmsg_bus.c | 176 +++++++++++++++++++++++++++++++------
> include/linux/rpmsg/virtio_rpmsg.h | 32 +++++++
> 2 files changed, 179 insertions(+), 29 deletions(-)
> create mode 100644 include/linux/rpmsg/virtio_rpmsg.h
>
prev parent reply other threads:[~2017-02-08 10:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 12:51 Loic Pallardy
2017-01-31 12:51 ` [PATCH v2 1/6] rpmsg: virtio_rpmsg: set rpmsg_buf_size customizable Loic Pallardy
2017-01-31 12:51 ` [PATCH v2 2/6] rpmsg: virtio_rpmsg_bus: fix sg_set_buf() when addr is not a valid kernel address Loic Pallardy
2017-01-31 12:51 ` [PATCH v2 3/6] include: virtio_rpmsg: add virtio rpmsg configuration structure Loic Pallardy
2017-01-31 12:51 ` [PATCH v2 4/6] rpmsg: virtio_rpmsg: get buffer configuration from virtio Loic Pallardy
2017-01-31 12:51 ` [PATCH v2 5/6] rpmsg: virtio_rpmsg: don't allocate buffer if provided by low level driver Loic Pallardy
2017-01-31 18:29 ` kbuild test robot
2017-01-31 12:51 ` [PATCH v2 6/6] rpmsg: virtio_rpmsg: set buffer configuration to virtio Loic Pallardy
2017-02-08 10:21 ` Hugues FRUCHET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c4a43c2-92ac-88e2-6e50-395b51c33c54@st.com \
--to=hugues.fruchet@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=peter.griffin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®