From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F365B2248BA for ; Tue, 29 Apr 2025 13:01:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745931684; cv=none; b=AZ9cwQuirOeonCGkzS25nZ0Isn7MeVNKVMEur3WSYl+edj59CP9fjeK7GsSrimDyYz/Ds14aRu5+JXjJKYHzsT7+8UP032Tj779GoQHF6D7vFfcDZbwZivXrAiH5QF9WkmTlQIh42re8UpHh5Vim9x0ITyb79P9uhBPUCV2XdMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745931684; c=relaxed/simple; bh=DFeDFQIgqisFrRbTyxkaRmuV5afJwHFeG7TqQcoSyTU=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=IF37/DhQMDjts2ZJ1woPfDSal3VK6iYos/lmPJ8WXkt7lLfUsFO+wpBiBFlHNkCcTuARzDdr4cvrY9joK5C3AEwiYwSYqH2MPJKnCvq70wxWXnQm447MxAXPE7uxv4JJoqzFqQ5GHxHlowXi67k3Ed93+XjG2GwUHNi6pcsbHsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UL+EEVJp; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UL+EEVJp" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43d0782d787so36983505e9.0 for ; Tue, 29 Apr 2025 06:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745931679; x=1746536479; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=MONQIfm/Oa04J/4iy7mo5OMqJtr7l+XlLP0uVBN0U7E=; b=UL+EEVJpULaP5vT8KeWbx2RKvDMn0sc85NmKUEHoeUsw95lkgnFPHSZx0uh5z7EdAo aXnrwd+ohFp25coTNqHUdmFvErkXwHqz0A2j1HKLpzTRpMRKngXV7H7TIunY7f9/JEtc PpnFq0kJedyLwlKas9XCShI/mh1TRB84DUDwXNxsTkES5JESlFjPK4isxd5n/6ugGtsy E7an7MSyfVbpA0Ndv4B1mD31vOt6G/WUfEWkiF3RkmSzcR398IwNo9x2Z9SZBvIG1jAv 6LUSTmMIwac8vwid9GH8p9RhZUMNI905uOKWkzkpL+LCs8DT9xmcIy4pfyz7VegROUyM HxaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745931679; x=1746536479; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MONQIfm/Oa04J/4iy7mo5OMqJtr7l+XlLP0uVBN0U7E=; b=U0n9CRW9GIrjsCIZAWliO83XwHWQ2AzBMapkq13rFO/q7/kl++PWEpAYOcKfs4yEwd JAEpR1/gOCjtK8z5rTcmIN9Bw56cpUy83admO6EYYPec4QHecDMG18DqdFm+5s/DbK0X oOQ95kj2cHQC6hKl2h3G2aATx+WFyU0x3C7vXt06GxS6q5x3fu0YZRRf+7XmReumD8Qo l2VTRnCnu7YTLrFs6+YIkSUqvmod2a/DKjvuqHxPWMKpIIaJu3LdCJlWdfNcaGxC/nMT Or9Lm94+vFhXLUuHzFzQKS/23SWBJ8J8HXgilW8+SRT1ZVVRd6hHMtQbF3RcEdtZFR2J tVxQ== X-Forwarded-Encrypted: i=1; AJvYcCVMjjWl16ScmZFLCh422OPZNm34HwO8BV+J2RJQ5i4rTJTNcwoWJIaxeIT7VqTy3UUknYa8algEVMlTAoo=@vger.kernel.org X-Gm-Message-State: AOJu0YyYZtUIAbLqjq+wfYYoZYSIIWr/tF/lpJ75XYA4RmbySwEz2u7R fKAon0jFdopP1wsSih1gFXHjfMjdovhcqh0wk3oGKEbtyULbD6xbwuhirCuoscA= X-Gm-Gg: ASbGncvDKxM9TA8EQXb03vgMfX+j9hUCw38QB6O2+SRzTq4IB9A2G/tMq67Zi+Acwqr 35YHxU7OvA0bWNPoMlNWDgolChtxcNQC30Br4SG1fwDCSGFJr3cXM1wOdEfDEMhxSFLAUl/vCsK xqEQXxlSM4CYxKMhSyZeDjd+7t/IZqvvM0NdOpyJCARiUeb3LJuDl/3WcAiep9Hs7QF0ItL4ZI9 x4s4nlzz85Kl+Zk6GaCfsvm0CuAQPH1CnABQhXlM7gFMxF/GnO91OftisY3FBM+s5du810f/wDx OZgvWtdZ3bLeYI37TOxM6xXNRTz8c3HlrOxv6cJgmcCiIlx7vXQsQKK6nYmzS9zlJz5HlVZ12l6 0l62QA8WMAAdODgmP/A== X-Google-Smtp-Source: AGHT+IFzOm/zeLBXb8tq9k3CffyVspFovQWIpznGeeVBZrU7maNGW9UIaOh5zs9qS8Jytx7rDtlTQw== X-Received: by 2002:a05:6000:2a1:b0:3a0:89df:3b85 with SMTP id ffacd0b85a97d-3a089df3e89mr2974196f8f.38.1745931678644; Tue, 29 Apr 2025 06:01:18 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:7eea:fda1:4564:f556? ([2a01:e0a:3d9:2080:7eea:fda1:4564:f556]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a07a7c39a0sm10970372f8f.101.2025.04.29.06.01.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 06:01:18 -0700 (PDT) Message-ID: <3c4e3ed8-ceaf-45c7-a52c-dc7b8209418b@linaro.org> Date: Tue, 29 Apr 2025 15:01:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v4 00/11] Trusted Execution Environment (TEE) driver for Qualcomm TEE (QTEE) To: Amirreza Zarrabi , Jens Wiklander , Sumit Garg , Bjorn Andersson , Konrad Dybcio , Bartosz Golaszewski , Apurupa Pattapu , Kees Cook , "Gustavo A. R. Silva" , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-doc@vger.kernel.org, Sumit Garg References: <20250428-qcom-tee-using-tee-ss-without-mem-obj-v4-0-6a143640a6cb@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250428-qcom-tee-using-tee-ss-without-mem-obj-v4-0-6a143640a6cb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/04/2025 08:06, Amirreza Zarrabi wrote: > This patch series introduces a Trusted Execution Environment (TEE) > driver for Qualcomm TEE (QTEE). QTEE enables Trusted Applications (TAs) > and services to run securely. It uses an object-based interface, where > each service is an object with sets of operations. Clients can invoke > these operations on objects, which can generate results, including other > objects. For example, an object can load a TA and return another object > that represents the loaded TA, allowing access to its services. > > Kernel and userspace services are also available to QTEE through a > similar approach. QTEE makes callback requests that are converted into > object invocations. These objects can represent services within the > kernel or userspace process. > > Note: This patch series focuses on QTEE objects and userspace services. > > Linux already provides a TEE subsystem, which is described in [1]. The > tee subsystem provides a generic ioctl interface, TEE_IOC_INVOKE, which > can be used by userspace to talk to a TEE backend driver. We extend the > Linux TEE subsystem to understand object parameters and an ioctl call so > client can invoke objects in QTEE: > > - TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF_* > - TEE_IOC_OBJECT_INVOKE > > The existing ioctl calls TEE_IOC_SUPPL_RECV and TEE_IOC_SUPPL_SEND are > used for invoking services in the userspace process by QTEE. > > The TEE backend driver uses the QTEE Transport Message to communicate > with QTEE. Interactions through the object INVOKE interface are > translated into QTEE messages. Likewise, object invocations from QTEE > for userspace objects are converted into SEND/RECV ioctl calls to > supplicants. > > The details of QTEE Transport Message to communicate with QTEE is > available in [PATCH 11/11] Documentation: tee: Add Qualcomm TEE driver. > > You can run basic tests with following steps: > git clone https://github.com/quic/quic-teec.git > cd quic-teec > mkdir build > cmake .. -DCMAKE_TOOLCHAIN_FILE=CMakeToolchain.txt -DBUILD_UNITTEST=ON > > https://github.com/quic/quic-teec/blob/main/README.md lists dependencies > needed to build the above. > > This series has been tested for basic QTEE object invocations and > callback requests, including loading a TA and requesting services form > the TA. > > Tested platforms: sm8650-mtp > > [1] https://www.kernel.org/doc/Documentation/tee.txt > > Signed-off-by: Amirreza Zarrabi > > Changes in v4: > - Move teedev_ctx_get/put and tee_device_get/put to tee_core.h. > - Rename object to id in struct tee_ioctl_object_invoke_arg. > - Replace spinlock with mutex for qtee_objects_idr. > - Move qcomtee_object_get to qcomtee_user/memobj_param_to_object. > - More code cleanup following the comments. > - Cleanup documentations. > - Update MAINTAINERS file. > - Link to v3: https://lore.kernel.org/r/20250327-qcom-tee-using-tee-ss-without-mem-obj-v3-0-7f457073282d@oss.qualcomm.com > > Changes in v3: > - Export shm_bridge create/delete APIs. > - Enable support for QTEE memory objects. > - Update the memory management code to use the TEE subsystem for all > allocations using the pool. > - Move all driver states into the driver's main service struct. > - Add more documentations. > - Link to v2: https://lore.kernel.org/r/20250202-qcom-tee-using-tee-ss-without-mem-obj-v2-0-297eacd0d34f@quicinc.com > > Changes in v2: > - Clean up commit messages and comments. > - Use better names such as ubuf instead of membuf or QCOMTEE prefix > instead of QCOM_TEE, or names that are more consistent with other > TEE-backend drivers such as qcomtee_context_data instead of > qcom_tee_context. > - Drop the DTS patch and instantiate the device from the scm driver. > - Use a single structure for all driver's internal states. > - Drop srcu primitives and use the existing mutex for synchronization > between the supplicant and QTEE. > - Directly use tee_context to track the lifetime of qcomtee_context_data. > - Add close_context() to be called when the user closes the tee_context. > - Link to v1: https://lore.kernel.org/r/20241202-qcom-tee-using-tee-ss-without-mem-obj-v1-0-f502ef01e016@quicinc.com > > Changes in v1: > - It is a complete rewrite to utilize the TEE subsystem. > - Link to RFC: https://lore.kernel.org/all/20240702-qcom-tee-object-and-ioctls-v1-0-633c3ddf57ee@quicinc.com > > --- > Amirreza Zarrabi (11): > tee: allow a driver to allocate a tee_device without a pool > tee: add close_context to TEE driver operation > tee: add TEE_IOCTL_PARAM_ATTR_TYPE_UBUF > tee: add TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF > firmware: qcom: scm: add support for object invocation > firmware: qcom: scm: remove unused arguments to the shm_brige > firmware: qcom: tzmem: export shm_bridge create/delete > tee: add Qualcomm TEE driver > qcomtee: add primordial object > qcomtee: enable TEE_IOC_SHM_ALLOC ioctl > Documentation: tee: Add Qualcomm TEE driver > > Documentation/tee/index.rst | 1 + > Documentation/tee/qtee.rst | 150 ++++++ > MAINTAINERS | 8 + > drivers/firmware/qcom/qcom_scm.c | 132 ++++- > drivers/firmware/qcom/qcom_scm.h | 7 + > drivers/firmware/qcom/qcom_tzmem.c | 57 ++- > drivers/tee/Kconfig | 1 + > drivers/tee/Makefile | 1 + > drivers/tee/qcomtee/Kconfig | 10 + > drivers/tee/qcomtee/Makefile | 11 + > drivers/tee/qcomtee/async.c | 160 ++++++ > drivers/tee/qcomtee/call.c | 770 +++++++++++++++++++++++++++++ > drivers/tee/qcomtee/core.c | 815 +++++++++++++++++++++++++++++++ > drivers/tee/qcomtee/mem_obj.c | 172 +++++++ > drivers/tee/qcomtee/primordial_obj.c | 115 +++++ > drivers/tee/qcomtee/qcom_scm.c | 38 ++ > drivers/tee/qcomtee/qcomtee_msg.h | 239 +++++++++ > drivers/tee/qcomtee/qcomtee_private.h | 264 ++++++++++ > drivers/tee/qcomtee/release.c | 48 ++ > drivers/tee/qcomtee/shm.c | 146 ++++++ > drivers/tee/qcomtee/user_obj.c | 713 +++++++++++++++++++++++++++ > drivers/tee/tee_core.c | 127 ++++- > drivers/tee/tee_private.h | 6 - > include/linux/firmware/qcom/qcom_scm.h | 31 +- > include/linux/firmware/qcom/qcom_tee.h | 302 ++++++++++++ > include/linux/firmware/qcom/qcom_tzmem.h | 15 + > include/linux/tee_core.h | 54 +- > include/linux/tee_drv.h | 12 + > include/uapi/linux/tee.h | 54 +- > 29 files changed, 4427 insertions(+), 32 deletions(-) > --- > base-commit: 33035b665157558254b3c21c3f049fd728e72368 > change-id: 20241202-qcom-tee-using-tee-ss-without-mem-obj-362c66340527 > > Best regards, Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK # /unittest -d [test_print_diagnostics_info][52] 831360 = Total bytes as heap [test_print_diagnostics_info][53] 111707 = Total bytes allocated from heap [test_print_diagnostics_info][54] 700160 = Total bytes free on heap [test_print_diagnostics_info][55] 15280 = Total bytes overhead [test_print_diagnostics_info][56] 4213 = Total bytes wasted [test_print_diagnostics_info][57] 454160 = Largest free block size [test_print_diagnostics_info][60] SUCCESS. # /unittest -l / /smcinvoke_skeleton_ta64.mbn 0 [test_read_file][246] File //smcinvoke_skeleton_ta64.mbn, size: 32856 Bytes. [test_load_sample_ta][199] SUCCESS. Thanks, Neil