From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B6DA3F7877 for ; Fri, 15 May 2026 08:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778832743; cv=none; b=clu5RNpOYQZJzpRBgh4kvzMuzvFKdfmwkVlh+Npc05P23gv699rEs4+j62LeCf4BKh8DtY8iC7kO+CWyQSYLm7wA5oiBIoBXnTc0BW1tjbc7XlQHmvoCv7jAAMruVod3XPDVRCzGBvH0AzPfEI6pErB20ni8kYqv4ZLsfcTJPYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778832743; c=relaxed/simple; bh=FktCr/u3rOxg9ueRI8/8hQ2GHcP0pe315k2A5ix3uqM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CCbctrSp3rBPpneKJQ/3QewNUF2GCUVRlhQWLXpaUw/e3eOjoflbMUBdAOWSa6tgcdMvR5HP8D+wTc0YIRB/ZCRkUxehUfdGvECWcHp2JteldWh+C/C4F+06pWGS00iE/LU2UR3uSGDBDTgejLOdagurObro/njaNJqQxWlKfms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ilaXkHX4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VniqRsfv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ilaXkHX4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VniqRsfv" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64F4qL8j3512727 for ; Fri, 15 May 2026 08:12:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6Nfe5u1E6q+Bw4bVcH5OIoGsa4LydTmUn7m5gJGoe3c=; b=ilaXkHX41Ei6F2Ta UIw4O4gSXWAmwyiJgf4l/DbOSh9J/cajVBX4/d6EXu9oSFFxLYqAq3xFR8cebtAq /RSNipukXLv2jh/C/l/6bNNSBPkqE7IA2N5pkBSI4JuYRzpNgJzqNgZY+NyxYgsU nKaZPmmryJgI6OeWwLCE9pP9IA3TLvln25JmtPKgNupwFPoUiFxMD1/OtvnRbreK L/ncghVQnHnv/ucLdZmfygDZl5tjmDflJZZ//T0dZaq9ikRy8lj+fxOzblUegWEH auyee+mcotTXQ/p0FSgM3dMPDgVXwQBAaYk9YhJfI293bBvyWUmSCheSK5FLVU51 Pbh4og== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1vab0k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 08:12:19 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c82894155ceso7079580a12.1 for ; Fri, 15 May 2026 01:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778832738; x=1779437538; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6Nfe5u1E6q+Bw4bVcH5OIoGsa4LydTmUn7m5gJGoe3c=; b=VniqRsfvzsVizd8c6LJP5+XNKX/j5Y/mqCTv+OPzI1iVtq4/V3qsKn1cYnb6CM34/Z oP/7UTkrxpi2mhak/TAPz91rTilS/wkggXhmWgbZaBmvIX9KVyjA2DSkOrHj++PBxnAO CYsSOjt3guHHwyGY0/omAVi5Z+n77Uqc9g9gYp2hW3qHOhcoPR60aRkn2z2FWdttCXK/ bXV+NxLmg//UjlrBw6qg+b0Ur6SYXdz8SReI99qBNwe5bM47XR1WGbzObQeJ9r79uahq oNIML/XsM9uUVZIaptl1o9adbYqVSglAQH2zOiD0QiEMvCK13+HE0JXBv0GS4TqMHlmY Y8AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778832738; x=1779437538; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6Nfe5u1E6q+Bw4bVcH5OIoGsa4LydTmUn7m5gJGoe3c=; b=OcOcM3FEIFL4Wk9c168fIp6fJK3q0p+BYWf2npMm8kdjVwMDW3Cqn6jHk0nJrBi5pp 2y/mH/B2IFEaHdbmQwBHKYo7wzlLBRwr8Ri59xyNrUjYvnko5TPFfCHQuWyRiZdenQKf xhSlDOUpK9I6qia1RENZ//Z/ZUsQOtjAUx3GfMjpxtvQAcQ/7x26i8FRx7vMSgvahEK/ XIqUEWk5mNtEIv2jO6EvXtktWZ4iWI0vYy5c8AT3GX4AoMVqm4rIz+SiuEftiMt8D0YB fucOSZ33Jm1e24u4TBkk4hLE64HzX1LGwx/ckSPHO4cLrS+hiY8J+xtkJPZAXW1BSPSV KgTQ== X-Forwarded-Encrypted: i=1; AFNElJ+4jcw/hrfUqbDX4krnbF1Lsh2aUgvKanNfTXqBkV27FzEsfV73ZNYFdBXiaTC2mj1O0Q4It2VHeDmSYjI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1cuAj4kuLHy0SssVy2xsQuXdc8/sVugw+aomXNhP4oxg57Upy VZrAN/vmJqAUDev8YK4ly50W+uMAfkDweMvhNoezzF7LtlCinIcLLxNJf7bzHP6ER4tkLgJTcyV s4+f/lyQmvkQLVFCXm6DYpZAgWElCaAPcVOp2uMTnzW8+8ZQQiwNhFldvCS8WC8BcPTk= X-Gm-Gg: Acq92OGb5iQE1Qeps3kiAFj0Ghr6fDhi588o0yMVruGl0a5t4pv4xsIxKzK84iHVV39 Nwh/6YNO2yZegoJx8y5peaLq5nvCyj3Il8LYUXXk/32uL9OQ/zpo/RWz3JEwqnAyF3oOmPtIFUb v6LQ2n2x9/QMNKotRFyE4tm+kSnVUoLmxHQlYboyDZ8E7ZjqEWY6nQN4jsckT85UraJ2tWBEsru oyHycp6H3FXD1VEpfSbgQQpz+FtOv/arYYJSaSM+PhO5p+o6jKdsCqz1LGSqXikhfsoRT1bEnQz 04rZ5wOZHx0v7sKtjQLp8YfpqyZPTVakPzMuWTMVLPhi17tG7ZIlIrPEJQk3JtDmLGMUD1UDkyE P59Yi9+mrclFZhEfMFL1592o9BfQ1VzEjIyndE3jeQVQkSi1T/EBHyFCQU9S4g2c2rVZotcbKi6 sUikblyfuVew== X-Received: by 2002:a05:6a20:7f82:b0:3a2:e26b:2940 with SMTP id adf61e73a8af0-3b22e19b526mr3566619637.0.1778832737998; Fri, 15 May 2026 01:12:17 -0700 (PDT) X-Received: by 2002:a05:6a20:7f82:b0:3a2:e26b:2940 with SMTP id adf61e73a8af0-3b22e19b526mr3566570637.0.1778832737404; Fri, 15 May 2026 01:12:17 -0700 (PDT) Received: from [10.133.33.62] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c82bb102415sm4617352a12.19.2026.05.15.01.12.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 01:12:16 -0700 (PDT) Message-ID: <3c54626e-671c-4334-a438-c241886ab8f9@oss.qualcomm.com> Date: Fri, 15 May 2026 16:12:10 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] scsi: ufs: core: Add support for static TX Equalization settings To: Bean Huo , bvanassche@acm.org, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org, powenkao@google.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , Ram Kumar Dwivedi , Nitin Rawat , open list References: <20260501134418.863432-1-can.guo@oss.qualcomm.com> <20260501134418.863432-3-can.guo@oss.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDA4MSBTYWx0ZWRfXwI95LluX0WFL BdrnnJSu5EvP0z/etCb9WH157yBlI1NFgGQ9Zh5GB0mEeOmrp43Ua+gbE1ft8liHlkayelH/NhH N3TNAMMxS1LBbT7a7pzt1k5ImTrG7EAL3g3brxnJoGkhhcub9glnQior9TpgukAFfD+bjmEvJz9 o1VegXn+76KnRsiDauxed6YOfe7p6/0wDTXZlPHZmFcm3tLRDaNB/C9Bt6s8XuXyPSHZT5MSNfH 2u/5+oerOHTdRNwKinKLRaMllBu9fZNAkqAg3+MueexP3ONmUUPnrKT9/oTj8LdDEzfXwLJXM+S e7CRGzjAKYzcIReJADnYMq6zAz223BEQQEWN1rvJjqqRCpKjAlPLOacAb8EzwiTbEAPlAHpxZDA HuJEnUW5aRiiBjcer4Mm3JG/m37HnEvBVLMZUL9I6cBjzRfcmCvul/o8t+z7ib3eTfZO16ERSkQ VMkxseQyc4cBsTZx8GA== X-Proofpoint-GUID: 3aR__tCyz7iaH5TFiUAPFZ3kNDT-wpUm X-Proofpoint-ORIG-GUID: 3aR__tCyz7iaH5TFiUAPFZ3kNDT-wpUm X-Authority-Analysis: v=2.4 cv=BvqtB4X5 c=1 sm=1 tr=0 ts=6a06d563 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=2mUTFIH5eXoRPtnr5RcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150081 Hi Bean, On 5/14/2026 9:57 PM, Bean Huo wrote: > Can, > > > Sorry for the late review of this patch. I have several questions: Not at all sir. > > > On Fri, 2026-05-01 at 06:44 -0700, Can Guo wrote: >> @@ -1297,7 +1297,7 @@ int ufshcd_config_tx_eq_settings(struct ufs_hba *hba, >>         } >> >>         params = &hba->tx_eq_params[gear - 1]; >> -       if (!params->is_valid || force_tx_eqtr) { >> +       if (!params->is_valid || params->is_static || force_tx_eqtr) { > When use_adaptive_txeq is on and params->is_static is true, EQTR will overwrite > the static values. That is reasonable since EQTR is more accurate. Is the > is_static check really needed here? The check of flag is_static is required because we need it to differentiate the static (DTS) settings from the settings retrieved from persistent storage: - If settings are retrieved from persistent storage, TX EQTR should be skipped. - If settings are from DTS, TX EQTR should execute anyways to override static settings. > >>                 int ret; >> >> > ... > >> >>  void ufshcd_retrieve_tx_eq_settings(struct ufs_hba *hba) >> diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd- >> pltfrm.c >> index c2dafb583cf5..de6302e8c067 100644 >> --- a/drivers/ufs/host/ufshcd-pltfrm.c >> +++ b/drivers/ufs/host/ufshcd-pltfrm.c >> @@ -210,6 +210,86 @@ static void ufshcd_init_lanes_per_dir(struct ufs_hba >> *hba) >>         } >>  } >> >> +static void ufshcd_parse_static_tx_eq_settings(struct ufs_hba *hba) >> +{ >> +       size_t sz = hba->lanes_per_direction * 2 * TX_EQ_SETTINGS_TUPLE_SZ; >> +       u32 settings[UFS_MAX_LANES * 2 * TX_EQ_SETTINGS_TUPLE_SZ]; >> +       u32 *host_settings, *device_settings; >> +       u32 lpd = hba->lanes_per_direction; >> +       struct ufshcd_tx_eq_params *params; >> > .... >> + >> +               params = &hba->tx_eq_params[gear - 1]; >> +               host_settings = settings; >> +               device_settings = settings + lpd * TX_EQ_SETTINGS_TUPLE_SZ; >> + >> +               for (lane = 0; lane < lpd; lane++) { >> +                       params->host[lane].preshoot = host_settings[0]; >> +                       params->host[lane].deemphasis = host_settings[1]; >> +                       params->host[lane].precode_en = host_settings[2]; >> +                       host_settings += TX_EQ_SETTINGS_TUPLE_SZ; >> + >> +                       params->device[lane].preshoot = device_settings[0]; >> +                       params->device[lane].deemphasis = device_settings[1]; >> +                       params->device[lane].precode_en = device_settings[2]; >> +                       device_settings += TX_EQ_SETTINGS_TUPLE_SZ; >> +               } >> + >> +               params->is_valid = true; >> +               params->is_static = true; > I want to confirm I understand the code correctly. Please tell me if I am wrong: > > 1, When use_adaptive_txeq = 0: static values are used directly as TX EQ for HS- > G4 to G6. But ufshcd_config_tx_eq_settings() returns early when > use_adaptive_txeq = 0. So which function applies the static values in this > case? ufshcd_post_device_init()->     ufshcd_tune_unipro_params()->         ufshcd_apply_valid_tx_eq_settings() > > 2, when use_adaptive_txeq = 1: static host values are used as the fixed host TX > EQ during EQTR. This is because ufs_qcom_get_rx_fom() only sweeps the device > side. It reads host values from hba->tx_eq_params[gear-1]->host[]. The static > values also work as the per-lane fallback in ufshcd_update_tx_eq_params() when > FOM is 0. Correct. > >> +       } >> +} >> + >>  /** >>   * ufshcd_parse_clock_min_max_freq  - Parse MIN and MAX clocks freq >>   * @hba: per adapter instance >> @@ -528,6 +608,8 @@ int ufshcd_pltfrm_init(struct platform_device *pdev, >> >>         ufshcd_init_lanes_per_dir(hba); >> >> +       ufshcd_parse_static_tx_eq_settings(hba); >> + >>         err = ufshcd_parse_operating_points(hba); >>         if (err) { >>                 dev_err(dev, "%s: OPP parse failed %d\n", __func__, err); >> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h >> index f48d6416e299..2d385d42fcff 100644 >> --- a/include/ufs/ufshcd.h >> +++ b/include/ufs/ufshcd.h >> @@ -359,6 +359,7 @@ struct ufshcd_tx_eqtr_record { >>   * @is_valid: True if parameter contains valid TX Equalization settings >>   * @is_applied: True if settings have been applied to UniPro of both sides >>   * @is_trained: True if parameters obtained from TX EQTR procedure >> + * @is_static: True if settings are static >>   */ >>  struct ufshcd_tx_eq_params { >>         struct ufshcd_tx_eq_settings host[UFS_MAX_LANES]; >> @@ -367,8 +368,12 @@ struct ufshcd_tx_eq_params { >>         bool is_valid; >>         bool is_applied; >>         bool is_trained; >> +       bool is_static; > is_static is added next to is_trained, which was added in your "Add persistent > TX Equalization settings support" series, That series still has Brian's open > question about wTxEQGnSettingsExt Bit[15] being RFU per JESD220H: > > https://patchwork.kernel.org/project/linux-scsi/cover/20260424151420.111675-1-can.guo@oss.qualcomm.co > > Is this the reason why "Add persistent..." has not been merged? > > I'd prefer to wait until that discussion concludes before tagging this one. I > hope this is ok for you. The persistent patch series has been merged by Martin, we just need to wait for Martin to push the branch, then I will upload Patch V2 to address the comment from Conor. Thanks, Can Guo. > > Kind regards, > Bean > >