mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michal Simek <michal.simek@xilinx.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	git@amd.com, saikrishna12468@gmail.com
Subject: Re: [PATCH v3 3/3] mmc: sdhci-of-arasan: Skip setting clock delay for 400KHz
Date: Tue, 11 Apr 2023 13:14:37 +0300	[thread overview]
Message-ID: <3c57dc23-5b97-7cc1-8d88-1bed91119bea@intel.com> (raw)
In-Reply-To: <20230403102551.3763054-4-sai.krishna.potthuri@amd.com>

On 3/04/23 13:25, Sai Krishna Potthuri wrote:
> Clock delay settings are not defined for 400KHz, so add frequency check
> to skip calling the clock delay settings when frequency is <=400KHz.
> 
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-of-arasan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index c3fecb8ba66e..d9a29c346745 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -413,7 +413,7 @@ static void sdhci_arasan_set_clock(struct sdhci_host *host, unsigned int clock)
>  	}
>  
>  	/* Set the Input and Output Clock Phase Delays */
> -	if (clk_data->set_clk_delays)
> +	if (clk_data->set_clk_delays && clock > PHY_CLK_TOO_SLOW_HZ)
>  		clk_data->set_clk_delays(host);
>  
>  	if (sdhci_arasan->internal_phy_reg && clock >= MIN_PHY_CLK_HZ) {


  reply	other threads:[~2023-04-11 10:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 10:25 [PATCH v3 0/3] mmc: sdhci-of-arasan: Add eMMC5.1 support for Xilinx Versal Net Sai Krishna Potthuri
2023-04-03 10:25 ` [PATCH v3 1/3] dt-bindings: mmc: arasan,sdci: Add Xilinx Versal Net compatible Sai Krishna Potthuri
2023-04-03 10:25 ` [PATCH v3 2/3] mmc: sdhci-of-arasan: Add support for eMMC5.1 on Xilinx Versal Net platform Sai Krishna Potthuri
2023-04-11 10:14   ` Adrian Hunter
2023-04-03 10:25 ` [PATCH v3 3/3] mmc: sdhci-of-arasan: Skip setting clock delay for 400KHz Sai Krishna Potthuri
2023-04-11 10:14   ` Adrian Hunter [this message]
2023-04-17 14:53 ` [PATCH v3 0/3] mmc: sdhci-of-arasan: Add eMMC5.1 support for Xilinx Versal Net Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c57dc23-5b97-7cc1-8d88-1bed91119bea@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=git@amd.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=sai.krishna.potthuri@amd.com \
    --cc=saikrishna12468@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®