From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC3E947D955 for ; Thu, 4 Jun 2026 16:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780591353; cv=none; b=ufuE17DYoSDU/wqvdkcMWIyJ+xMcB8RPSR1k/q1s7fEw0hDTavVhL3SkGms+l4mattIf19Ksdx1OIukwQvNRf3Jh88UeoOjaLoiVk39fKffWl6UYUzXJs5j7Hi36BhGwCEcFbdmw6Y0tiMyx+KOLH0nftBxXyehWxCgj+gPTZqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780591353; c=relaxed/simple; bh=VrfPxcrEiUW68U2VvJcMYQUP1mBPBhz7Fp1qMiCeqts=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CSIYWS3BQHtfgNerc8uATxt9HAeoffh/gRnFdNANgri7I7hSpcWFYuYi03zxaRxF3tyIF99APfmtkGCAaAuImi19EDXhsDSosd1motCK1ycScSWq5wjL6kkk86HECjgTz7ivFZH/4pN7vCQyV9ahRxABxZHCvs6GwqYvIxpfGO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BN7PbH0Y; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BN7PbH0Y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780591351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rbFlf+QZPUm0qiHv62skAFpJGqb6dqbq+PLu+pqpMyg=; b=BN7PbH0Yl8549B8d/kW30s3wzoUTxJEzQSbwPMx9iLVnhkUr8OQKL6asceBqRPEfe9bY6L xgV8ucRYMYhc1zZNzhtYTyqbom1hbeqfehKJ+3D4ILHF+jaT/iEF35XtUifo4jDloVQ2Al 2R68+Unp/LRVoAG2ckyDrCULAYHxrKQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-422-ITwVgE21ND27_SDgSFIh7w-1; Thu, 04 Jun 2026 12:42:26 -0400 X-MC-Unique: ITwVgE21ND27_SDgSFIh7w-1 X-Mimecast-MFC-AGG-ID: ITwVgE21ND27_SDgSFIh7w_1780591344 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 341F51956050; Thu, 4 Jun 2026 16:42:24 +0000 (UTC) Received: from [10.44.49.177] (unknown [10.44.49.177]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7BC79195608E; Thu, 4 Jun 2026 16:42:19 +0000 (UTC) Message-ID: <3c5e01f5-8563-41a3-964f-13fcb80383b7@redhat.com> Date: Thu, 4 Jun 2026 18:42:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 1/4] dpll: add DPLL_PIN_TYPE_INT_NCO pin type To: Jakub Kicinski Cc: Arkadiusz Kubalewski , Vadim Fedorenko , netdev@vger.kernel.org, Jiri Pirko , "David S. Miller" , Donald Hunter , Eric Dumazet , Jiri Pirko , Michal Schmidt , Paolo Abeni , Pasi Vaananen , Petr Oros , Prathosh Satish , Simon Horman , linux-kernel@vger.kernel.org, Grzegorz Nitka References: <20260531194423.383366-1-ivecera@redhat.com> <20260531194423.383366-2-ivecera@redhat.com> <20260603185037.05f8c6a0@kernel.org> <20260604081649.1ae5302d@kernel.org> Content-Language: en-US From: Ivan Vecera In-Reply-To: <20260604081649.1ae5302d@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 6/4/26 5:16 PM, Jakub Kicinski wrote: > On Thu, 4 Jun 2026 17:01:36 +0200 Ivan Vecera wrote: >>> Purely going on intuition here but feels like NCO should be a mode >>> (enum dpll_mode) rather than one of the input pins? >>> >>> More acks here would be great, Vadim, Arkadiusz, Grzegorz... ? >> >> I had a long discussion with Jiri about this and we agreed finally >> that dpll_mode represents a reference (input pin) selection strategy >> mode and not a DPLL device running mode. > > Long discussion? I see 2 emails ;) Let's hear from others. > (thanks for the link BTW, _if_ there's a v6 please put it in the cover > letter) I called him... he explained me 'why?' in detail. I also appreciate others' opinion. I.