From: Markus Elfring <Markus.Elfring@web.de>
To: Gyeyoung Baek <gye976@gmail.com>,
linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: iio: imu: inv_mpu6050: Remove duplicate code between labels
Date: Mon, 2 Sep 2024 08:00:46 +0200 [thread overview]
Message-ID: <3c60e167-7815-49c8-89f1-fe1139879d6b@web.de> (raw)
In-Reply-To: <CAKbEznu=+Bkw4kmoo7qG9h2wM=2XV54j_SYzHMAH1uWhtUPCvg@mail.gmail.com>
>>> Hello, I apologize for the insufficient explanation.
>>
>> How will the commit message be improved further?
…
> Since the code is short,
This implementation detail can be nice.
> I think it's fine for now.
Please reconsider such a view once more.
Are imperative wordings also more desirable for a better change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6#n45
Regards,
Markus
next prev parent reply other threads:[~2024-09-02 6:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 9:12 [PATCH] " Gyeyoung Baek
2024-09-01 12:08 ` Markus Elfring
2024-09-01 13:40 ` gyeyoung
2024-09-02 10:04 ` Jean-Baptiste Maneyrol
2024-09-02 11:15 ` gyeyoung
[not found] ` <CAKbEznv-TmCr2FAodrM2SKK5A5pbV9p5-OvXPdmuk_4xXmh=Rw@mail.gmail.com>
2024-09-01 18:16 ` Markus Elfring
2024-09-02 1:59 ` gyeyoung
2024-09-02 6:00 ` Markus Elfring [this message]
2024-09-02 1:26 ` gyeyoung
2024-09-02 11:20 ` Markus Elfring
2024-09-02 9:54 ` Jean-Baptiste Maneyrol
2024-09-02 10:36 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c60e167-7815-49c8-89f1-fe1139879d6b@web.de \
--to=markus.elfring@web.de \
--cc=gye976@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®